Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Nov 24, 2025

Proposed changes (including videos or screenshots)

  • What reporter should we use?

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: e5f31b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/apps-engine-tests-conversion-start

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch 3 times, most recently from a26e94a to 65704b0 Compare November 24, 2025 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +1.2KiB
queue-worker-service 132MiB 132MiB -249B
ddp-streamer-service 126MiB 126MiB +998B
account-service 113MiB 113MiB -434B
stream-hub-service 111MiB 111MiB +1.1KiB
authorization-service 111MiB 111MiB -1.2KiB
presence-service 111MiB 111MiB +1.4KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 01:06 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 12 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37592
  • Baseline: develop
  • Timestamp: 2025-12-04 01:06:16 UTC
  • Historical data points: 12

Updated: Thu, 04 Dec 2025 01:06:16 GMT

@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch from 65704b0 to efab48a Compare November 24, 2025 17:31
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (355d26d) to head (e76a09d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #37592   +/-   ##
========================================
  Coverage    68.79%   68.79%           
========================================
  Files         3361     3361           
  Lines       114201   114201           
  Branches     20619    20619           
========================================
  Hits         78563    78563           
+ Misses       33543    33538    -5     
- Partials      2095     2100    +5     
Flag Coverage Δ
e2e 57.27% <ø> (+0.01%) ⬆️
e2e-api 42.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch 3 times, most recently from 5ac05ef to ccfc97d Compare November 24, 2025 23:10
@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch from ccfc97d to 096c003 Compare December 2, 2025 11:39
@d-gubert
Copy link
Member Author

d-gubert commented Dec 2, 2025

@copilot following the pattern in this PR, convert the file packages/apps-engine/tests/server/AppManager.spec.ts to a new test using NodeJS built-in test framework.

Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description.

@d-gubert
Copy link
Member Author

d-gubert commented Dec 2, 2025

@copilot review this pr

@RocketChat RocketChat deleted a comment from Copilot AI Dec 2, 2025
@RocketChat RocketChat deleted a comment from Copilot AI Dec 2, 2025
@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch from 91eda49 to e76a09d Compare December 2, 2025 22:10
@d-gubert
Copy link
Member Author

d-gubert commented Dec 2, 2025

@copilot following the pattern in this PR, convert the file packages/apps-engine/tests/server/managers/AppAccessorManager.spec.ts to a new test using NodeJS built-in test framework.

Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description.

Copy link

Copilot AI commented Dec 2, 2025

@d-gubert I've opened a new pull request, #37678, to work on those changes. Once the pull request is ready, I'll request review from you.

@d-gubert
Copy link
Member Author

d-gubert commented Dec 3, 2025

@copilot select another test file inside packages/apps-engine/tests/server/*, and convert it to use the NodeJS builtin framework, following the pattern in this PR.

Be sure to select only one test file to convert, and avoid modifying files outside the packages/apps-engine/tests/node-tests directory.

Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file.

Copy link

Copilot AI commented Dec 3, 2025

@d-gubert I've opened a new pull request, #37683, to work on those changes. Once the pull request is ready, I'll request review from you.

@d-gubert d-gubert force-pushed the chore/apps-engine-tests-conversion-start branch from 61ed950 to e5f31b2 Compare December 4, 2025 00:40
@d-gubert
Copy link
Member Author

d-gubert commented Dec 4, 2025

@copilot finish the conversion of the test files from Alsatian to NodeJS, following the pattern in this PR.

Avoid modifying files outside the packages/apps-engine/tests/node-tests directory. Create 1 commit per new test file, to make reviewing easier.

Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file.

Copy link

Copilot AI commented Dec 4, 2025

@d-gubert I've opened a new pull request, #37694, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants