-
Notifications
You must be signed in to change notification settings - Fork 12.6k
chore: start test conversion from Alsatian to NodeJS #37592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a26e94a to
65704b0
Compare
65704b0 to
efab48a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37592 +/- ##
========================================
Coverage 68.79% 68.79%
========================================
Files 3361 3361
Lines 114201 114201
Branches 20619 20619
========================================
Hits 78563 78563
+ Misses 33543 33538 -5
- Partials 2095 2100 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5ac05ef to
ccfc97d
Compare
ccfc97d to
096c003
Compare
|
@copilot following the pattern in this PR, convert the file Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description. |
|
@copilot review this pr |
91eda49 to
e76a09d
Compare
|
@copilot following the pattern in this PR, convert the file packages/apps-engine/tests/server/managers/AppAccessorManager.spec.ts to a new test using NodeJS built-in test framework. Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description. |
|
@copilot select another test file inside packages/apps-engine/tests/server/*, and convert it to use the NodeJS builtin framework, following the pattern in this PR. Be sure to select only one test file to convert, and avoid modifying files outside the packages/apps-engine/tests/node-tests directory. Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file. |
61ed950 to
e5f31b2
Compare
|
@copilot finish the conversion of the test files from Alsatian to NodeJS, following the pattern in this PR. Avoid modifying files outside the packages/apps-engine/tests/node-tests directory. Create 1 commit per new test file, to make reviewing easier. Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file. |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments