chore!: removes livechat:removeMonitor deprecated method
#37662
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 026f4d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request removes the deprecated Meteor server method Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes This is a straightforward removal of deprecated code with a consistent, repetitive pattern across a minimal set of files. No complex logic changes or refactoring required—simply deletion and import cleanup. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Docker Image Size Report📈 Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 13:41", "12/10 14:08 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Statistics (last 17 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Wed, 10 Dec 2025 14:08:20 GMT |
ggazzo
force-pushed
the
release-8.0.0
branch
6 times, most recently
from
590f91c to
538b89b
Compare
ggazzo
force-pushed
the
release-8.0.0
branch
from
0fe2977 to
70ac0c9
Compare
ggazzo
force-pushed
the
chore/v8/CORE-1415
branch
from
86ff8a5 to
026f4d0
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.changeset/rotten-bees-behave.md(1 hunks)apps/meteor/ee/app/livechat-enterprise/server/index.ts(0 hunks)apps/meteor/ee/app/livechat-enterprise/server/methods/removeMonitor.ts(0 hunks)
💤 Files with no reviewable changes (2)
- apps/meteor/ee/app/livechat-enterprise/server/methods/removeMonitor.ts
- apps/meteor/ee/app/livechat-enterprise/server/index.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
Applied to files:
.changeset/rotten-bees-behave.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
| --- | ||
| "@rocket.chat/meteor": patch | ||
| --- |
There was a problem hiding this comment.
Reconsider the version bump level for removing a deprecated method.
Removing the livechat:removeMonitor method is a breaking change—any code still consuming this deprecated method will fail at runtime. Since this is a breaking change being released on release-8.0.0 (a major version branch), the changeset should document this as a major version bump, not patch.
Apply this diff to correct the version bump level:
---
- "@rocket.chat/meteor": patch
+ "@rocket.chat/meteor": major
---📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --- | |
| "@rocket.chat/meteor": patch | |
| --- | |
| --- | |
| "@rocket.chat/meteor": major | |
| --- |
🤖 Prompt for AI Agents
.changeset/rotten-bees-behave.md lines 1-3: the changeset currently marks
"@rocket.chat/meteor" as a patch but the removal of the deprecated
livechat:removeMonitor is a breaking change — update the changeset frontmatter
to use a "major" bump for "@rocket.chat/meteor" (replace "patch" with "major")
and save/commit the changeset so the release tooling will publish a major
release.
Proposed changes (including videos or screenshots)
This PR removes the deprecated meteor method;
livechat:removeMonitorIssue(s)
CORE-1415
Steps to test or reproduce
Further comments
Summary by CodeRabbit
livechat:removeMonitormethod. Applications using this functionality should implement alternative approaches for managing livechat monitors.✏️ Tip: You can customize this high-level summary in your review settings.