Update to keyboard-types 0.8.3; migrate to NamedKey across platforms
#214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace deprecated `Key::<Variant>` usages with `Key::Named(NamedKey::<Variant>)` - Map unidentified and dead keys to `Key::Named(NamedKey::Unidentified)` and `Key::Named(NamedKey::Dead)` - Keep `Key::Character(String)` for printable characters - Update platform keymaps (macOS, X11, Windows) to 0.8 API keyboard-types 0.8 moved non-character keys into `NamedKey`. This adapts the platform mappings to the new API, aligning emitted `KeyboardEvent.key` with the spec-compliant representation.
waywardmonkeys
commented
Nov 9, 2025
| Code::Tab => Key::Tab, | ||
| Code::Backspace => Key::Backspace, | ||
| Code::ContextMenu => Key::ContextMenu, | ||
| Code::NumLock => Key::Named(NamedKey::Clear), |
Author
There was a problem hiding this comment.
I maintained the existing behavior here, but this one seems odd.
Author
|
I built this on macOS, but I don't use I have a family of crates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key::<Variant>usages withKey::Named(NamedKey::<Variant>)Key::Named(NamedKey::Unidentified)andKey::Named(NamedKey::Dead)Key::Character(String)for printable characterskeyboard-types 0.8 moved non-character keys into
NamedKey. This adapts the platform mappings to the new API, aligning emittedKeyboardEvent.keywith the spec-compliant representation.