rust 1.83 clippy fixup #1640
Merged
rust 1.83 clippy fixup #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/clippy-1.83
branch
from
e4f3875 to
541d76d
Compare
baloo
commented
Jan 27, 2025
| let last_byte = checked_add!(pos, 1) == total; | ||
| let mask = if last_byte { 0 } else { 0b10000000 }; | ||
| let shift = checked_sub!(checked_sub!(total, pos), 1) * 7; | ||
| let shift = checked_mul!(checked_sub!(checked_sub!(total, pos), 1), 7); |
Member
Author
There was a problem hiding this comment.
This fixes this warning:
warning: arithmetic operation that can potentially result in unexpected side-effects
--> const-oid/src/encoder.rs:135:17
|
135 | let shift = checked_sub!(checked_sub!(total, pos), 1) * 7;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arithmetic_side_effects
note: the lint level is defined here
--> const-oid/src/lib.rs:11:5
|
11 | clippy::arithmetic_side_effects,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I don't think the shift should overflow in the first place, but clippy still warns about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small fixes clippy is going to raise with rust 1.83. Those did not come up in CI yet because we're pinned at 1.81 but they are annoying when running clippy manually.