der: remove lifetime from OctetStringRef
#1998
Merged
+146
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Custom derive needs to be updated to be aware that certain types are reference types and need to be used as e.g. |
tarcieri
force-pushed
the
der/remove-octet-string-ref-lifetime
branch
from
8cee1e0 to
2359ca5
Compare
tarcieri
commented
Aug 18, 2025
dishmaker
reviewed
Aug 19, 2025
tarcieri
force-pushed
the
der/remove-octet-string-ref-lifetime
branch
4 times, most recently
from
54b1fbb to
2a06eca
Compare
Member
Author
|
Well, with a few hacks this is green. I think the hacks might be OK to merge with, but we'd ideally want to get them removed before a final release. |
tarcieri
changed the title
OctetStringRefOctetStringRef
tarcieri
commented
Sep 15, 2025
Comment on lines
+8
to
+10
| // TODO(tarcieri): custom derive hack until the logic is updated to support `&'a` reference types | ||
| #[doc(hidden)] | ||
| pub type OctetStringRef2<'a> = &'a OctetStringRef; |
Member
Author
There was a problem hiding this comment.
This is one of the hacks. I didn't implement special case support for &'a MyRef types in der_derive yet, so this hack lets it use the old syntax.
Following the pattern of #1921, removes the lifetime from the struct, instead changing `OctetStringRef` to a proper reference type to be used as `&OctetStringRef`. This makes it possible to `impl Borrow<OctetStringRef> for OctetString` and `impl ToOwned for OctetStringRef`, so they can work with `Cow`.
tarcieri
force-pushed
the
der/remove-octet-string-ref-lifetime
branch
from
2a06eca to
77c4d20
Compare
Member
Author
|
Gonna land this. We can work through custom derive support separately. I'll make an issue about it. Edit: opened #2039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the pattern of #1921, removes the lifetime from the struct, instead changing
OctetStringRefto a proper reference type to be used as&OctetStringRef.This makes it possible to
impl Borrow<OctetStringRef> for OctetStringandimpl ToOwned for OctetStringRef, so they can work withCow.cc @dishmaker