Skip to content

fix for decimal conversion for type BCD #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix for decimal conversion for type BCD #382

wants to merge 1 commit into from

Conversation

@thomasaugsten
Copy link

@thomasaugsten thomasaugsten commented Jul 25, 2025

Fix for #379

Return as string instead of Decimal when casting is failing

@shenyinabcd
Copy link

shenyinabcd commented Nov 14, 2025

Fix for #379

Return as string instead of Decimal when casting is failing

Almost the same solution as mine, which returns Decimal("0") instead of the original string. But I think maybe your solution is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanblm nathanblm nathanblm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasaugsten @shenyinabcd @nathanblm