-
Notifications
You must be signed in to change notification settings - Fork 23
[STORY-2698] feat(db-ng): Use new DatabaseNG from go-scalingo #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[STORY-2698] feat(db-ng): Use new DatabaseNG from go-scalingo #1164
Conversation
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0 |
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is not ready to be merged yet, as the SDK is not released. Nonethess, something weird happened. You updated a vendor file without impacting the go.mod.
What you can do to open a PR that is "clean" even if not definitive.
go get -u github.com/Scalingo/go-scalingo/v8@feat/db-ng/use-database-object-from-api
go mod tidy
go mod vendorI think that would work 🙂
curzolapierre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example in the PR's description please?
|
Did a last QA session:
db seems empty but the db is created
|
Related to [STORY-2698]
Depends on Scalingo/go-scalingo#441
This PR remove the usage of App and Addon returned from api database endpoint. The
DatabaseNGtype has been updated. There is no new feature