Skip to content

Fix(Sample): Archiving failing due to duplicate build outputs #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Fix(Sample): Archiving failing due to duplicate build outputs #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fbd3c
fix(sample): archiving unsuccessful
kieran-osgood-shopify Oct 31, 2025
d439d2e
feat: cleanup unnecessary workarounds for archiving ios
kieran-osgood-shopify Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions sample/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ target 'ReactNative' do
:new_arch_enabled => true
)

# Pod dependency should be inside the target block
pod "RNShopifyCheckoutSheetKit", :path => "../../modules/@shopify/checkout-sheet-kit"

target 'ReactNativeTests' do
inherit! :complete
end
Expand All @@ -41,19 +44,5 @@ target 'ReactNative' do
:mac_catalyst_enabled => false,
:ccache_enabled => true
)

# WORKAROUND
# This fixes issues with the 'React-Core-AccessibilityResources' dependency when archiving the sample app in XCode:
installer.pods_project.targets.each do |target|
if target.name == "React-Core-AccessibilityResources"
target.remove_from_project
end

if target.name == "React-Core-RCTI18nStrings"
target.remove_from_project
end
end
end
end

pod "RNShopifyCheckoutSheetKit", :path => "../../modules/@shopify/checkout-sheet-kit"
2 changes: 1 addition & 1 deletion sample/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2888,6 +2888,6 @@ SPEC CHECKSUMS:
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
Yoga: a742cc68e8366fcfc681808162492bc0aa7a9498

PODFILE CHECKSUM: 42a4ad42b0177ca0f927363d8f2b6059c6dd77c7
PODFILE CHECKSUM: f2daae5c793dd9545ae6e55c038d9108806ba98c

COCOAPODS: 1.15.2
6 changes: 4 additions & 2 deletions sample/ios/ReactNative/ReactNative.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
<key>com.apple.developer.associated-domains</key>
<array>
<string>webcredentials:myshopify.com</string>
<string>applinks:myshopify.com</string>
<string>applinks:myshopify.com</string>
</array>
<key>com.apple.developer.in-app-payments</key>
<true/>
<array>
<string>merchant.com.shopify.example.CheckoutKitReactNative.ApplePay</string>
</array>
</dict>
</plist>
Loading