Add support for skipping tapioca importing hand written RBIs #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
force-pushed
the
ko/fix-ci-3
branch
from
3efd6e4 to
9c3b8a1
Compare
egiurleo
reviewed
Nov 5, 2025
index.json
Outdated
Comment on lines
135
to
137
| "requires": [ | ||
| "stripe" | ||
| ], |
Contributor
There was a problem hiding this comment.
Sorry this is me being ignorant -- why do we have to add "stripe" to the requires list here?
Contributor
Author
There was a problem hiding this comment.
Not at all. That's left over from debugging unresolved constants. Will remove, thanks.
Generated RBIs contain signatures that don't have fully namespaced types. It looks like a variation of Shopify/tapioca#2248. Until that's fixed I think best course of option is to skip the types during testing.
KaanOzkan
force-pushed
the
ko/fix-ci-3
branch
from
9c3b8a1 to
885fa91
Compare
paracycle
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated RBIs for
stripecontain signatures that don't have fully namespaced types. It looks like a variation of Shopify/tapioca#2248. Until that's fixed I think best course of option is to skip the types during testing.Example failure: https://github.com/Shopify/rbi-central/actions/runs/18990376864/job/54242034571?pr=344#step:4:20836