Skip to content

Conversation

@tomash
Copy link

@tomash tomash commented Apr 18, 2025

A twin of byroot/pubsubstub#2

Context: on Heroku Key-Value addon (Valkey fork of Redis), they use TLS but with a self-signed certificate, as described here:

This PR adds REDIS_SSL_VERIFY environment variable to make it work without patching Shipit's top-level module in-application.

No test coverage because no existing spec covers Redis connection.

@tomash
Copy link
Author

tomash commented Apr 18, 2025

I have signed the CLA!

@casperisfine
Copy link
Contributor

Sorry for the slow response I was at a conference. Just like for pubsubstub, there is a redis= method so that you can do all the custom configuration you need. So I don't think this is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants