feat: limit to single studio #1450 #1534
Conversation
This is not strict about it, if a system has more than one then it will simply get a stuck migration. Once the system has a single studio it will not allow adding or removing any.
Julusian
added
Contribution from SuperFly.tv
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
|
||
| {studios.map((studio) => ( | ||
| <SettingsMenuStudio key={unprotectString(studio._id)} studio={studio} /> | ||
| <SettingsMenuStudio key={unprotectString(studio._id)} studio={studio} canDelete={canDeleteStudio} /> |
There was a problem hiding this comment.
It seems that after resolving migration steps, canDelete will always be false? If that's the case, does it still make sense to propagate this property rather than removing the button altogether?
There was a problem hiding this comment.
The migration relies on the user to 'manually' fixup the system if there is more than 1 studio.
This button is the easiest way to do that, the other being to do it directly in mongodb.
So at this stage of being a soft-enforcmenet of 1 studio, I thought this was best to make it easy to resolve.
But yes as some point when we it is strongly enforced that there is 1 studio, then yes this should go away
3 participants
About the Contributor
This pull request is posted on behalf of Superfly
Type of Contribution
This is a: Feature / Code improvement / Documentation improvement
Current Behavior
Sofie currently supports any number of studios
New Behavior
As discussed in #1450, this starts to remove support for having more than 1 studio.
At this stage it simply attempts to stop it from being possible to create more than 1, or to delete the last studio, and adds a migration to complain if there is more than 1.
This is the first stage of this, once this is merged future changes could start to assume that there is only one studio in the system.
Testing
Affected areas
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Status