Skip to content

Conversation

@JerelJr
Copy link

@JerelJr JerelJr commented May 10, 2024

Resolves #10

  • Adds an 'app' module for the TUI code.
  • Added modal interface to allow the user to switch scroll control between output box and input box using Esc key
  • Updated dependencies
  • Implemented clippy suggestions

@JerelJr JerelJr marked this pull request as ready for review May 10, 2024 23:23
Copy link
Collaborator

@the-Jamz the-Jamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, when I have a minute I'll check this across a few platforms to make sure everything is still working given the dependency updates. Thanks a lot for all the work you've done here!

}
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could improve readability if we reduce the nesting here somehow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I combined some conditions from nested if statements and moved event handling into a separate function to help with this.

@JerelJr
Copy link
Author

JerelJr commented Sep 14, 2024

Feel free to let me know if there is anything I can do to help move things forward. I understand that the dependency updates may require additional testing so if there is a way that I can help with that, I am happy to contribute to make the process smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better terminal UI with seperation of input and output

2 participants