Align mustache tag scope with other languages #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies mustache tag scopes to align with majority of template languages, which already use `meta.embedded` or `meta.embedded.expression`. Motivation is a common scope for embedded template code. Various template languages support both, control flow like statements and string interpolations while not always being able to reliably distinguish both syntax-wise. Another aspect is embedded languages (e.g. JavaScript) also supporting native string interpolation. Hence a distinction between embedded template code and such native interpolations seems useful.
deathaxe
added a commit
that referenced
this pull request
Dec 18, 2024
Align mustache tag scope with other languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies mustache tag scopes to align with majority of template
languages, which already use
meta.embeddedormeta.embedded.expression.Motivation is a common scope for embedded template code.
Various template languages support both, control flow like statements
and string interpolations while not always being able to reliably distinguish
both syntax-wise.
Another aspect is embedded languages (e.g. JavaScript) also supporting native
string interpolation. Hence a distinction between embedded template code and
such native interpolations seems useful.
Overview
At the time of writing...
<% meta.embedded %><%= meta.embedded %>n.v.{ meta.interpolation }@meta.embedded{{ meta.interpolation }}<% meta.embedded %><%- meta.embedded %>{{ if meta.interpolation }}{{ meta.interpolation }}{# meta.embedded}, {/meta.embedded}{{ meta.embedded }}{% meta.embedded.statement %}{{ meta.embedded.expression }}<% meta.embedded.scriptlet %><%= meta.embedded.expression %>{% meta.embedded %}{{ meta.interpolation }}n.v.{{ meta.embedded.expression }}@meta.embedded.statement{{ meta.embedded.expression }}<? meta.embedded.statement ?><?= meta.embedded.expression ?>{# meta.embedded}, {/meta.embedded}{{ meta.embedded }}{% meta.embedded.statement %}{{ meta.embedded.expression }}n.v.{{ meta.embedded.expression }}