-
Notifications
You must be signed in to change notification settings - Fork 24
7강 과제 제출 류승민 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3yuseungmin
wants to merge
1
commit into
TEAM-ALOM:main
Choose a base branch
from
3yuseungmin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
7강 과제 제출 류승민 #8
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,17 @@ import { getWeatherDescription, formatDailyData } from "../utils/weather"; | |
| const DailyForecast = ({ weatherData }) => { | ||
| const dailyData = formatDailyData(weatherData); | ||
|
|
||
| return <div>채워주세요</div>; | ||
| return ( | ||
| <DailyForecastWrapper> | ||
| {dailyData.map((day, index) => ( | ||
| <DailyItem key={index}> | ||
| <div>{day.date}</div> | ||
| <div>{getWeatherDescription(day.code)}</div> | ||
| <div>{day.temp}°C</div> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도! |
||
| </DailyItem> | ||
| ))} | ||
| </DailyForecastWrapper> | ||
| ); | ||
| }; | ||
|
|
||
| export default DailyForecast; | ||
| export default DailyForecast; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,12 +21,44 @@ export const getWeatherDescription = (code) => { | |
|
|
||
| export const formatHourlyData = (weatherData) => { | ||
| if (!weatherData) return []; | ||
| // 밑에 코드 채워주세요 | ||
| return []; | ||
|
|
||
| const times = weatherData.hourly.time; | ||
| const temps = weatherData.hourly.temperature_2m; | ||
| const codes = weatherData.hourly.weather_code; | ||
|
|
||
| const now = new Date(); | ||
| const currentHour = now.getHours(); | ||
|
|
||
| const result = []; | ||
| for (let i = 0; i < times.length; i++) { | ||
| const hour = new Date(times[i]).getHours(); | ||
| if (hour >= currentHour && result.length < 12) { | ||
| result.push({ | ||
| time: `${hour}시`, | ||
| temp: temps[i], | ||
| code: codes[i], | ||
| }); | ||
| } | ||
| if (result.length >= 12) break; | ||
| } | ||
|
|
||
| return result; | ||
| }; | ||
|
Comment on lines
+33
to
46
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 반복문 조건에 추가하면 어떨까요? |
||
|
|
||
| export const formatDailyData = (weatherData) => { | ||
| if (!weatherData) return []; | ||
| // 밑에 코드 채워주세요 | ||
| return []; | ||
| }; | ||
|
|
||
| const dates = weatherData.daily.time; | ||
| const temps = weatherData.daily.temperature_2m_max; | ||
| const codes = weatherData.daily.weather_code; | ||
|
|
||
| return dates.map((dateStr, index) => { | ||
| const date = new Date(dateStr); | ||
| const weekday = date.toLocaleDateString("ko-KR", { weekday: "long" }); | ||
| return { | ||
| date: weekday, | ||
| temp: temps[index], | ||
| code: codes[index], | ||
| }; | ||
| }); | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
온도 소수점까지 반환하던데 날씨 앱에서 보통 소수점까진 출력 안하니 반올림해도 괜찮을 것 같습미당