chore(deps): update all non-major dependencies #9784
Conversation
|
github-actions
bot
added
package: react-query-devtools
package: react-query
package: react-query-persist-client
package: vue-query
package: query-core
package: solid-query
package: query-persist-client-core
package: eslint-plugin-query
package: svelte-query
package: svelte-query-devtools
package: query-devtools
package: angular-query-experimental
package: query-async-storage-persister
package: query-sync-storage-persister
package: solid-query-persist-client
package: svelte-query-persist-client
package: vue-query-devtools
package: solid-query-devtools
package: query-broadcast-client-experimental
package: react-query-next-experimental
package: angular-query-persist-client
package: query-test-utils
labels
WalkthroughRepository-wide dependency and devDependency version bumps across examples, integrations, packages, and the root Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Potential attention points:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 3m 43s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
✅ Succeeded | 1m 29s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-13 07:53:35 UTC
|
Sizes for commit 9c4e99e:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/query-broadcast-client-experimental/package.jsonintegrations/solid-vite/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/solid-query-persist-client/package.jsonintegrations/react-vite/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonpackages/react-query-persist-client/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/react-query-devtools/package.jsonpackages/query-persist-client-core/package.jsonpackages/svelte-query-devtools/package.jsonpackages/react-query-next-experimental/package.jsonpackages/svelte-query/package.jsonpackages/angular-query-experimental/package.jsonintegrations/react-next-15/package.jsonpackages/react-query/package.jsonpackages/query-async-storage-persister/package.jsonpackages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (81)
packages/react-query-next-experimental/package.json (1)
61-61: Dependency updates look good.Minor version bumps for
@vitejs/plugin-react(4.3.4 → 4.7.0) and patch bump fornpm-run-all2(5.0.0 → 5.0.2) are standard, backward-compatible updates aligned with the PR's non-major dependency upgrade objective.Also applies to: 63-63
examples/vue/2.7-basic/package.json (1)
11-11: Patch version bump approved.The update to
@tanstack/vue-query(5.90.2 → 5.90.5) is a safe patch-level increment.packages/query-core/package.json (1)
63-63: Patch version bump approved.The update to
npm-run-all2(5.0.0 → 5.0.2) is a safe patch-level increment to a build-time tool.packages/vue-query/package.json (2)
66-66: Clarify the @vue/devtools-api change.Line 66 is marked as modified, but the summary does not specify the version change for
@vue/devtools-api. Confirm whether this is a version bump and, if so, verify compatibility with the Vue ecosystem versions in use.
73-73: Patch version bump approved.The update to
eslint-plugin-vue(10.5.0 → 10.5.1) is a safe patch-level increment.integrations/vue-vite/package.json (1)
13-13: Minor version bumps are generally safe; verify Vite tooling compatibility.Updates to
@vitejs/plugin-vue(5.2.1 → 5.2.4) andvite(6.3.6 → 6.4.0) are within major versions and should be backward compatible. However, ensure the minor version bump of Vite aligns with the plugin's expectations.Also applies to: 15-15
packages/query-persist-client-core/package.json (1)
66-66: Patch version bump approved.The update to
npm-run-all2(5.0.0 → 5.0.2) is a safe patch-level increment to a build-time tool.packages/query-async-storage-persister/package.json (1)
67-67: Patch version bump approved.The update to
npm-run-all2(5.0.0 → 5.0.2) is a safe patch-level increment to a build-time tool.packages/react-query-devtools/package.json (1)
86-86: Dependency updates look good.Minor version bumps for
@testing-library/react(16.1.0 → 16.3.0) and@vitejs/plugin-react(4.3.4 → 4.7.0), along with patch bump fornpm-run-all2(5.0.0 → 5.0.2), are all backward-compatible updates to development tooling aligned with the PR's non-major dependency upgrade objective.Also applies to: 88-88, 89-89
examples/vue/basic/package.json (1)
16-16: Dependency updates look appropriate.Minor/patch updates to Vite and its Vue plugin are well within the caret ranges and should be compatible.
Also applies to: 18-18
examples/vue/dependent-queries/package.json (1)
15-15: Consistent devDependency updates across Vue examples.Same Vite and plugin updates as other Vue examples—straightforward minor/patch bumps.
Also applies to: 17-17
integrations/svelte-vite/package.json (1)
12-13: Straightforward minor updates to Svelte and Vite.Both updates are patch/minor within the specified ranges and align with the broader dependency refresh across the project.
examples/vue/nuxt3/package.json (1)
10-10: Dependency updates are within safe ranges.The patch bump to @tanstack/vue-query and minor bump to Nuxt 3.19.3 are both within the specified caret ranges and should maintain compatibility.
Also applies to: 13-13
examples/svelte/basic/package.json (1)
17-18: Svelte ecosystem updates are compatible.Multiple minor/patch bumps to Svelte, SvelteKit, and Vite are all within their specified ranges. The update to SvelteKit 2.47.2 (from 2.42.2) represents multiple minor versions but stays within the ^2 constraint, maintaining compatibility.
Also applies to: 20-21, 23-23
packages/query-test-utils/package.json (1)
38-38: Safe patch update to npm-run-all2.Patch bump from 5.0.0 to 5.0.2 is low-risk for this internal test utility package.
examples/vue/2.6-basic/package.json (1)
11-11: Patch update to @tanstack/vue-query is safe.The bump from 5.90.2 to 5.90.5 is a standard patch release and maintains compatibility with the Vue 2.6 legacy example.
integrations/react-next-15/package.json (1)
9-9: Breaking changes in @js-temporal/polyfill 0.5.1 require verification against example code.Substantive breaking changes exist between 0.4.4 and 0.5.1, including parsing/validation changes where plain date-only strings behavior has changed. The React 19 example directly uses this pattern: Temporal.PlainDate.from('2024-01-01') and Temporal.PlainDate.from('2023-01-01') in page.tsx and client-component.tsx.
Verify that these calls still work with 0.5.1 or update the code accordingly. If you're unsure whether the parsing changes affect PlainDate specifically, test the example locally or consult the full v0.4.0→v0.5.0 migration notes.
examples/vue/simple/package.json (1)
15-19: LGTM!Standard maintenance updates for Vue tooling. Patch and minor updates are low-risk and align with the broader PR dependency refresh.
packages/vue-query-devtools/package.json (1)
55-63: LGTM!Patch and minor updates for Vue devtools dependencies are low-risk and correctly categorized in devDependencies.
examples/svelte/load-more-infinite-scroll/package.json (1)
14-22: LGTM!Svelte ecosystem updates (adapter, kit, svelte, svelte-check, vite) are all patch/minor updates, correctly placed in devDependencies. These align with the broader PR dependency refresh and pose minimal risk.
packages/solid-query-devtools/package.json (1)
68-75: LGTM!Patch updates for Solid ecosystem dependencies (npm-run-all2, solid-js, vite-plugin-solid) are low-risk and correctly placed in devDependencies. Versions are consistent with solid-query package updates.
examples/angular/basic-persister/package.json (1)
11-28: LGTM!Angular package updates from 20.0.0 to 20.3.6 are consistent across all @angular packages, with zone.js patched to 0.15.1 in alignment. These are safe minor-version updates within the 20.x series. Correctly categorized between dependencies and devDependencies.
packages/solid-query/package.json (1)
71-78: LGTM!Patch updates for Solid ecosystem dependencies are low-risk and correctly placed. Versions align with solid-query-devtools and other Solid packages in this PR.
examples/solid/solid-start-streaming/package.json (1)
14-14: Solid framework and tooling updates look good.Minor and patch version bumps for Solid.js ecosystem dependencies are compatible. Caret-ranged constraints allow flexibility as expected.
Also applies to: 17-18
examples/react/algolia/package.json (2)
11-11: Verify Algolia version specifier is intentional.The @algolia/client-search version was updated from 5.2.1 to 5.40.1 (exact specifier). This is a significant jump within the 5.x range. Confirm:
- Whether the exact version specification (no caret) is intentional and aligns with the package's lock file strategy
- Whether release notes for 5.2→5.40 contain any relevant breaking changes or migration notes
21-21: Vite and React tooling updates approved.Minor and patch bumps for @vitejs/plugin-react and vite are compatible and consistent with other React examples in the PR.
Also applies to: 23-23
examples/solid/astro/package.json (1)
15-15: Solid and Astro ecosystem updates approved.All dependency updates are minor/patch versions with appropriate caret constraints. No compatibility concerns anticipated.
Also applies to: 17-17, 21-22
examples/react/basic-graphql-request/package.json (1)
13-14: GraphQL and Vite tooling updates approved.All dependency updates are minor/patch versions. GraphQL, graphql-request, and Vite tools are all compatible with their caret constraints.
Also applies to: 19-20
packages/query-broadcast-client-experimental/package.json (1)
62-62: Dependency updates for published package approved with verification.All updates are minor/patch versions. Since
@tanstack/query-broadcast-client-experimentalis a published package, ensure the test suite passes with the updatedbroadcast-channeland@testing-library/reactversions to confirm compatibility.Also applies to: 65-67
examples/angular/optimistic-updates/package.json (1)
12-16: Angular framework and zone.js updates approved.All Angular packages updated to ^20.3.6 (within same major version) and zone.js patched to 0.15.1. These are standard maintenance updates with no breaking changes anticipated. Consistent with other Angular examples in the PR.
Also applies to: 20-20, 23-25
examples/solid/basic/package.json (1)
13-13: Solid and Vite tooling patch updates approved.All dependency updates are patch versions with caret constraints. No compatibility concerns.
Also applies to: 17-18
examples/svelte/ssr/package.json (1)
15-16: Svelte and SvelteKit ecosystem updates approved.All devDependency updates are minor/patch versions. @sveltejs/kit sees a moderate jump from 2.42.2 → 2.47.2 and svelte from 5.39.3 → 5.41.0, both within semver compatibility. Caret constraints provide appropriate flexibility. Recommend verifying the test suite runs successfully with these intermediate versions.
Also applies to: 18-19, 21-21
integrations/react-webpack-5/package.json (1)
14-18: Babel and webpack tooling updates look good.The updates to @babel/core, @babel/preset-env, @babel/preset-react, and html-webpack-plugin are all minor/patch version bumps within the same major versions. The caret ranges (^) allow compatible updates automatically, and babel-preset-react intentionally lags behind core/preset-env slightly, which is a normal pattern in Babel versioning.
packages/react-query-persist-client/package.json (1)
67-70: Testing library and build tool updates are safe.All three devDependency updates (@testing-library/react, @vitejs/plugin-react, npm-run-all2) are minor or patch version bumps. No breaking changes are anticipated in these ranges.
integrations/react-webpack-4/package.json (1)
14-17: Babel and babel-loader updates are compatible.The Babel package updates mirror those in react-webpack-5, and babel-loader 8.4.1 is fully compatible with @babel/core 7.28.4. This is a safe update for Webpack 4 projects.
examples/solid/default-query-function/package.json (1)
13-13: Solid example dependencies updated safely.All three dependency updates (solid-js, vite, vite-plugin-solid) are minor or patch bumps within the same major versions. Vite 6.4.0 is compatible with vite-plugin-solid 2.11.9.
Also applies to: 17-18
examples/solid/simple/package.json (1)
13-13: Solid example updates are consistent across the monorepo.The dependency updates in this file match the pattern seen in examples/solid/default-query-function/package.json, ensuring consistency across Solid examples.
Also applies to: 18-19
packages/svelte-query/package.json (1)
55-55: Svelte ecosystem packages updated consistently.All devDependency updates are minor or patch version bumps within the Svelte 5 ecosystem. @typescript-eslint/parser, eslint-plugin-svelte, svelte, and svelte-check are all being updated in alignment across related Svelte packages in this PR.
Also applies to: 59-62
examples/svelte/playground/package.json (1)
15-16: Svelte example tooling and framework updates are safe.All updates (@sveltejs/adapter-auto, @sveltejs/kit, svelte, svelte-check, vite) are minor or patch bumps. The SvelteKit minor bump (2.42.2 → 2.47.2) is a standard maintenance update within the same major version.
Also applies to: 18-19, 21-21
examples/solid/basic-graphql-request/package.json (1)
13-15: GraphQL and Solid example dependencies updated consistently.The graphql (16.9.0 → 16.11.0) and graphql-request (7.1.2 → 7.3.1) updates are minor/patch bumps. Solid and Vite updates align with the broader updates seen across other Solid examples in this PR.
Also applies to: 19-20
examples/svelte/optimistic-updates/package.json (1)
15-21: Dependency updates look good; recommend running tests to verify compatibility.All updates are non-breaking patch or minor versions within the caret ranges. However, since Vite and SvelteKit are relatively high-velocity projects, recommend running the example's
devandbuildscripts to confirm no subtle breaking changes.examples/svelte/auto-refetching/package.json (1)
15-21: Consistent Svelte tooling updates across examples.These updates match the concurrent updates in the other Svelte example packages and follow the same non-breaking patch/minor pattern.
examples/angular/simple/package.json (1)
12-24: Angular patch-level updates are consistent and appropriate.Updates to Angular 20.3.6 are all patch-level changes within the major version and are consistent across all Angular examples. Note:
zone.jsis correctly pinned to0.15.1(not using^), which is the correct approach for zone.js due to its strict versioning requirements.examples/svelte/star-wars/package.json (1)
15-23: Verify Tailwind updates—prior versions not shown in diff.The
@tailwindcss/viteandtailwindcssupdates to^4.1.14lack visible prior versions in the provided diff context. If this is a major version upgrade (e.g., v3→v4), confirm there are no breaking changes or required configuration updates for the example.examples/angular/pagination/package.json (1)
12-24: Angular updates are consistent with other Angular examples.Identical patch-level updates to Angular 20.3.6 and zone.js 0.15.1 as seen in other Angular example packages.
examples/angular/devtools-panel/package.json (1)
12-25: Angular updates are consistent, including @angular/router.Patch-level updates matching other Angular examples. The inclusion of
@angular/routeris expected for this example's routing needs.packages/eslint-plugin-query/package.json (1)
62-69: ESLint and TypeScript-ESLint updates are minor-level and appropriately coordinated.All
@typescript-eslint/*packages are updated together to^8.46.1, which maintains consistency. Theeslintandnpm-run-all2updates are also minor/patch level and should not introduce breaking changes. Consider runningnpm run test:libandnpm run test:eslintto verify no regressions.examples/angular/infinite-query-with-max-pages/package.json (1)
12-24: Angular updates are consistent with other Angular examples.Identical patch-level updates to Angular 20.3.6 and zone.js 0.15.1.
examples/angular/auto-refetching/package.json (1)
12-24: Version bumps are consistent and low-risk.Angular packages aligned to ^20.3.6 and zone.js pinned to 0.15.1 are all compatible patch/minor updates within the same major version range. All related framework packages and tooling are updated in tandem.
examples/svelte/simple/package.json (1)
16-20: Svelte and Vite tooling updates are appropriate.Minor/patch updates to Svelte (5.39.3 → 5.41.0), build tooling (@tsconfig/svelte, svelte-check), and Vite (6.3.6 → 6.4.0) are standard maintenance updates within semver compatibility ranges.
packages/query-devtools/package.json (1)
67-80: Solid.js ecosystem updates are cohesive.Patch and minor updates to Solid.js libraries (solid-js 1.9.7 → 1.9.9, vite-plugin-solid 2.11.6 → 2.11.9) and other devDependencies are consistent and low-risk. Workspace dependencies remain intact.
examples/angular/query-options-from-a-service/package.json (1)
12-25: Angular and zone.js updates are consistent across the codebase.Angular framework and tooling packages bumped to ^20.3.6, zone.js pinned to 0.15.1, matching patterns in other Angular examples. All updates are patch/minor and fully compatible.
packages/svelte-query-devtools/package.json (1)
50-59: Svelte and TypeScript tooling updates are aligned.@sveltejs/package bumped from 2.4.0 to 2.5.4 (minor range), TypeScript ESLint updated (patches), and Svelte ecosystem aligned with other packages. All updates remain within semver compatibility. Workspace dependencies preserved.
examples/angular/rxjs/package.json (1)
12-25: Angular framework and tooling updates are consistent.Angular packages and tooling aligned to ^20.3.6, zone.js pinned to 0.15.1 - consistent with other Angular examples in this PR. All updates are patch/minor and compatible.
packages/react-query/package.json (1)
73-79: React testing library and build tool updates are reasonable.@testing-library/react (16.1.0 → 16.3.0), @vitejs/plugin-react (4.3.4 → 4.7.0), and npm-run-all2 (5.0.0 → 5.0.2) are all minor/patch updates within semver ranges. Workspace dependencies preserved.
Verify that
@testing-library/react-render-streamat version ^2.0.1 (line 74) is the correct package and version. This appears to be a less common package and should be confirmed as intentional.examples/vue/persister/package.json (1)
15-21: Vue build tooling updates are standard maintenance.idb-keyval (6.2.1 → 6.2.2), @vitejs/plugin-vue (5.2.1 → 5.2.4), and Vite (6.3.6 → 6.4.0) are patch/minor updates within compatible ranges. Low-risk dependency maintenance.
packages/angular-query-experimental/package.json (1)
92-102: Angular packages and tooling updated to stable minor/patch versions.Angular 20.3.6 is the latest patch release for v20, and all related tooling updates are within compatible semver ranges. No issues identified.
packages/query-sync-storage-persister/package.json (1)
67-67: Routine patch update to npm-run-all2.Patch-level bump with no functional impact.
packages/solid-query-persist-client/package.json (1)
73-76: Solid.js ecosystem patches applied consistently.All updates are patch-level increments within compatible semver ranges, coordinated across related Solid packages in this PR.
package.json (2)
8-8: pnpm 10.18.3 is a stable recent patch with bug fixes.pnpm 10.18.3 fixes a bug where pnpm would infinitely recurse when using verifyDepsBeforeInstall with pre/post install scripts. This is a safe upgrade within the v10 series.
43-80: Vite 6.4.0 update is secure and safe to merge.The v6.4.0 release does not list new security advisories, and the relevant security advisory (CVE-2025-58752) was fixed in v6.3.6. Since v6.4.0 is released after v6.3.6, it includes those prior security patches. The update maintains compatibility and poses no security risk.
packages/svelte-query-persist-client/package.json (1)
55-63: Svelte ecosystem updates applied consistently.All updates are minor/patch increments within compatible semver ranges, coordinated across related Svelte packages in this PR.
examples/react/eslint-legacy/package.json (1)
23-23: React tooling updates are compatible patch/minor versions.Vite 6.4.0 is a patch within the v6 series, and @vitejs/plugin-react minor update is backward compatible.
Also applies to: 25-25
examples/react/shadow-dom/package.json (1)
19-19: React tooling updates are compatible patch/minor versions.Vite 6.4.0 is a patch within the v6 series, and @vitejs/plugin-react minor update is backward compatible.
Also applies to: 21-21
examples/react/basic/package.json (1)
23-23: React tooling updates are compatible patch/minor versions.Vite 6.4.0 is a patch within the v6 series, and @vitejs/plugin-react minor update is backward compatible.
Also applies to: 25-25
examples/react/default-query-function/package.json (1)
17-17: DevDependency updates are safe and consistent with broader React example updates in this PR.These are routine minor/patch bumps within the existing version constraints. Vite 6 strives to avoid breaking changes and remains backward compatible, and the @vitejs/plugin-react update is a standard minor version step.
Also applies to: 19-19
examples/react/simple/package.json (1)
17-17: Identical to examples/react/default-query-function/package.json — already reviewed above.Also applies to: 19-19
examples/react/devtools-panel/package.json (1)
17-17: Identical to examples/react/default-query-function/package.json — already reviewed above.Also applies to: 19-19
examples/react/suspense/package.json (1)
19-19: Identical to examples/react/default-query-function/package.json — already reviewed above.Also applies to: 21-21
examples/react/chat/package.json (1)
17-21: DevDependency updates are routine maintenance within consistent version ranges.Tailwind CSS and @tailwindcss/vite patch updates to v4.1.14 are safe incremental improvements, and the core vite/plugin-react updates align with other React examples in this PR. All changes remain within their respective major version constraints.
examples/react/playground/package.json (1)
17-17: Identical to examples/react/default-query-function/package.json — already reviewed above.Also applies to: 19-19
packages/angular-query-persist-client/package.json (1)
60-70: Angular and testing library updates are properly coordinated and safe.The five Angular packages are consistently updated from ^20.0.0 to ^20.3.6 (a minor version bump), which is well-supported by the peerDependencies (>=16.0.0). Testing library and linting tool updates are routine patch/minor bumps. The workspace dependency for @tanstack/query-persist-client-core correctly remains "workspace:*".
examples/react/react-router/package.json (2)
17-20: Runtime dependency updates are within safe version ranges, though react-router version jump warrants a quick compatibility check.
- Lines 17-18: react-router and react-router-dom are consistently updated to ^6.30.1 from ^6.25.1. While this spans five patch versions, it remains within the same minor version (6.x), so breaking changes are not expected. Both packages are updated together, which is the correct approach.
- Line 19: rooks updates from 8.0.0 to 8.4.0, a routine minor version bump within v8.
Run your existing example test suite or manual checks to confirm react-router v6.30.1 works as expected with your router configuration and hooks usage, especially if you rely on any undocumented behavior from v6.25.
26-28: DevDependency updates match other React examples — already reviewed above.examples/angular/basic/package.json (1)
12-19: Angular and zone.js updates look good.Minor/patch version bumps within the Angular 20.x family and zone.js are low-risk and backward compatible. These align with similar updates across other Angular examples in the PR.
Also applies to: 22-24
examples/react/rick-morty/package.json (1)
15-16: React Router and build tooling updates are safe.All dependency bumps are minor/patch versions within their existing constraints. React Router's jump from 6.25.1 to 6.30.1 is a standard minor-version increment with no breaking changes expected.
Also applies to: 19-23
examples/react/react-native/package.json (1)
19-29: Request verification for significant React Native ecosystem bump.The React Native version bump from ^0.76.3 to ^0.82.0 spans five minor versions—this is substantially larger than typical patch/minor updates elsewhere in the PR. React Native historically introduces breaking changes across minor versions, particularly in native module APIs and integration points.
Recommend verifying:
- React Native 0.82.0 release notes for breaking changes
- Compatibility between react-native 0.82.0 and its paired ecosystem packages (gesture-handler 2.28.0, paper 5.14.5, reanimated 3.19.3, safe-area-context 4.14.1, screens 4.17.1, web 0.21.2)
- CI test results to ensure no runtime failures
Also applies to: 32-33
integrations/angular-cli-20/package.json (1)
11-20: Angular and utility library updates are consistent.Angular framework and tooling updates align with other Angular examples in the PR. The tslib bump (2.3.0 → 2.8.1) is a larger minor-version jump but tslib is a stable utility library with strong backward compatibility. All changes remain within established version constraints.
Also applies to: 23-25
examples/react/offline/package.json (1)
16-16: Build and runtime dependency updates are standard.MSW, react-hot-toast, Vite, and Vite React plugin all receive minor/patch updates within established ranges. No compatibility issues expected.
Also applies to: 19-19, 22-22, 24-24
examples/angular/router/package.json (1)
12-16: Angular updates follow consistent pattern.Angular core and tooling bumps (^20.0.0 → ^20.3.6) and zone.js patch (0.15.0 → 0.15.1) align with other Angular examples. Changes are safe and backward compatible.
Minor note: zone.js is pinned with exact version (0.15.1) here and in basic/package.json, but integrations/angular-cli-20/package.json uses a tilde constraint (~0.15.1). This inconsistency is harmless but consider aligning zone.js versioning strategy across the repo if not intentional.
Also applies to: 20-20, 23-25
examples/react/star-wars/package.json (1)
15-16: React tooling and routing updates are standard.Consistent with examples/react/rick-morty/package.json. React Router, Vite, and related dev tooling receive safe minor/patch bumps with no breaking changes expected.
Also applies to: 19-23
| "dependencies": { | ||
| "@tanstack/solid-query": "workspace:*", | ||
| "@tanstack/solid-query-devtools": "workspace:*", | ||
| "solid-js": "^1.9.7", | ||
| "vite": "^6.3.6", | ||
| "vite-plugin-solid": "^2.11.6" | ||
| "solid-js": "^1.9.9", | ||
| "vite": "^6.4.0", | ||
| "vite-plugin-solid": "^2.11.9" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
Critical: Vite build tools should be in devDependencies, not dependencies.
Vite and vite-plugin-solid are development-time build tools and should not be in the production dependencies section. Additionally, solid-js placement should be clarified—if this is a build integration package, it may also belong in devDependencies or as a peerDependency rather than a production dependency.
Can you confirm whether this is the intended structure for this integration package, or should Vite-related tools and possibly solid-js be moved to devDependencies or peerDependencies?
I'll verify the structure of this integration package by examining its dependencies across the repository.
🏁 Script executed:
#!/bin/bash
# Find all integration package.json files and extract their dependencies structure
echo "=== Checking integrations package.json files ==="
fd 'package\.json' 'integrations' --exec sh -c 'echo "File: $1"; grep -A 20 '"'"'"dependencies"'"'"' "$1" | head -15' _ {} \;Length of output: 3092
🏁 Script executed:
#!/bin/bash
# Specifically check the solid-vite and react-vite packages mentioned in review
echo "=== integrations/solid-vite/package.json ==="
cat integrations/solid-vite/package.json 2>/dev/null || echo "Not found"
echo -e "\n=== integrations/react-vite/package.json ==="
cat integrations/react-vite/package.json 2>/dev/null || echo "Not found"
echo -e "\n=== Root package.json (workspace info) ==="
cat package.json | head -50Length of output: 3118
🏁 Script executed:
#!/bin/bash
# Check for any documentation about package structure
echo "=== Looking for workspace or integration documentation ==="
find . -maxdepth 2 -name "README*" -o -name "CONTRIBUTING*" | head -10 | xargs grep -l "integration\|devDependencies" 2>/dev/null || echo "No docs found"Length of output: 72
Move vite and vite-plugin-solid to devDependencies.
Vite and vite-plugin-solid are build-time tools and should not be in the production dependencies section. The vue-vite integration package in this repository correctly places vite and its plugin in devDependencies, establishing the standard pattern for integration packages. The solid-js framework dependency can remain in dependencies as it serves the runtime example, but the build tools must be moved.
Note: The same issue affects integrations/react-vite/package.json, which also incorrectly places vite and @vitejs/plugin-react in dependencies.
🤖 Prompt for AI Agents
In integrations/solid-vite/package.json around lines 8 to 14, move the build
tools "vite" and "vite-plugin-solid" out of "dependencies" into
"devDependencies" so they are only installed for development/build time; keep
"solid-js" in "dependencies" as the runtime example. Update the JSON by removing
those two entries from "dependencies" and adding them under a "devDependencies"
object (creating it if missing) with the same versions. Also apply the same
change to integrations/react-vite/package.json for "vite" and
"@vitejs/plugin-react".
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
9396470 to
044f4fa
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (5)
examples/svelte/auto-refetching/package.json (1)
15-19: @sveltejs/adapter-auto 6.1.1 does not exist on npm—update to 6.0.1.The latest version of @sveltejs/adapter-auto is 6.0.1, and version 6.1.1 is not published. This will cause npm install to fail. Update to the correct version.
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^6.0.1",This same correction should be applied to all other Svelte example package.json files in this PR (examples/svelte/star-wars, examples/svelte/basic, examples/svelte/optimistic-updates, etc.).
examples/svelte/star-wars/package.json (1)
15-15: @sveltejs/adapter-auto 6.1.1 does not exist on npm—update to 6.0.1.The latest version of @sveltejs/adapter-auto is 6.0.1, and version 6.1.1 is not published. This will cause npm install to fail.
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^6.0.1",Also applies to: 18-22
examples/svelte/basic/package.json (1)
17-17: @sveltejs/adapter-auto 6.1.1 does not exist on npm—update to 6.0.1.The latest version of @sveltejs/adapter-auto is 6.0.1.
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^6.0.1",examples/svelte/optimistic-updates/package.json (1)
15-15: @sveltejs/adapter-auto 6.1.1 does not exist on npm—update to 6.0.1.Latest version: 6.0.1.
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^6.0.1",examples/angular/basic-persister/package.json (1)
21-21: zone.js 0.15.1 may be incompatible with Angular 20.3.10—consider reverting to 0.14.x.Angular's peer dependencies typically require zone.js ~0.14.x. Verify compatibility or revert to zone.js ^0.14.2.
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- integrations/svelte-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (55)
- examples/react/suspense/package.json
- packages/react-query-persist-client/package.json
- examples/react/devtools-panel/package.json
- examples/react/simple/package.json
- examples/react/basic/package.json
- packages/vue-query-devtools/package.json
- packages/svelte-query-devtools/package.json
- examples/react/offline/package.json
- packages/query-sync-storage-persister/package.json
- packages/solid-query/package.json
- examples/react/default-query-function/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- integrations/vue-vite/package.json
- integrations/react-next-15/package.json
- integrations/solid-vite/package.json
- examples/svelte/playground/package.json
- examples/angular/basic/package.json
- examples/react/algolia/package.json
- integrations/react-webpack-4/package.json
- packages/query-core/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/simple/package.json
- examples/angular/router/package.json
- packages/react-query-next-experimental/package.json
- packages/svelte-query/package.json
- packages/query-async-storage-persister/package.json
- integrations/react-webpack-5/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/devtools-panel/package.json
- examples/svelte/simple/package.json
- packages/query-test-utils/package.json
- examples/vue/2.7-basic/package.json
- packages/angular-query-persist-client/package.json
- packages/eslint-plugin-query/package.json
- integrations/react-vite/package.json
- examples/react/react-native/package.json
- examples/vue/2.6-basic/package.json
- examples/angular/pagination/package.json
- packages/vue-query/package.json
- examples/react/react-router/package.json
- packages/query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/angular-cli-20/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/rxjs/package.json
- examples/react/chat/package.json
- examples/solid/basic/package.json
- examples/svelte/ssr/package.json
- examples/vue/persister/package.json
- examples/solid/solid-start-streaming/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/basic-graphql-request/package.jsonexamples/angular/basic-persister/package.jsonexamples/vue/nuxt3/package.jsonexamples/solid/astro/package.jsonexamples/svelte/basic/package.jsonpackages/react-query-devtools/package.jsonexamples/react/eslint-legacy/package.jsonpackages/solid-query-devtools/package.jsonpackages/solid-query-persist-client/package.jsonexamples/svelte/star-wars/package.jsonpackages/query-persist-client-core/package.jsonexamples/svelte/auto-refetching/package.jsonpackages/angular-query-experimental/package.jsonpackages/react-query/package.jsonexamples/svelte/optimistic-updates/package.jsonpackage.jsonexamples/solid/simple/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
examples/solid/astro/package.jsonpackages/react-query-devtools/package.jsonpackages/solid-query-devtools/package.jsonpackages/solid-query-persist-client/package.jsonexamples/solid/simple/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (18)
examples/vue/nuxt3/package.json (1)
10-10: Routine patch bump for @tanstack/vue-query.The ^5.90.7 update is a safe patch-level bump.
examples/solid/simple/package.json (1)
13-13: Routine patch updates for Solid ecosystem.Patch-level updates to solid-js and vite-plugin-solid are safe and low-risk.
Also applies to: 19-19
examples/vue/basic/package.json (1)
16-16: Routine patch update for @vitejs/plugin-vue.The ^5.2.4 update is a safe patch-level bump.
examples/react/basic-graphql-request/package.json (1)
13-14: Routine patch/minor updates for GraphQL and Vite tooling.All updates are safe within semver constraints: graphql (^16.12.0), graphql-request (^7.3.1), and @vitejs/plugin-react (^4.7.0).
Also applies to: 19-19
packages/react-query/package.json (1)
73-74: Routine patch updates for testing and build tooling.All updates are safe patch-level bumps: @testing-library packages, @vitejs/plugin-react, and npm-run-all2.
Also applies to: 77-77, 79-79
packages/react-query-devtools/package.json (1)
86-86: Routine patch updates for testing and build tooling.Safe patch-level bumps to @testing-library/react, @vitejs/plugin-react, and npm-run-all2.
Also applies to: 88-88, 89-89
packages/solid-query-devtools/package.json (1)
71-72: Routine patch updates for Solid ecosystem and build tooling.Safe patch-level bumps to npm-run-all2, solid-js, and vite-plugin-solid.
Also applies to: 74-74
packages/solid-query-persist-client/package.json (1)
73-74: Routine patch updates for Solid ecosystem and build tooling.Safe patch-level bumps to npm-run-all2, solid-js, and vite-plugin-solid.
Also applies to: 76-76
examples/solid/astro/package.json (1)
13-23: Astro and Solid.js ecosystem updates look good.All version bumps are within the caret operator constraints and follow non-major semver, which aligns with the PR objectives.
packages/angular-query-experimental/package.json (1)
92-102: Angular and build tooling updates look good.All version bumps are within the constraints and represent non-major updates aligned with the PR objectives.
examples/angular/infinite-query-with-max-pages/package.json (1)
19-19: zone.js 0.15.1 is the correct version for Angular 20—disregard this review comment.Angular 20 expects zone.js ~0.15.0 as a peer dependency, making the current version of 0.15.1 fully compatible and appropriate. The original suggestion to revert to 0.14.x is incorrect. zone.js 0.15.1 would cause peer-dependency conflicts with Angular 18 and earlier, not Angular 20.
Likely an incorrect or invalid review comment.
package.json (1)
8-8: Dependency updates look good; pnpm configuration consistent.The pnpm version bump (10.17.0 → 10.20.0) and devDependency updates (eslint, nx, sherif, etc.) are all non-major, patch/minor-level updates. The
pnpm.overridessection withworkspace:*references for all@tanstackpackages is already properly configured, which ensures consistent dependency resolution across the monorepo.Also applies to: 43-81
packages/query-persist-client-core/package.json (1)
66-66: Patch-level npm-run-all2 bump is routine and safe.examples/react/rick-morty/package.json (1)
15-16: Example dependency updates are routine and consistent.The react-router bump (+2.0.0 within ^6.x range) and Tailwind/Vite plugin updates are all non-major and align with similar updates across other React examples in this PR.
Also applies to: 19-21
examples/react/shadow-dom/package.json (1)
19-19: Minor Vite plugin bump is consistent across React examples.examples/react/playground/package.json (1)
17-17: Minor Vite plugin bump is consistent across React examples.examples/react/eslint-legacy/package.json (1)
23-23: Minor Vite plugin bump is consistent across React examples.examples/react/star-wars/package.json (1)
15-16: Example dependency updates are routine and consistent.The react-router bump and Tailwind/Vite plugin updates match the pattern in other React examples and are all non-major, safe updates.
Also applies to: 19-21
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
2 times, most recently
from
375a0c9 to
b2c6bef
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
examples/vue/nuxt3/package.json (1)
13-13: I'll verify the Nuxt version claim with a web search.Nuxt ^3.20.1 does not exist; update to latest valid Nuxt 3 version.
Nuxt v3.19.3 is the latest available Nuxt 3 release, and Nuxt 3 will continue to receive maintenance updates until end of January 2026. The constraint
^3.20.1will causenpm installto fail since this version was never released. Update to^3.19.0to use the latest Nuxt 3 maintenance release.- "nuxt": "^3.20.1" + "nuxt": "^3.19.0"integrations/solid-vite/package.json (1)
8-14: Move build tools to devDependencies for consistency with other integration packages.The review comment is correct. Build tools (
viteandvite-plugin-solid) should be indevDependencies, notdependencies. This is confirmed by the fact thatsvelte-viteandvue-vitealready follow this pattern correctly in the same repository.solid-jscorrectly remains independenciesas the runtime framework.Apply this fix:
"dependencies": { "@tanstack/solid-query": "workspace:*", "@tanstack/solid-query-devtools": "workspace:*", + "solid-js": "^1.9.10" + }, + "devDependencies": { "vite": "^6.3.6", - "vite-plugin-solid": "^2.11.10" + "vite-plugin-solid": "^2.11.10" - } + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (63)
- packages/react-query-persist-client/package.json
- packages/react-query-devtools/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/basic/package.json
- integrations/react-next-15/package.json
- examples/react/offline/package.json
- packages/react-query/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/default-query-function/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/suspense/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-next-experimental/package.json
- packages/solid-query/package.json
- examples/react/algolia/package.json
- examples/solid/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/playground/package.json
- examples/angular/rxjs/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/router/package.json
- integrations/vue-vite/package.json
- examples/react/react-router/package.json
- examples/react/simple/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/basic/package.json
- examples/react/basic-graphql-request/package.json
- packages/query-devtools/package.json
- examples/react/devtools-panel/package.json
- examples/vue/simple/package.json
- integrations/react-vite/package.json
- examples/react/react-native/package.json
- examples/vue/2.7-basic/package.json
- packages/query-test-utils/package.json
- examples/svelte/star-wars/package.json
- integrations/svelte-vite/package.json
- examples/react/eslint-legacy/package.json
- packages/angular-query-persist-client/package.json
- packages/vue-query-devtools/package.json
- examples/solid/astro/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/basic/package.json
- examples/react/basic/package.json
- packages/query-persist-client-core/package.json
- packages/eslint-plugin-query/package.json
- examples/solid/basic/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/simple/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/simple/package.json
- examples/angular/pagination/package.json
- integrations/react-webpack-5/package.json
- examples/angular/basic-persister/package.json
- examples/vue/persister/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/ssr/package.json
- integrations/angular-cli-20/package.json
- packages/vue-query/package.json
- packages/svelte-query-persist-client/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/optimistic-updates/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonintegrations/solid-vite/package.jsonexamples/vue/nuxt3/package.jsonpackages/query-async-storage-persister/package.jsonpackages/solid-query-devtools/package.jsonexamples/svelte/auto-refetching/package.jsonexamples/vue/2.6-basic/package.jsonpackages/solid-query-persist-client/package.jsonexamples/svelte/playground/package.jsonpackage.jsonpackages/svelte-query/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
integrations/solid-vite/package.jsonpackages/solid-query-devtools/package.jsonpackages/solid-query-persist-client/package.jsonpackages/svelte-query/package.json
🔇 Additional comments (17)
packages/query-core/package.json (1)
63-63: LGTM—routine patch bump.Patch version update for npm-run-all2 is safe and routine with no behavioral changes expected.
packages/svelte-query/package.json (1)
55-62: LGTM—safe minor/patch updates.All devDependency updates are within the same major version and represent routine patch or minor improvements. Svelte tooling versions are aligned consistently across the project.
examples/vue/2.6-basic/package.json (1)
11-11: LGTM—routine patch bump.Aligns @tanstack/vue-query version with other Vue examples in the PR.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM—routine patch bump.npm-run-all2 patch update is safe and consistent with other package updates in this PR.
examples/react/default-query-function/package.json (1)
17-17: LGTM—safe minor version bump.@vitejs/plugin-react minor update aligns with similar bumps across React examples.
examples/svelte/playground/package.json (1)
16-19: LGTM—routine minor/patch bumps.@sveltejs/kit, svelte, and svelte-check updates are safe minor/patch version bumps.
packages/solid-query-devtools/package.json (1)
71-74: Solid ecosystem devDependency patches approved.Routine patch updates across solid-js and related tooling; no compatibility concerns expected.
packages/solid-query-persist-client/package.json (1)
73-76: Aligned Solid ecosystem devDependency patches.Updates mirror those in related solid packages; all are safe patch-level bumps.
examples/react/chat/package.json (1)
17-19: React/Tailwind devDependency minors approved.Minor version updates to Tailwind and Vite plugins are safe, non-breaking changes.
examples/vue/dependent-queries/package.json (1)
15-15: Vue Vite plugin patch approved.Routine patch-level update; no compatibility concerns.
package.json (3)
8-8: pnpm patch update approved.Update from 10.17.0 to 10.20.0 is a safe patch-level bump to the package manager.
72-79: TypeScript shim pattern is sound.The pattern of aliasing typescript50–typescript57 to npm:[email protected] versions for multi-version compatibility testing is reasonable and well-structured.
43-81: I'll verify the remaining tools mentioned in the review comment:No breaking changes detected in devDependency updates.
eslint 9.39.1 is a patch release that restores previous behavior, and nx 21.6.8 is a patch release per Nx policy with no breaking changes. knip 5.68.0 is the latest version, within the v5 release series. Vitest 3 has small breaking changes but should not affect most users—version 3.2.4 is a patch release within the 3.x series. @vitest/eslint-plugin requires ESLint v9.0.0 or higher, which is satisfied, and no breaking changes were detected in recent patch/minor updates.
All tooling updates appear safe to proceed.
examples/react/rick-morty/package.json (2)
15-16: React-router minor updates approved.Updates from 6.25.1 to 6.30.1 are safe minor/patch-level bumps; no breaking changes expected.
19-21: React/Tailwind devDependency minors approved.Consistent with similar updates across React examples; safe, non-breaking changes.
examples/react/star-wars/package.json (2)
15-16: React-router minor updates approved.Updates from 6.25.1 to 6.30.1 are safe minor/patch-level bumps; consistent with examples/react/rick-morty.
19-21: React/Tailwind devDependency minors approved.Consistent with ecosystem-wide updates; safe, non-breaking changes.
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.42.2", | ||
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.48.4", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify Svelte package versions exist on npm.
A previous review flagged that similar versions (@sveltejs/[email protected] and [email protected]) were not published on npm. Confirm the current versions (@sveltejs/[email protected] and [email protected]) are valid published releases on the npm registry.
Also applies to: 18-18
🌐 Web query:
Does npm package @sveltejs/kit version 2.48.4 exist
💡 Result:
Yes — @sveltejs/[email protected] exists (released Oct 30, 2025). [1][2][3]
Sources:
[1] jsDelivr package page for @sveltejs/kit (shows version 2.48.4).
[2] Snyk package page (lists latest version 2.48.4).
[3] Yarn package listing (shows 2.48.4 and release date Oct 30, 2025).
🌐 Web query:
Does npm package svelte version 5.43.4 exist
💡 Result:
Short answer: There’s no clear evidence that an official npm release [email protected] is published to the npm registry. The official GitHub releases list goes up to v5.43.3, while some third‑party trackers (Snyk, NewReleases) show a 5.43.4 entry — likely a metadata/propagation inconsistency. [1][2][3]
Sources:
- npm package page for svelte (registry metadata shown). [1]
- svelte GitHub releases (latest listed: [email protected]). [2]
- Snyk / NewReleases listings that report 5.43.4. [3][4]
Update svelte package version to 5.43.3 — 5.43.4 is not an official npm release.
Verification confirms @sveltejs/[email protected] exists on npm (released Oct 30, 2025). However, [email protected] does not appear to be an official npm release; the latest official GitHub release is [email protected]. Update line 18 from [email protected] to [email protected].
🤖 Prompt for AI Agents
In examples/svelte/auto-refetching/package.json around line 16, the svelte
dependency is pinned to a non-official release (5.43.4); change the svelte
dependency version to the official release 5.43.3 by replacing 5.43.4 with
5.43.3 on the svelte dependency line.
| "devDependencies": { | ||
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.42.2", | ||
| "@sveltejs/adapter-auto": "^6.1.1", |
There was a problem hiding this comment.
🧩 Analysis chain
Unresolved critical issue: @sveltejs/adapter-auto version needs verification.
This issue was flagged in a previous review and persists unresolved. Version ^6.1.1 may not exist—previous web searches indicate @sveltejs/adapter-auto uses v3.x versioning. Running npm install may fail if this version doesn't exist. Verify the correct version and update accordingly.
🌐 Web query:
What is the latest version of @sveltejs/adapter-auto on npm?
💡 Result:
The latest version on the npm registry is 6.1.0. [1]
Sources:
[1] https://www.npmjs.com/package/%40sveltejs/adapter-auto
@sveltejs/adapter-auto version 6.1.1 does not exist; use 6.1.0 instead.
The latest version on the npm registry is 6.1.0. Change @sveltejs/adapter-auto from ^6.1.1 to ^6.1.0 to resolve the install failure.
🤖 Prompt for AI Agents
In examples/svelte/playground/package.json around line 15, the dependency
"@sveltejs/adapter-auto" is pinned to a non-existent version "^6.1.1"; update
the version string to "^6.1.0" in the dependencies section so the package
resolves to the latest published 6.1.0 release and rerun install to verify.
924da7b to
de96738
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
examples/angular/infinite-query-with-max-pages/package.json (1)
19-19: Downgrade zone.js to 0.14.x for Angular 20.3.10 compatibility.This issue was previously flagged: Angular 20.x experiences incompatibility with zone.js 0.15.x, which will cause peerDependency resolution failures during installation. Update zone.js to
^0.14.2to align with Angular's peer dependency requirements.Apply this diff to fix the incompatibility:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Note: This same correction needs to be applied to other Angular example package.json files in this PR to maintain consistency and prevent similar issues across the codebase.
examples/angular/rxjs/package.json (1)
20-20: Downgrade zone.js to 0.14.x for Angular 20.3.10 compatibility.This issue was previously flagged: Angular 20.x experiences incompatibility with zone.js 0.15.x, which will cause peerDependency resolution failures during installation. Update zone.js to
^0.14.2to align with Angular's peer dependency requirements.Apply this diff to fix the incompatibility:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Note: This same correction needs to be applied to other Angular example package.json files in this PR to maintain consistency and prevent similar issues across the codebase.
examples/angular/basic/package.json (1)
19-19: 🔴 CRITICAL: zone.js 0.15.1 incompatible with Angular 20.3.10 peer dependencies.Angular 20.3.10 specifies zone.js ~0.14.x as a peer dependency; version 0.15.1 violates this constraint and will cause
pnpm installto fail with peer dependency resolution errors.Apply this diff to fix:
- "zone.js": "0.15.1" + "zone.js": "~0.14.2"This correction must be applied consistently across all Angular example package.json files in this PR (this issue was flagged in prior reviews but remains unresolved).
examples/angular/optimistic-updates/package.json (1)
12-25: 🔴 Critical: zone.js 0.15.1 remains incompatible with Angular 20.3.10 (previously flagged).This issue was already raised in the previous review but remains unresolved. Angular 20.3.10 enforces a peer dependency constraint requiring zone.js ~0.14.x. Keeping zone.js at 0.15.1 will cause ERESOLVE errors during
npm install, blocking the build entirely.Apply this diff to fix the incompatibility:
- "zone.js": "0.15.1" + "zone.js": "~0.14.10"Scope: The same correction should be applied to all other Angular example package.json files in this PR to maintain consistency and prevent cascading failures across examples (e.g., examples/angular/basic-persister, examples/angular/auto-refetching, examples/angular/basic, etc.).
examples/solid/basic-graphql-request/package.json (1)
14-14: Critical: graphql-request version 7.3.1 does not exist on npm.This is a persistent issue flagged in the previous review. The latest released version of graphql-request is 7.2.0. The caret constraint
^7.3.1will cause npm/yarn install to fail. Update to^7.2.0or verify the intended version number.- "graphql-request": "^7.3.1", + "graphql-request": "^7.2.0",examples/vue/nuxt3/package.json (1)
13-13: CRITICAL: Nuxt version ^3.20.1 does not exist—regression from previous review.This issue was previously flagged in past review comments (lines 10–13 of prior feedback), with research confirming that as of November 7, 2025, the latest Nuxt 3 stable release is v3.16.2. The past comments show this was marked "✅ Addressed," but the current code still contains the invalid version, indicating a regression or that the fix was not applied to this branch.
The version must be corrected before merge to prevent install failures.
Correct this to a valid released version (e.g.,
"^3.16.2"or the latest v3 release) and verify the example builds and runs without errors:#!/bin/bash # Verify nuxt version against npm registry curl -s https://registry.npmjs.org/nuxt | jq '.dist-tags' | grep -E '(latest|3\.)'examples/svelte/star-wars/package.json (1)
15-15: @sveltejs/[email protected] does not exist—update to 7.0.0.The latest version of @sveltejs/adapter-auto is 7.0.0. Version 6.1.1 was never published to npm and will cause
npm installto fail.Apply this diff:
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^7.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (58)
- packages/query-sync-storage-persister/package.json
- packages/vue-query-devtools/package.json
- packages/solid-query/package.json
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- examples/react/default-query-function/package.json
- examples/react/rick-morty/package.json
- examples/react/offline/package.json
- examples/angular/basic-persister/package.json
- packages/svelte-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/pagination/package.json
- integrations/vue-vite/package.json
- examples/solid/solid-start-streaming/package.json
- integrations/react-webpack-4/package.json
- examples/vue/simple/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-devtools/package.json
- examples/react/simple/package.json
- examples/react/chat/package.json
- examples/react/playground/package.json
- integrations/react-vite/package.json
- packages/vue-query/package.json
- examples/angular/router/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/2.6-basic/package.json
- integrations/solid-vite/package.json
- integrations/react-webpack-5/package.json
- examples/svelte/simple/package.json
- examples/solid/basic/package.json
- examples/vue/2.7-basic/package.json
- examples/svelte/basic/package.json
- packages/react-query-persist-client/package.json
- examples/angular/simple/package.json
- examples/svelte/playground/package.json
- examples/react/star-wars/package.json
- examples/react/algolia/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/ssr/package.json
- packages/solid-query-persist-client/package.json
- packages/svelte-query-devtools/package.json
- package.json
- examples/angular/devtools-panel/package.json
- packages/query-persist-client-core/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/auto-refetching/package.json
- packages/angular-query-experimental/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/simple/package.json
- examples/vue/persister/package.json
- examples/react/react-router/package.json
- packages/angular-query-persist-client/package.json
- examples/react/devtools-panel/package.json
- examples/solid/astro/package.json
- packages/svelte-query-persist-client/package.json
- examples/react/react-native/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/basic-graphql-request/package.jsonexamples/react/basic/package.jsonintegrations/react-next-15/package.jsonpackages/solid-query-devtools/package.jsonexamples/angular/optimistic-updates/package.jsonpackages/query-async-storage-persister/package.jsonexamples/vue/nuxt3/package.jsonexamples/angular/basic/package.jsonpackages/query-devtools/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/react-query/package.jsonexamples/solid/default-query-function/package.jsonintegrations/svelte-vite/package.jsonexamples/vue/dependent-queries/package.jsonexamples/svelte/star-wars/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.jsonpackages/query-devtools/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/react-query/package.jsonexamples/solid/default-query-function/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (18)
examples/react/suspense/package.json (1)
19-19: LGTM!The devDependency update from
@vitejs/plugin-react^4.3.4 → ^4.7.0 is a safe minor version bump that respects semantic versioning constraints. As a devDependency, this affects the build toolchain only and does not impact production code or runtime behavior.examples/angular/basic/package.json (1)
12-15: Angular framework and CLI packages: patch/minor updates look good.The Angular packages (@angular/common, @angular/compiler, @angular/core, @angular/platform-browser, @angular/build, @angular/cli, @angular/compiler-cli) are appropriately bumped within the ^20.3.x range. These updates are safe minor/patch version increments.
Also applies to: 22-24
examples/react/basic-graphql-request/package.json (2)
13-14: Dependency updates are safe and compatible.Both
graphqlandgraphql-requestare updated to compatible patch/minor versions within their respective major ranges. These should work seamlessly with the existing setup.
19-19: Plugin version update is safe.The
@vitejs/plugin-reactminor version bump to ^4.7.0 is compatible with Vite ^6.3.6 and should not require any configuration changes.examples/solid/default-query-function/package.json (1)
13-13: Routine patch updates — LGTM.Minor/patch version bumps to Solid.js ecosystem packages (solid-js, vite-plugin-solid) are consistent with the broader PR updates across other Solid examples.
Also applies to: 18-18
examples/solid/basic-graphql-request/package.json (1)
13-13: Other updates are routine.The graphql (^16.12.0), solid-js (^1.9.10), and vite-plugin-solid (^2.11.10) updates are valid minor/patch version bumps and align with ecosystem updates across other examples in this PR.
Also applies to: 15-15, 20-20
packages/query-test-utils/package.json (1)
38-38: Patch update to npm-run-all2 looks good.This is a safe patch-level version bump. No compatibility concerns.
packages/solid-query-devtools/package.json (1)
71-72: Solid ecosystem patch updates are aligned.The updates to solid-js, vite-plugin-solid, and npm-run-all2 are all patch-level and consistent with similar updates across the monorepo. The peer dependency constraint for solid-js (^1.6.0 at line 78) remains satisfied.
Also applies to: 74-74
packages/react-query/package.json (1)
73-74: Minor version updates to React testing libraries and Vite plugin.These updates are within safe semver ranges. The testing library update from 16.1.0 → 16.3.0 and Vite plugin update from 4.3.4 → 4.7.0 are minor bumps.
Verify that the test suite passes and that the Vite build succeeds with these updated versions to catch any unexpected API or behavior changes.
Also applies to: 77-77, 79-79
packages/query-async-storage-persister/package.json (1)
67-67: Patch update to npm-run-all2 is safe.Standard patch-level version bump across the monorepo.
examples/vue/basic/package.json (1)
16-16: @vitejs/plugin-vue patch bump is routine and safe.The minor patch update aligns with caret constraint semantics and matches the consistent version bump across other Vue example files in this PR.
examples/vue/nuxt3/package.json (1)
10-10: @tanstack/vue-query patch bump is routine.Patch-level version updates are safe within caret constraints.
examples/vue/dependent-queries/package.json (1)
15-15: @vitejs/plugin-vue patch bump is routine and safe.Consistent minor patch update across Vue example files in this PR; no compatibility concerns.
integrations/react-next-15/package.json (1)
9-9: @js-temporal/[email protected] is compatible and secure. ✓@js-temporal/[email protected] is compatible with Next.js 15 and React 19, and there are no known direct security vulnerabilities. The v0.5.1 release includes bug fixes and Node 22/23 support with no reported incompatibilities with React or Next. The minor version bump (0.4.4 → 0.5.1) aligns with the PR objective. Continue running standard dependency audits (npm audit/Snyk) as part of CI.
examples/react/basic/package.json (1)
23-23: @vitejs/plugin-react 4.7.0 is compatible with vite 6.3.6 — no issues found.@vitejs/[email protected] is compatible with Vite 6.3.6 and there are no plugin-specific breaking changes required. The minor version bump is safe to proceed with.
integrations/angular-cli-20/package.json (2)
23-25: Minor version stagger in Angular build tools is expected.@angular/build and @angular/cli at ^20.3.9 while other Angular packages are at ^20.3.10 is typical. These tools are often released sequentially and remain compatible within the same minor version family.
11-20: Approve dependency updates—all changes verified as safe.All updates follow semantic versioning within major versions. Verification confirms no explicit peer dependency constraints on tslib from @angular/[email protected], and tslib's release history from 2.3.0 to 2.8.1 shows clean progression with maintained backward compatibility. The changes are approved.
packages/query-devtools/package.json (1)
76-76: ****The original comment incorrectly flagged
"solid-js": "^1.9.10"as a critical blocker, claiming the version does not exist on npm. Verification confirms that [email protected] is available on npm and is marked as the latest stable version. The devDependency update is valid and poses no install or compatibility risk. No action is required for this change.Likely an incorrect or invalid review comment.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
de96738 to
ab80f54
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
examples/angular/basic/package.json (1)
19-19: 🔴 CRITICAL (Carryover from previous reviews): zone.js 0.15.1 incompatible with Angular 20.3.10.This issue was previously flagged in prior reviews but remains unresolved. Angular 20.3.10 requires zone.js ~0.14.x per peer dependency constraints. The current version 0.15.1 will cause
pnpm installto fail with peer dependency resolution errors and block all downstream usage.Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "~0.14.2"This fix must be applied consistently across all Angular example package.json files in this PR (verified in past reviews as affecting lines 12–15 and 19 in multiple files).
examples/react/react-native/package.json (1)
19-29: 🔴 CRITICAL: Unresolved React Native ecosystem incompatibility blocks merge—persists across multiple prior reviews.React Native 0.82 is available only as part of expo@canary releases; the next stable SDK 55 will ship React Native 0.83. The package versions in lines 19–29 are mutually incompatible and will fail at
pnpm installand native build time:
Line 19 (Expo SDK 52): Mirrors the minimum version of iOS required by React Native 0.76, and supports React Native 0.76 (default) and 0.77 (opt-in).
Line 23 (React Native 0.82.1): React Native 0.82 officially ends support for the old architecture, running exclusively on the New Architecture. This violates Expo SDK 52's RN target range.
Line 26 (react-native-reanimated 3.19.3): Reanimated 4.x supports only the New React Native architecture and three latest React Native versions; if your app still runs on the old architecture, stay with the latest 3.x release. Reanimated 3.19.3 does not support React Native 0.82.
This issue was flagged in previous reviews but remains unresolved.
Choose one remediation path before merging:
- Option A (recommended for stability): Migrate your project to React Native 0.81 or Expo SDK 54, keeping react-native-reanimated at 3.19.3.
- Option B (full ecosystem upgrade): Upgrade
expoto SDK 54 (which includes RN 0.81) or SDK 55 (for RN 0.83), then upgradereact-native-reanimatedto^4.1.x+for New Architecture support.Then run
pnpm installand verify the example builds and runs locally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (66)
- packages/vue-query/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/pagination/package.json
- integrations/react-next-15/package.json
- examples/react/simple/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/chat/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/query-core/package.json
- packages/react-query-persist-client/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/simple/package.json
- integrations/react-webpack-4/package.json
- examples/solid/solid-start-streaming/package.json
- examples/solid/simple/package.json
- examples/svelte/basic/package.json
- examples/svelte/star-wars/package.json
- examples/vue/nuxt3/package.json
- packages/solid-query-devtools/package.json
- examples/vue/persister/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/simple/package.json
- examples/react/offline/package.json
- examples/react/suspense/package.json
- examples/angular/simple/package.json
- packages/eslint-plugin-query/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/star-wars/package.json
- packages/query-devtools/package.json
- packages/query-test-utils/package.json
- integrations/solid-vite/package.json
- examples/svelte/ssr/package.json
- examples/angular/router/package.json
- examples/vue/2.7-basic/package.json
- integrations/react-webpack-5/package.json
- packages/react-query/package.json
- integrations/angular-cli-20/package.json
- examples/react/react-router/package.json
- packages/vue-query-devtools/package.json
- examples/angular/optimistic-updates/package.json
- packages/svelte-query/package.json
- integrations/svelte-vite/package.json
- examples/angular/devtools-panel/package.json
- examples/react/playground/package.json
- examples/react/algolia/package.json
- packages/solid-query/package.json
- examples/solid/astro/package.json
- integrations/react-vite/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/playground/package.json
- examples/react/rick-morty/package.json
- examples/angular/basic-persister/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic/package.json
- examples/react/devtools-panel/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/angular-query-experimental/package.json
- package.json
- packages/query-async-storage-persister/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/eslint-legacy/package.jsonpackages/react-query-next-experimental/package.jsonexamples/angular/basic/package.jsonexamples/vue/2.6-basic/package.jsonexamples/react/basic/package.jsonexamples/svelte/load-more-infinite-scroll/package.jsonpackages/react-query-devtools/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/react-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (11)
examples/angular/rxjs/package.json (1)
12-16: Angular and zone.js updates look good.All dependency updates are non-major version bumps (minor/patch) within the Angular ^20.x.x range, which should be safe. The minor version spread (^20.3.9 for build/cli vs. ^20.3.10 for other packages) is acceptable and common across Angular tooling ecosystems.
Also applies to: 20-20, 23-25
examples/react/basic/package.json (1)
23-23: Routine minor version bump for build tooling.The @vitejs/plugin-react version update (^4.3.4 → ^4.7.0) is a non-breaking minor version bump within the allowed semver range. No public API or runtime changes.
Ensure the example builds and runs correctly with the updated plugin version. The CI pipeline should verify this during the merge process.
examples/react/shadow-dom/package.json (1)
19-19: Consistent minor version bump across React examples.The @vitejs/plugin-react update (^4.3.4 → ^4.7.0) mirrors the same non-breaking bump pattern seen in other React example packages within this PR.
examples/react/default-query-function/package.json (1)
17-17: Non-breaking minor version bump.The @vitejs/plugin-react update (^4.3.4 → ^4.7.0) is consistent with other React examples and poses no compatibility concerns.
examples/react/eslint-legacy/package.json (1)
23-23: Routine non-breaking minor version bump.The @vitejs/plugin-react update (^4.3.4 → ^4.7.0) is a safe non-major version bump. The legacy ESLint configuration is orthogonal to the Vite build tooling update.
examples/svelte/load-more-infinite-scroll/package.json (1)
16-16: Verify remaining dependency versions are valid.Lines 16 (@sveltejs/kit) and 19 (svelte-check) were not flagged in this search. Verify that
@sveltejs/kit@^2.48.4andsvelte-check@^4.3.3are valid, released versions on npm before merging.Also applies to: 19-20
packages/react-query-next-experimental/package.json (1)
61-61: Dependency updates look good and are backward compatible.Both updates maintain caret ranges within their current major versions:
- @vitejs/plugin-react: ^4.3.4 → ^4.7.0 (minor bump with HMR improvements for compound components, no known vulnerabilities)
- npm-run-all2: ^5.0.0 → ^5.0.2 (patch bump)
These dev dependencies carry low risk and align with the repository-wide dependency sync pattern in the PR.
packages/react-query-devtools/package.json (1)
86-86: Dependency updates verified as safe and stable.All three updates (@testing-library/react ^16.3.0, @vitejs/plugin-react ^4.7.0, and npm-run-all2 ^5.0.2) maintain their existing caret ranges and represent non-breaking minor and patch-level bumps. These versions are stable with no known breaking changes or security issues.
examples/vue/basic/package.json (1)
16-16: ✓ Patch version bump for @vitejs/plugin-vue looks correct.The update from
^5.2.1to^5.2.4is a safe patch-level increment appropriate for a Renovate minor/patch dependency update PR.examples/vue/2.6-basic/package.json (1)
11-11: ✓ Patch version bump for @tanstack/vue-query looks correct.The update from
^5.90.2to^5.90.7is a safe patch-level increment. This example appropriately pins legacy versions (Vue 2.6, Vite 4.x) for backward compatibility testing.integrations/vue-vite/package.json (1)
13-13: ✓ Patch version bump for @vitejs/plugin-vue looks correct.The update from
^5.2.1to^5.2.4is a safe patch-level increment. The package correctly uses"workspace:*"for the@tanstack/vue-querydependency, following the workspace dependency pattern.
| "devDependencies": { | ||
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.42.2", | ||
| "@sveltejs/adapter-auto": "^6.1.1", |
There was a problem hiding this comment.
❓ Verification inconclusive
🚨 CRITICAL: Both Svelte versions are non-existent and will break pnpm install.
Svelte 5.43.4 is the latest released version, but line 18 specifies ^5.43.5, which does not exist on npm. Additionally, @sveltejs/adapter-auto's latest published version is 6.0.1, but line 15 specifies ^6.1.1, which does not exist.
This file has a documented history of committing non-existent versions (5.41.2, 5.41.4, 5.42.3, 5.43.3 were flagged in past reviews). Both versions must be corrected before merging:
- "@sveltejs/adapter-auto": "^6.1.1",
+ "@sveltejs/adapter-auto": "^6.0.1",- "svelte": "^5.43.5",
+ "svelte": "^5.43.4",Also applies to: 18-18
🚨 CRITICAL: Both package versions do not exist on npm and will break pnpm install.
Svelte's latest version is 5.43.4, but line 18 specifies ^5.43.5, which does not exist. @sveltejs/adapter-auto's latest version is 6.0.1, but line 15 specifies ^6.1.1, which does not exist.
This file has a documented history of committing non-existent versions. Both versions must be corrected before merging:
- "@sveltejs/adapter-auto": "^6.1.1",
+ "@sveltejs/adapter-auto": "^6.0.1",- "svelte": "^5.43.5",
+ "svelte": "^5.43.4",Also applies to: 18-18
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around lines 15 and
18, the listed package versions do not exist on npm and will break pnpm install;
change "@sveltejs/adapter-auto" from "^6.1.1" to a published version (use
"^6.0.1") and change "svelte" from "^5.43.5" to the published "5.43.4" (or
another existing published version you confirm), then run pnpm install (and
commit the updated lockfile) to ensure the dependency graph is valid.
a779db2 to
0739d00
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/query-devtools/package.json (1)
76-76: [DUPLICATE] solid-js version 1.9.10 does not exist on npm.This issue was already flagged in past review. Latest npm version of solid-js as of October 31, 2025 is 1.9.9. The package.json specifies an unresolvable version constraint which will cause npm install to fail.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/svelte/optimistic-updates/package.json
🚧 Files skipped from review as they are similar to previous changes (61)
- examples/vue/nuxt3/package.json
- integrations/vue-vite/package.json
- examples/vue/2.7-basic/package.json
- examples/react/default-query-function/package.json
- integrations/solid-vite/package.json
- examples/react/simple/package.json
- packages/solid-query-devtools/package.json
- examples/vue/persister/package.json
- integrations/react-webpack-5/package.json
- examples/angular/optimistic-updates/package.json
- examples/vue/2.6-basic/package.json
- examples/react/react-router/package.json
- packages/query-persist-client-core/package.json
- examples/vue/basic/package.json
- packages/query-test-utils/package.json
- packages/react-query-devtools/package.json
- packages/query-sync-storage-persister/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/ssr/package.json
- examples/solid/astro/package.json
- integrations/react-webpack-4/package.json
- examples/angular/rxjs/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/react/offline/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/basic-persister/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/devtools-panel/package.json
- examples/svelte/basic/package.json
- examples/svelte/star-wars/package.json
- examples/solid/basic-graphql-request/package.json
- integrations/react-next-15/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/react-vite/package.json
- packages/vue-query/package.json
- examples/angular/simple/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/basic/package.json
- examples/react/suspense/package.json
- packages/angular-query-persist-client/package.json
- examples/react/star-wars/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/router/package.json
- examples/angular/pagination/package.json
- examples/react/react-native/package.json
- examples/react/rick-morty/package.json
- examples/svelte/playground/package.json
- examples/vue/simple/package.json
- integrations/angular-cli-20/package.json
- packages/query-core/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/auto-refetching/package.json
- packages/solid-query-persist-client/package.json
- packages/vue-query-devtools/package.json
- examples/solid/default-query-function/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query/package.json
- examples/vue/dependent-queries/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/basic/package.jsonpackages/solid-query/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/react/eslint-legacy/package.jsonpackages/query-broadcast-client-experimental/package.jsonexamples/react/basic/package.jsonexamples/react/algolia/package.jsonexamples/solid/simple/package.jsonpackages/query-devtools/package.jsonpackages/angular-query-experimental/package.jsonpackages/react-query/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
examples/solid/basic/package.jsonpackages/solid-query/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/solid/simple/package.jsonpackages/query-devtools/package.jsonpackages/react-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (15)
examples/react/basic/package.json (1)
23-23: Routine dependency update looks good.Minor version bump to @vitejs/plugin-react is consistent with the broader set of React examples being updated in this PR.
examples/react/devtools-panel/package.json (1)
17-17: Routine dependency update looks good.Consistent with other React example updates in the PR.
examples/svelte/simple/package.json (1)
16-18: Coordinated Svelte tooling updates look good.Consistent pattern of minor/patch bumps across svelte, @tsconfig/svelte, and svelte-check with caret ranges preserved.
examples/react/shadow-dom/package.json (1)
19-19: Routine dependency update looks good.Consistent with other React example updates in the PR.
examples/react/playground/package.json (1)
17-17: Routine dependency update looks good.Consistent with other React example updates in the PR.
packages/react-query/package.json (1)
73-79: Coordinated testing and tooling updates look good.All devDependency bumps are minor/patch versions with consistent caret ranges. Workspace dependency on @tanstack/query-core correctly preserved.
packages/svelte-query-persist-client/package.json (1)
55-63: Coordinated Svelte tooling and linting updates look good.All devDependency bumps are minor/patch versions with consistent caret ranges. Updated svelte ^5.43.5 remains compatible with peerDependencies constraint (svelte: ^5.25.0). Workspace dependencies preserved correctly.
examples/react/algolia/package.json (1)
11-11: Dependency updates look good.@algolia/client-search is updated to a significantly newer patch version (5.43.0), which Renovate has validated for compatibility. @vitejs/plugin-react minor bump is consistent with other React examples. Exact version pinning for Algolia is preserved.
Also applies to: 21-21
packages/query-broadcast-client-experimental/package.json (1)
62-62: ✓ Safe dependency updates.All bumps are minor/patch versions under caret ranges. Broadcast-channel, testing library, Vite plugin, and npm-run-all2 are stable tooling packages with no expected breaking changes.
Also applies to: 65-67
examples/react/eslint-legacy/package.json (1)
23-23: ✓ Safe minor version bump.@vitejs/plugin-react update from 4.3.4 to 4.7.0 is a minor release with no breaking changes. Consistent with updates in other React example packages.
packages/angular-query-experimental/package.json (1)
92-95: ✓ Safe coordinated ecosystem updates.Angular packages bumped from 20.0.0 to 20.3.10 are minor releases within the major 20 version. Testing library, tooling, and plugin updates are all patch/minor bumps. Peer dependencies (line 108-109) require Angular >=16.0.0, which 20.3.10 satisfies.
Also applies to: 97-101
examples/react/chat/package.json (1)
17-19: ✓ Safe Tailwind ecosystem update.Tailwindcss and @tailwindcss/vite bumped coordinately to 4.1.17 (minor release). @vitejs/plugin-react also updated to 4.7.0. All devDependency updates with safe caret ranges.
package.json (1)
8-8: ✓ Safe package manager and dev tool updates.pnpm upgraded to 10.21.0 (minor bump). Multiple ESLint, testing, and build tool devDependencies updated using safe caret ranges. TypeScript version aliases (lines 72-79) enable multi-version testing. All updates are backwards compatible within their ranges.
Also applies to: 43-68, 80-81
packages/solid-query/package.json (1)
75-75: ⛔ Critical: solid-js version 1.9.10 does not exist on npm.The latest npm version of solid-js as of October 31, 2025 is 1.9.9. The devDependency constraint
"solid-js": "^1.9.10"cannot be resolved and will causenpm installto fail, blocking builds and CI/CD.Correct the version to
"^1.9.9":- "solid-js": "^1.9.10", + "solid-js": "^1.9.9",⛔ Skipped due to learnings
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.examples/solid/basic/package.json (1)
13-13: Dependency updates look good.Minor and patch version bumps for solid-js and vite-plugin-solid are consistent with the PR objective of updating non-major dependencies. The caret constraints (^) remain in place, ensuring compatible updates.
Also applies to: 18-18
| "@tanstack/solid-query": "^5.90.11", | ||
| "@tanstack/solid-query-devtools": "^5.90.4", | ||
| "solid-js": "^1.9.7" | ||
| "solid-js": "^1.9.10" |
There was a problem hiding this comment.
⛔ Critical: solid-js version 1.9.10 does not exist on npm.
The latest npm version of solid-js as of October 31, 2025 is 1.9.9. The dependency constraint "solid-js": "^1.9.10" cannot be resolved and will cause npm install to fail, breaking CI/CD.
Correct the version to "^1.9.9":
- "solid-js": "^1.9.10"
+ "solid-js": "^1.9.9"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "solid-js": "^1.9.10" | |
| "solid-js": "^1.9.9" |
🤖 Prompt for AI Agents
In examples/solid/simple/package.json around line 13, the dependency "solid-js":
"^1.9.10" references a non-existent npm version and will break installs; update
the dependency to a valid published version by changing it to "solid-js":
"^1.9.9" (replace the version string only, keep the caret constraint).
a60089e to
53d8e2f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (5)
examples/svelte/playground/package.json (1)
15-15: 🔴 DUPLICATE: Unresolved critical issue with @sveltejs/adapter-auto.The latest published version of @sveltejs/adapter-auto is 7.0.0, and web search results only show 6.1.0 published a month ago. Version 6.1.1 does not appear to exist on npm. This issue was flagged in a previous review and remains unresolved.
Before merging, verify that 6.1.1 is a valid version or update to 6.1.0 instead.
examples/svelte/basic/package.json (1)
17-21: 🔴 CRITICAL: @sveltejs/adapter-auto 6.1.1 and svelte 5.43.5 do not exist on npm—will fail installation.This issue was previously flagged and marked as addressed, but it persists. Version 6.1.1 of @sveltejs/adapter-auto does not exist on npm (latest is 7.0.0+). Similarly, svelte 5.43.5 is not a published release. Both will cause
pnpm installto fail.Apply these corrections:
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^7.0.0",- "svelte": "^5.43.5", + "svelte": "^5.43.4",Verify the corrected versions exist on npm before merging.
examples/svelte/load-more-infinite-scroll/package.json (1)
15-19: 🔴 CRITICAL: Invalid Svelte package versions—recurring issue on this file.This file has a documented pattern of invalid package versions across multiple review cycles (5.41.2, 5.41.4, 5.42.3, 5.43.3, 5.43.5 have all been flagged). The current versions remain invalid:
- @sveltejs/adapter-auto 6.1.1 does not exist on npm.
- svelte 5.43.5 is not a published release.
Both will cause
pnpm installto fail. This issue was previously marked as addressed but persists.Apply these corrections:
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^7.0.0",- "svelte": "^5.43.4", + "svelte": "^5.43.4",Verify the corrected versions exist on npm and test
pnpm installlocally before merging. Given the recurring pattern, please also review the Renovate configuration or CI checks that should prevent invalid versions from being committed.examples/react/react-native/package.json (1)
19-29: 🔴 CRITICAL: React Native ecosystem incompatibility—unresolved blocker for merge.This incompatibility was previously identified in multiple review cycles but remains unresolved. The version combination cannot coexist:
- Expo SDK 52 (line 19) supports React Native 0.76 and 0.77 (opt-in only); React Native 0.82.1 requires Expo SDK 54+ or canary releases.
- react-native@^0.82.1 (line 23) will fail dependency resolution with Expo SDK 52.
- react-native-reanimated@^3.19.4 (line 26) supports React Native 0.78–0.81 only; React Native 0.82 requires Reanimated 4.x+.
pnpm installand native builds will fail with these versions.Choose one remediation path before merging:
- Option A (recommended for stability): Downgrade
react-nativeto^0.77.x(or^0.76.xto match Expo SDK 52 default), keepingreact-native-reanimated@^3.19.4and Expo SDK 52.- Option B (full ecosystem upgrade): Upgrade
expoto stable SDK 54+ (targets React Native 0.81), then upgradereact-native-reanimatedto^4.x+and alignreact-nativeaccordingly.- Option C (match Expo SDK 52 default): Downgrade
react-nativeto^0.76.xto align with Expo SDK 52's tested baseline configuration.Then run
pnpm installand verify the example builds and runs locally before merging.examples/angular/query-options-from-a-service/package.json (1)
12-20: 🔴 Critical: zone.js 0.15.1 incompatible with Angular ^20.3.x peer dependency.This issue was already flagged in the past review. Angular 20.3.x requires
zone.js ~0.14.x, but zone.js 0.15.1 is pinned here, causing npm peer dependency resolution to fail.Apply this diff to fix:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-devtools/package.json
🚧 Files skipped from review as they are similar to previous changes (48)
- packages/query-test-utils/package.json
- packages/vue-query-devtools/package.json
- examples/react/devtools-panel/package.json
- examples/vue/nuxt3/package.json
- examples/solid/simple/package.json
- integrations/react-webpack-5/package.json
- examples/react/chat/package.json
- examples/react/offline/package.json
- examples/react/simple/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- packages/query-persist-client-core/package.json
- examples/react/shadow-dom/package.json
- integrations/solid-vite/package.json
- packages/eslint-plugin-query/package.json
- packages/react-query-devtools/package.json
- examples/angular/optimistic-updates/package.json
- examples/solid/basic-graphql-request/package.json
- integrations/react-vite/package.json
- integrations/angular-cli-20/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/solid/solid-start-streaming/package.json
- examples/svelte/star-wars/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/basic/package.json
- examples/react/star-wars/package.json
- examples/solid/astro/package.json
- packages/query-async-storage-persister/package.json
- packages/angular-query-experimental/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/rick-morty/package.json
- examples/react/react-router/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/auto-refetching/package.json
- examples/vue/dependent-queries/package.json
- integrations/react-webpack-4/package.json
- examples/angular/basic-persister/package.json
- packages/solid-query/package.json
- examples/solid/default-query-function/package.json
- examples/angular/auto-refetching/package.json
- integrations/svelte-vite/package.json
- examples/angular/pagination/package.json
- examples/svelte/ssr/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/simple/package.json
- examples/svelte/simple/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/router/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/react-query-next-experimental/package.jsonexamples/vue/2.6-basic/package.jsonpackages/query-core/package.jsonpackages/react-query-persist-client/package.jsonexamples/svelte/optimistic-updates/package.jsonpackages/solid-query-devtools/package.jsonexamples/svelte/load-more-infinite-scroll/package.jsonpackages/vue-query/package.jsonexamples/vue/2.7-basic/package.jsonintegrations/react-next-15/package.jsonexamples/svelte/playground/package.jsonexamples/angular/devtools-panel/package.jsonexamples/svelte/basic/package.jsonexamples/react/algolia/package.jsonexamples/angular/query-options-from-a-service/package.jsonpackages/react-query/package.jsonpackages/angular-query-persist-client/package.jsonexamples/vue/persister/package.jsonexamples/solid/basic/package.jsonpackages/svelte-query/package.jsonpackage.jsonexamples/react/basic/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.jsonpackages/react-query/package.jsonexamples/solid/basic/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (28)
integrations/vue-vite/package.json (1)
13-13: LGTM!Patch-level update to a build-time dependency. Safe to proceed.
packages/query-core/package.json (1)
63-63: LGTM!Patch-level update to a dev-only script orchestration tool. Safe to proceed.
packages/vue-query/package.json (2)
66-66: LGTM!Patch-level update to devtools API. Safe to proceed.
73-73: LGTM!Patch-level update to linting tool. Safe to proceed.
packages/react-query-next-experimental/package.json (2)
61-61: LGTM!Minor-level update to a build-time dependency. Within same major version. Safe to proceed.
63-63: LGTM!Patch-level update to dev-only script orchestration tool. Safe to proceed.
packages/solid-query-devtools/package.json (1)
71-74: LGTM!Patch-level updates to dev-only and peer dependencies. All within same major version ranges. Safe to proceed.
examples/svelte/playground/package.json (1)
16-16: LGTM!Minor/patch-level updates to Svelte ecosystem packages. Updates are within same major version ranges and safe to proceed (assuming the @sveltejs/adapter-auto version issue above is resolved).
Also applies to: 18-19
examples/vue/basic/package.json (1)
16-16: LGTM!Patch-level update to a build-time dependency. Safe to proceed.
examples/solid/basic/package.json (1)
13-13: LGTM!Patch-level updates to production and dev dependencies. Both within same major version ranges and safe to proceed.
Also applies to: 18-18
packages/angular-query-persist-client/package.json (1)
60-70: Standard dependency updates—LGTM.Angular packages are consistently updated to ^20.3.10, and test/lint tooling bumps are all compatible. No breaking changes expected.
integrations/react-next-15/package.json (1)
9-9: Standard polyfill patch update—LGTM.Straightforward dependency bump with no breaking changes expected.
examples/vue/persister/package.json (1)
15-19: Standard dependency updates—LGTM.Minor and patch version bumps for Vite plugin and storage library. No breaking changes expected.
examples/vue/simple/package.json (1)
16-16: Standard Vite plugin update—LGTM.Consistent minor version bump across Vue examples. No breaking changes expected.
examples/angular/devtools-panel/package.json (1)
12-25: Original concern is no longer applicable—zone.js 0.15.1 is compatible with Angular 20.3.10.Angular 20.3.10 treats zone.js as an optional peer dependency, and both 0.14 and 0.15 ranges are compatible options. The previous review flagging zone.js 0.15.1 as incompatible with Angular 20.3.7 was based on older compatibility constraints that have since been relaxed. No changes needed.
examples/svelte/optimistic-updates/package.json (1)
15-19: Svelte tooling updates look good.Minor/patch version bumps for Svelte framework and development tools are standard and safe.
packages/svelte-query/package.json (1)
55-62: Svelte and tooling devDependency updates are appropriate.Minor/patch version bumps for Svelte ecosystem packages and linting tools are safe and align with upstream ecosystem releases.
package.json (1)
8-8: Tool and devDependency updates are reasonable.The pnpm version bump to 10.21.0 and tool updates (linters, formatters, testing utilities) are standard patch/minor bumps. The new TypeScript version aliases (typescript50–typescript57) support multi-version testing, which is a good practice for this type of library.
Also applies to: 43-81
examples/vue/2.7-basic/package.json (1)
11-11: Vue Query patch update is safe.The bump from ^5.90.2 to ^5.90.7 is a patch-level update within the same minor version range and poses no compatibility risks.
examples/react/basic/package.json (1)
23-23: Vitejs React plugin minor update is safe.The bump from ^4.3.4 to ^4.7.0 is a minor version update within the same major version range and presents no compatibility concerns for React examples.
examples/vue/2.6-basic/package.json (1)
11-11: Vue Query patch update is safe.The bump from ^5.90.2 to ^5.90.7 is a patch-level update and maintains compatibility.
examples/react/suspense/package.json (1)
19-19: Straightforward minor version update.The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a standard minor-version bump within the major version 4, which should maintain backward compatibility with existing build configurations.
packages/react-query-persist-client/package.json (1)
67-67: Consistent non-major dependency updates.The updates to @testing-library/react, @vitejs/plugin-react, and npm-run-all2 are all minor or patch-level bumps that maintain backward compatibility. The workspace dependency structure remains intact, which is correct.
Also applies to: 69-69, 70-70
examples/react/default-query-function/package.json (1)
17-17: Straightforward minor version update.The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a standard minor-version bump within the major version 4, maintaining backward compatibility.
examples/react/algolia/package.json (2)
21-21: Straightforward minor version update.The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a standard minor-version bump within the major version 4, maintaining backward compatibility.
11-11: @algolia/client-search update is safe — no breaking API changes.The v5 line is backwards-compatible, with releases in the 5.x series being backwards-compatible fixes, improvements, and non-breaking features. You can upgrade from 5.2.1 to 5.43.0 with no API contract migration required. The large minor version jump reflects normal feature additions within the same major version.
packages/react-query/package.json (1)
73-74: Core package dependency updates are safe and consistent.All devDependency updates in this core package (@testing-library/react, @testing-library/react-render-stream, @vitejs/plugin-react, and npm-run-all2) are non-major version bumps that maintain backward compatibility. The workspace dependency structure is preserved correctly.
Also applies to: 77-77, 79-79
examples/react/playground/package.json (1)
17-17: Straightforward minor version update.The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a standard minor-version bump within the major version 4, maintaining backward compatibility.
examples/angular/rxjs/package.json
Outdated
| "@angular/common": "^20.3.10", | ||
| "@angular/compiler": "^20.3.10", | ||
| "@angular/core": "^20.3.10", | ||
| "@angular/forms": "^20.3.10", | ||
| "@angular/platform-browser": "^20.3.10", | ||
| "@tanstack/angular-query-experimental": "^5.90.10", | ||
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.15.1" |
There was a problem hiding this comment.
🔴 Critical: zone.js 0.15.1 incompatible with Angular ^20.3.x peer dependency.
Angular 20.3.x declares a peer dependency on zone.js ~0.14.x. Pinning zone.js to 0.15.1 violates this constraint and will cause npm install to fail with peer dependency resolution errors.
Apply this diff to fix:
- "zone.js": "0.15.1"
+ "zone.js": "^0.14.2"This same correction is needed across all Angular example package.json files in this PR (e.g., examples/angular/query-options-from-a-service/package.json).
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/common": "^20.3.10", | |
| "@angular/compiler": "^20.3.10", | |
| "@angular/core": "^20.3.10", | |
| "@angular/forms": "^20.3.10", | |
| "@angular/platform-browser": "^20.3.10", | |
| "@tanstack/angular-query-experimental": "^5.90.10", | |
| "rxjs": "^7.8.2", | |
| "tslib": "^2.8.1", | |
| "zone.js": "0.15.0" | |
| "zone.js": "0.15.1" | |
| "@angular/common": "^20.3.10", | |
| "@angular/compiler": "^20.3.10", | |
| "@angular/core": "^20.3.10", | |
| "@angular/forms": "^20.3.10", | |
| "@angular/platform-browser": "^20.3.10", | |
| "@tanstack/angular-query-experimental": "^5.90.10", | |
| "rxjs": "^7.8.2", | |
| "tslib": "^2.8.1", | |
| "zone.js": "^0.14.2" |
🤖 Prompt for AI Agents
In examples/angular/rxjs/package.json around lines 12 to 20, zone.js is pinned
to 0.15.1 which conflicts with Angular ^20.3.x peer dependency that requires
~0.14.x; update the zone.js dependency to a compatible range (e.g., "~0.14.0" or
a specific 0.14.x patch) so npm peer resolution succeeds, and apply the same
change to all other Angular example package.json files in this PR (for
consistency update examples/angular/query-options-from-a-service/package.json
and any other Angular examples).
821900f to
726717e
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (4)
examples/solid/basic-graphql-request/package.json (1)
13-14: ** Verify graphql-request version 7.3.3 exists on npm.**Past review feedback flagged graphql-request 7.3.1 as a non-existent version. The current update specifies ^7.3.3; please verify this is a valid released version on npm before merging.
examples/angular/simple/package.json (1)
19-19: 🔴 CRITICAL: zone.js 0.15.1 incompatible with Angular 20.3.10—blocks merge.Angular packages specify zone.js as a peer dependency with an upper bound below 0.15; zone.js 0.15.1 violates this constraint and will cause ERESOLVE peer dependency resolution failures during
pnpm install.This issue was flagged in prior reviews but remains unresolved. Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "~0.14.2"Ensure this same correction is applied to all Angular example package.json files in this PR.
examples/angular/basic/package.json (1)
19-19: 🔴 CRITICAL: zone.js 0.15.1 incompatible with Angular 20.3.10—blocks merge.Angular packages specify zone.js as a peer dependency with an upper bound below 0.15; zone.js 0.15.1 violates this constraint and will cause ERESOLVE peer dependency resolution failures during
pnpm install.This issue was flagged in prior reviews but remains unresolved. Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "~0.14.2"Ensure this same correction is applied to all Angular example package.json files in this PR.
examples/react/react-native/package.json (1)
19-29: 🔴 CRITICAL: React Native ecosystem incompatibility—persists unresolved despite prior flagging.Multiple prior reviews identified this incompatibility, but it remains unresolved in the current code:
- Expo SDK 52 mismatch: Expo SDK 52 (line 19) supports React Native 0.76 and 0.77 (opt-in) only. React Native 0.82.1 (line 23) is incompatible with this SDK version.
- react-native-reanimated incompatibility: Reanimated 3.19.4 (line 26) is not officially compatible with React Native 0.82.
- Dependency resolution failure: This version combination cannot coexist and will fail
pnpm installand native builds.Choose one remediation path before merging:
- Option A (recommended): Downgrade
react-nativeto^0.77.xand verifyreact-native-reanimatedremains compatible.- Option B (full upgrade): Upgrade
expoto SDK 54+ (with RN 0.81 support), upgradereact-native-reanimatedto^4.x+, and verify all RN ecosystem packages align.- Option C (match SDK 52 default): Downgrade
react-nativeto^0.76.xto align with Expo SDK 52's default configuration.Then run
pnpm installand verify the example builds and runs locally.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (56)
- packages/solid-query/package.json
- examples/solid/solid-start-streaming/package.json
- integrations/solid-vite/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/basic/package.json
- examples/vue/2.6-basic/package.json
- packages/angular-query-experimental/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/solid/default-query-function/package.json
- packages/query-persist-client-core/package.json
- examples/react/simple/package.json
- integrations/react-webpack-5/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- integrations/react-vite/package.json
- examples/vue/nuxt3/package.json
- packages/react-query/package.json
- examples/svelte/star-wars/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/router/package.json
- examples/react/default-query-function/package.json
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/optimistic-updates/package.json
- examples/solid/astro/package.json
- examples/react/basic/package.json
- examples/vue/persister/package.json
- examples/angular/basic-persister/package.json
- examples/angular/rxjs/package.json
- examples/react/chat/package.json
- examples/react/offline/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/playground/package.json
- examples/react/react-router/package.json
- packages/query-devtools/package.json
- packages/query-core/package.json
- packages/angular-query-persist-client/package.json
- integrations/angular-cli-20/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/simple/package.json
- examples/react/suspense/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/simple/package.json
- examples/angular/pagination/package.json
- packages/query-test-utils/package.json
- integrations/vue-vite/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/star-wars/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/ssr/package.json
- examples/angular/devtools-panel/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/basic/package.json
- examples/react/algolia/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/vue-query-devtools/package.jsonexamples/angular/simple/package.jsonpackages/query-async-storage-persister/package.jsonpackages/solid-query-devtools/package.jsonpackages/solid-query-persist-client/package.jsonexamples/vue/2.7-basic/package.jsonpackages/react-query-devtools/package.jsonexamples/react/basic-graphql-request/package.jsonintegrations/react-next-15/package.jsonintegrations/svelte-vite/package.jsonpackages/svelte-query/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/react-query-persist-client/package.jsonexamples/angular/basic/package.jsonpackages/vue-query/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.jsonpackages/solid-query-persist-client/package.jsonpackages/react-query-devtools/package.jsonpackages/svelte-query/package.jsonexamples/solid/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (18)
packages/react-query-devtools/package.json (1)
86-89: Standard minor/patch updates—safe to merge.The dependency version bumps (@testing-library/react, @vitejs/plugin-react, npm-run-all2) are all within minor/patch ranges and align with updates across other packages in the PR.
examples/vue/dependent-queries/package.json (1)
15-15: Routine patch update—safe to merge.The @vitejs/plugin-vue bump is a standard patch-level update within the caret range, consistent with other Vue packages in the PR.
packages/vue-query-devtools/package.json (1)
58-58: Routine patch update—safe to merge.The eslint-plugin-vue bump is a standard patch-level update, consistent with linting toolchain improvements across the PR.
examples/react/devtools-panel/package.json (1)
17-17: Routine minor update—safe to merge.The @vitejs/plugin-react bump (^4.3.4 → ^4.7.0) is a standard minor-level update within the caret range, applied consistently across React example packages in the PR.
examples/vue/2.7-basic/package.json (1)
11-11: Routine patch update—safe to merge.The @tanstack/vue-query workspace dependency bump (^5.90.2 → ^5.90.7) is a standard patch-level update, consistent with updates across other Vue example packages in the PR.
examples/svelte/simple/package.json (1)
16-16: Routine patch updates—safe to merge.The @tsconfig/svelte and svelte-check patch bumps are standard updates within their caret ranges.
Also applies to: 18-18
packages/react-query-persist-client/package.json (1)
67-67: Standard minor/patch updates—safe to merge.The dependency version bumps (@testing-library/react, @vitejs/plugin-react, npm-run-all2) are all within minor/patch ranges and align with similar updates across other React packages in the PR.
Also applies to: 69-70
examples/vue/basic/package.json (1)
16-16: LGTM!Minor patch bump for @vitejs/plugin-vue. No concerns.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM!Minor patch bump for npm-run-all2 and workspace dependencies are correctly configured.
examples/react/rick-morty/package.json (1)
15-16: LGTM!Minor and patch version bumps for React Router, Tailwind, and Vite plugins. Standard maintenance updates consistent with other React examples in this PR.
Also applies to: 19-21
examples/solid/basic-graphql-request/package.json (1)
20-20: LGTM!Minor patch bump for vite-plugin-solid. No concerns.
examples/react/shadow-dom/package.json (1)
19-19: LGTM!Minor version bump for @vitejs/plugin-react, aligned with other React examples in this PR.
packages/vue-query/package.json (1)
66-66: LGTM!Patch bumps for @vue/devtools-api and eslint-plugin-vue. No concerns.
Also applies to: 73-73
integrations/react-next-15/package.json (1)
9-9: LGTM!Minor version bump for @js-temporal/polyfill. No concerns.
packages/svelte-query/package.json (1)
55-62: Routine devDependency updates look good.Minor and patch version bumps to Svelte tooling and linting. Svelte peer dependency constraint (
^5.25.0at line 65) is satisfied by the updated^5.43.6.package.json (1)
8-8: Root package.json updates are routine and well-aligned.Minor/patch version bumps to workspace devDependencies, new TypeScript version aliases for cross-version testing, and a pnpm packageManager patch update. All standard maintenance for a monorepo.
Also applies to: 43-82
packages/solid-query-persist-client/package.json (1)
73-76: Solid ecosystem tooling updates look good.Routine minor and patch version bumps to npm-run-all2, solid-js, and vite-plugin-solid. Consistent with Solid-related updates across the PR.
packages/solid-query-devtools/package.json (1)
71-74: Solid devtools ecosystem updates are routine.Minor and patch version bumps to Solid ecosystem dependencies. Consistent with parallel updates in other Solid-related packages.
| "graphql": "^16.12.0", | ||
| "graphql-request": "^7.3.3", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify graphql-request version 7.3.3 exists on npm.
Past review feedback flagged graphql-request 7.3.1 as a non-existent version. Please confirm that version 7.3.3 is a valid released version on npm; if not, update to the latest available version (e.g., 7.2.0 if 7.3.x does not exist).
The graphql update to ^16.12.0 and @vitejs/plugin-react to ^4.7.0 appear reasonable.
Also applies to: 19-19
🌐 Web query:
What are the latest versions of graphql and graphql-request available on npm?
💡 Result:
- graphql: 17.0.0-alpha.8. [1]
- graphql-request: 7.2.0. [2]
Sources:
[1] npm package page for graphql.
[2] npm package page for graphql-request.
Update graphql-request to the latest available version (7.2.0).
Version 7.3.3 does not exist on npm. The latest stable version of graphql-request is 7.2.0. Update the dependency accordingly.
The graphql ^16.12.0 update is valid.
🤖 Prompt for AI Agents
In examples/react/basic-graphql-request/package.json around lines 13 to 14, the
graphql-request dependency is pinned to a non-existent version ("^7.3.3");
update that entry to the latest published stable version ("^7.2.0") so the
dependency resolves correctly and then run npm/yarn install to refresh lockfile
and node_modules.
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "@tsconfig/svelte": "^5.0.5", | ||
| "svelte": "^5.43.6", |
There was a problem hiding this comment.
🚨 CRITICAL: Svelte 5.43.6 does not exist on npm—downgrade to 5.43.5.
The latest Svelte version on npm is 5.43.5 (published 2 days ago). The version specifier ^5.43.6 will cause pnpm install to fail. This is the second occurrence of this non-existent version in the PR (also flagged in integrations/svelte-vite/package.json).
Apply this diff to resolve:
- "svelte": "^5.43.6",
+ "svelte": "^5.43.5",Then run pnpm install to update the lockfile and verify the dependency resolves correctly.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "svelte": "^5.43.6", | |
| "svelte": "^5.43.5", |
🤖 Prompt for AI Agents
In examples/svelte/simple/package.json around line 17, the Svelte dependency is
pinned to a non-existent version (^5.43.6) which will break installs; change the
version specifier to "5.43.5" (or ^5.43.5 if caret is desired) in this file (and
the other occurrence in integrations/svelte-vite/package.json), then run pnpm
install to update the lockfile and verify the dependency resolves successfully.
| "@tanstack/svelte-query": "workspace:*", | ||
| "@tanstack/svelte-query-devtools": "workspace:*", | ||
| "svelte": "^5.39.3", | ||
| "svelte": "^5.43.6", |
There was a problem hiding this comment.
🚨 CRITICAL: Svelte 5.43.6 does not exist on npm—downgrade to 5.43.5.
The latest Svelte version on npm is 5.43.5 (published 2 days ago). The caret specifier ^5.43.6 requires version 5.43.6 or higher, which does not exist and will cause pnpm install to fail.
This mirrors a recurring pattern flagged in past reviews on this file where non-existent Svelte versions (5.41.1, 5.41.2, 5.41.4, 5.42.0, 5.42.1, 5.43.2, 5.43.3, 5.43.5) were repeatedly committed. Verify the Renovate configuration to ensure it is not specifying versions ahead of published releases.
Apply this diff to resolve:
- "svelte": "^5.43.6",
+ "svelte": "^5.43.5",Then run pnpm install to update the lockfile and verify the dependency resolves correctly.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "svelte": "^5.43.6", | |
| "svelte": "^5.43.5", |
🤖 Prompt for AI Agents
integrations/svelte-vite/package.json around line 12: the dependency specifies
"svelte": "^5.43.6" which does not exist on npm and will break installs; change
the version to "5.43.5" (or "^5.43.5" if you want caret behavior), save
package.json, run pnpm install to update the lockfile and verify the dependency
resolves, and inspect/update the Renovate configuration to stop pinning to
non-published future patch versions.
e960e68 to
7a5a8a3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
examples/angular/simple/package.json (1)
19-19: 🔴 Critical: zone.js 0.15.1 incompatible with Angular ^20.3.x (DUPLICATE OF PRIOR REVIEW).This issue was already flagged in the prior review. Angular 20.3.x declares a peer dependency on
zone.js ~0.14.x, making version 0.15.1 an invalid choice. This will causenpm installto fail with peer dependency resolution errors.Apply this diff to fix:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"This same correction is required across all other Angular example package.json files in this PR (e.g., examples/angular/pagination, examples/angular/query-options-from-a-service, etc.) to maintain consistency and prevent similar failures.
examples/angular/pagination/package.json (1)
19-19: 🔴 Critical: zone.js 0.15.1 incompatible with Angular ^20.3.x (DUPLICATE OF PRIOR REVIEW).This issue was already flagged in the prior review across multiple Angular examples. Angular 20.3.x declares a peer dependency on
zone.js ~0.14.x, making version 0.15.1 invalid. This will causenpm installpeer dependency resolution failures.Apply this diff to fix:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Ensure this correction is also applied to all other Angular example files in the PR.
examples/angular/query-options-from-a-service/package.json (1)
20-20: 🔴 Critical: zone.js 0.15.1 incompatible with Angular ^20.3.x (DUPLICATE OF PRIOR REVIEW).Angular 20.3.x requires zone.js ~0.14.x per peer dependency constraints. Version 0.15.1 will cause
npm installto fail.Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Apply this same fix to all other Angular example files in the PR.
integrations/solid-vite/package.json (1)
12-13: 🔴 Critical: vite and vite-plugin-solid belong in devDependencies (DUPLICATE OF PRIOR REVIEW).This structural issue was already flagged in a prior review. Vite and vite-plugin-solid are build-time tools and must not be in the production
dependenciessection. The vue-vite integration in this repository correctly demonstrates the pattern by placing vite and its plugin indevDependencies.Apply this diff to move build tools to devDependencies:
"dependencies": { "@tanstack/solid-query": "workspace:*", "@tanstack/solid-query-devtools": "workspace:*", "solid-js": "^1.9.10", - "vite": "^6.3.6", - "vite-plugin-solid": "^2.11.10" + }, + "devDependencies": { + "vite": "^6.3.6", + "vite-plugin-solid": "^2.11.10" }The same issue affects
integrations/react-vite/package.json, which should also have vite and @vitejs/plugin-react moved to devDependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/vue-query-devtools/package.json
- integrations/react-webpack-5/package.json
🚧 Files skipped from review as they are similar to previous changes (56)
- examples/react/react-router/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/react-query-devtools/package.json
- examples/vue/simple/package.json
- examples/angular/basic-persister/package.json
- examples/vue/dependent-queries/package.json
- packages/query-core/package.json
- examples/vue/2.6-basic/package.json
- packages/query-async-storage-persister/package.json
- integrations/react-vite/package.json
- integrations/react-next-15/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/vue/2.7-basic/package.json
- packages/vue-query/package.json
- packages/query-devtools/package.json
- examples/solid/simple/package.json
- examples/react/offline/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/ssr/package.json
- examples/vue/persister/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/simple/package.json
- examples/angular/router/package.json
- examples/react/chat/package.json
- examples/angular/devtools-panel/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/default-query-function/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/star-wars/package.json
- examples/react/basic/package.json
- examples/svelte/basic/package.json
- packages/solid-query/package.json
- examples/solid/astro/package.json
- examples/react/devtools-panel/package.json
- examples/angular/basic/package.json
- packages/solid-query-devtools/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/simple/package.json
- packages/react-query-persist-client/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/vue/nuxt3/package.json
- packages/svelte-query/package.json
- packages/query-test-utils/package.json
- examples/angular/rxjs/package.json
- examples/react/playground/package.json
- examples/react/shadow-dom/package.json
- integrations/react-webpack-4/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/playground/package.json
- examples/react/react-native/package.json
- packages/eslint-plugin-query/package.json
- packages/solid-query-persist-client/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/algolia/package.jsonpackages/react-query/package.jsonpackages/query-persist-client-core/package.jsonpackages/react-query-next-experimental/package.jsonexamples/solid/basic-graphql-request/package.jsonexamples/angular/simple/package.jsonexamples/react/eslint-legacy/package.jsonpackages/angular-query-experimental/package.jsonexamples/angular/optimistic-updates/package.jsonintegrations/svelte-vite/package.jsonpackage.jsonintegrations/solid-vite/package.jsonexamples/solid/basic/package.jsonexamples/angular/query-options-from-a-service/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/react-query/package.jsonexamples/solid/basic-graphql-request/package.jsonintegrations/solid-vite/package.jsonexamples/solid/basic/package.json
🔇 Additional comments (21)
packages/react-query-next-experimental/package.json (1)
61-61: Dependency updates are safe.Both version bumps are non-major updates consistent with the PR scope:
- @vitejs/plugin-react: ^4.3.4 → ^4.7.0 (minor bump)
- npm-run-all2: ^5.0.0 → ^5.0.2 (patch bump)
Also applies to: 63-63
integrations/vue-vite/package.json (1)
13-13: Dependency update is safe.Patch version bump for @vitejs/plugin-vue (^5.2.1 → ^5.2.4) is a non-major update consistent with the PR scope.
integrations/svelte-vite/package.json (1)
12-12: Svelte version is now valid—past flagged issues have been resolved.Previous reviews flagged multiple non-existent Svelte versions (5.41.1, 5.41.2, 5.41.4, 5.42.0, 5.42.1, 5.43.2, 5.43.3, 5.43.5). Svelte 5.43.6 was published 15 hours ago, confirming this version now exists and is valid. The caret constraint ^5.43.6 can resolve correctly to a published release.
packages/react-query/package.json (1)
73-73: All devDependency updates are safe.Minor and patch version bumps consistent with PR scope:
- @testing-library/react: ^16.1.0 → ^16.3.0 (minor)
- @testing-library/react-render-stream: ^2.0.0 → ^2.0.2 (patch)
- @vitejs/plugin-react: ^4.3.4 → ^4.7.0 (minor)
- npm-run-all2: ^5.0.0 → ^5.0.2 (patch)
Also applies to: 74-74, 77-77, 79-79
packages/query-persist-client-core/package.json (1)
66-66: Dependency update is safe.Patch version bump for npm-run-all2 (^5.0.0 → ^5.0.2) is a non-major update consistent with the PR scope.
examples/solid/basic-graphql-request/package.json (1)
13-13: Dependency updates are valid—past flagged issues resolved.Previous reviews flagged graphql-request 7.3.1 as non-existent. graphql-request 7.3.3 is valid (latest version, published 20 hours ago). All dependency bumps are to legitimate, released versions:
- graphql: ^16.9.0 → ^16.12.0 (minor)
- graphql-request: ^7.1.2 → ^7.3.3 (valid, minor)
- solid-js: ^1.9.7 → ^1.9.10 (patch)
- vite-plugin-solid: ^2.11.6 → ^2.11.10 (patch)
Also applies to: 14-14, 15-15, 20-20
examples/vue/basic/package.json (1)
16-16: Dependency update is safe.Patch version bump for @vitejs/plugin-vue (^5.2.1 → ^5.2.4) is a non-major update consistent with the PR scope.
examples/angular/optimistic-updates/package.json (1)
12-16: No action needed—zone.js 0.15.1 is compatible with Angular 20.3.10.The peer dependency constraint for @angular/[email protected] is
~0.15.0, which permits any patch release from 0.15.0 to <0.16.0. Since zone.js 0.15.1 falls within this range, it satisfies the constraint and will not trigger peer dependency resolution errors. The previous review comment flagging incompatibility appears to be incorrect.examples/react/star-wars/package.json (2)
15-16: Dependency updates look good.The react-router and react-router-dom updates to ^6.30.1 are minor version increments and align with the broader React ecosystem updates in this PR.
19-21: Tailwind and Vite plugin updates approved.The Tailwind and Vite plugin updates to newer patch versions are safe and align with the repo-wide toolchain modernization.
packages/angular-query-experimental/package.json (1)
92-95: Angular and tooling updates approved.All devDependency updates are minor/patch increments and align with the repo's Angular upgrade from ^20.0.0 to ^20.3.10 along with supporting tool updates.
Also applies to: 97-101
package.json (3)
8-8: pnpm version bump approved.The packageManager update to [email protected] is a routine minor version increment.
43-68: DevDependency updates approved.All devDependency bumps are minor/patch increments for tooling, linting, testing, and build infrastructure. No compatibility issues evident.
72-79: TypeScript version aliases support multi-version testing.The addition of TypeScript version aliases (5.0 through 5.7) enables the package to test type compatibility across multiple TypeScript versions, which aligns with the package's test scripts (visible in angular-query-experimental and other packages that call these TypeScript versions).
examples/react/eslint-legacy/package.json (1)
23-23: @vitejs/plugin-react update approved.The Vite plugin update to ^4.7.0 is a minor version increment and aligns with updates across other React examples in the PR.
integrations/solid-vite/package.json (1)
11-11: solid-js and vite-plugin-solid version updates approved.The minor version increments for solid-js and vite-plugin-solid are routine and safe.
Also applies to: 13-13
examples/react/algolia/package.json (1)
21-21: @vitejs/plugin-react update aligns with other React examples.Consistent minor version bump across the React example suite.
examples/react/suspense/package.json (1)
19-19: Minor version update is standard and consistent.@vitejs/plugin-react bump to ^4.7.0 aligns across multiple React examples in this PR.
examples/react/rick-morty/package.json (1)
15-21: Coordinated framework and tooling updates are appropriate.react-router, tailwindcss, and plugin versions are bumped consistently and remain within their respective semver constraints. All updates are non-major as expected.
examples/solid/basic/package.json (1)
13-13: Patch-level framework and plugin updates.solid-js and vite-plugin-solid are updated within their patch ranges (1.9.10 and 2.11.10 respectively), representing minimal, low-risk increments.
Also applies to: 18-18
examples/react/default-query-function/package.json (1)
17-17: Consistent @vitejs/plugin-react update across React examples.Minor version bump aligns with the pattern applied to other React example packages in this PR.
| }, | ||
| "dependencies": { | ||
| "@algolia/client-search": "5.2.1", | ||
| "@algolia/client-search": "5.43.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify @algolia/client-search version availability.
The update from 5.2.1 → 5.43.0 is a significant minor version bump. Confirm this version exists on npm and has no known security issues.
🌐 Web query:
Is @algolia/client-search version 5.43.0 available on npm?
💡 Result:
No. The latest published @algolia/client-search on npm is 5.42.0 — version 5.43.0 is not available. [1][2]
Sources:
[1] Yarn package page for @algolia/client-search (shows 5.42.0 as latest).
[2] Package metadata listing / registry summary for @algolia/client-search.
Update @algolia/client-search to available version 5.42.0.
Version 5.43.0 is not published on npm; the latest available version is 5.42.0. Change line 11 from "@algolia/client-search": "5.43.0" to "@algolia/client-search": "5.42.0".
🤖 Prompt for AI Agents
In examples/react/algolia/package.json around line 11, the dependency
"@algolia/client-search" incorrectly references version "5.43.0" which is not
published; change the version string to "5.42.0" on that line and then run your
package manager (npm install or yarn) to update node_modules and the lockfile
accordingly.
0c8ac1e to
6f61aa1
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (7)
examples/angular/devtools-panel/package.json (1)
20-20: Verify [email protected] compatibility with [email protected].Same zone.js compatibility concern as examples/angular/router/package.json—confirm [email protected] supports [email protected] before merging.
examples/angular/router/package.json (1)
20-20: Fix zone.js peer dependency incompatibility with Angular 20.3.11.Angular 20.3.11 expects zone.js ~0.14.10, and zone.js 0.15.1 will produce a peer-dependency conflict. Downgrade zone.js to a compatible 0.14.x version (e.g., 0.14.10 or ~0.14.x).
- "zone.js": "0.15.1" + "zone.js": "~0.14.10"examples/vue/nuxt3/package.json (1)
13-13: 🔴 CRITICAL: Nuxt 3.20.1 does not exist.Version
^3.20.1has no official release as of November 2025. The latest Nuxt 3 stable release is v3.19. Update this to^3.19.xor a specific v3.19 patch version, then run pnpm install to verify lockfile resolution.packages/query-devtools/package.json (1)
76-76: 🔴 CRITICAL: solid-js 1.9.10 does not exist on npm.The latest 1.9.x release of solid-js as of October 31, 2025 is v1.9.9. Update this to
^1.9.9, then run pnpm install to verify lockfile resolution.examples/angular/rxjs/package.json (1)
20-20: 🔴 CRITICAL: zone.js 0.15.1 incompatible with Angular 20.3.x peer dependency.Angular 20.3.x declares a peer dependency on
zone.js ~0.14.x. Pinning to 0.15.1 violates this constraint and will causenpm installto fail with peer dependency resolution errors. Update to^0.14.2or a compatible 0.14.x version.examples/react/react-native/package.json (1)
19-29: 🔴 CRITICAL: React Native 0.82.1 ecosystem incompatibility—blocker for merge.The package version combination violates compatibility constraints and will fail
pnpm installand native builds:
- Expo SDK 52 (line 19) supports React Native 0.76 (default) and 0.77 (opt-in only)—not 0.82.
- React Native 0.82.1 (line 23) is not in a stable Expo SDK; available only in expo@canary releases.
- react-native-reanimated 3.19.4 (line 26) supports React Native 0.78–0.81 only, not 0.82.
Choose one remediation path before merging:
- Option A (recommended): Downgrade
react-nativeto^0.77.x(or^0.76.x), alignreact-native-reanimatedto a 3.x version compatible with that RN version.- Option B (full ecosystem upgrade): Upgrade
expoto SDK 54+ (supports RN 0.81), upgradereact-native-reanimatedto^4.1.x+, and verify all RN ecosystem packages are compatible.Then run
pnpm installand verify the example builds locally.examples/angular/auto-refetching/package.json (1)
19-19: 🔴 CRITICAL: zone.js 0.15.1 incompatible with Angular 20.3.x peer dependency.Angular 20.3.x declares a peer dependency on
zone.js ~0.14.x. Pinning to 0.15.1 violates this constraint and will causenpm installto fail with peer dependency resolution errors. Update to^0.14.2or a compatible 0.14.x version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/react/react-router/package.json
🚧 Files skipped from review as they are similar to previous changes (51)
- packages/solid-query-devtools/package.json
- examples/react/devtools-panel/package.json
- packages/react-query/package.json
- examples/react/eslint-legacy/package.json
- examples/react/algolia/package.json
- examples/react/basic/package.json
- packages/query-async-storage-persister/package.json
- examples/vue/simple/package.json
- packages/query-core/package.json
- packages/query-test-utils/package.json
- integrations/solid-vite/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/basic-persister/package.json
- integrations/react-vite/package.json
- packages/react-query-persist-client/package.json
- examples/solid/basic/package.json
- examples/react/chat/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/optimistic-updates/package.json
- examples/svelte/ssr/package.json
- packages/query-persist-client-core/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/playground/package.json
- examples/solid/astro/package.json
- examples/react/star-wars/package.json
- packages/svelte-query/package.json
- examples/react/basic-graphql-request/package.json
- integrations/vue-vite/package.json
- packages/react-query-devtools/package.json
- examples/angular/pagination/package.json
- examples/vue/basic/package.json
- examples/vue/persister/package.json
- examples/solid/simple/package.json
- examples/react/suspense/package.json
- examples/svelte/basic/package.json
- examples/angular/basic/package.json
- examples/react/offline/package.json
- packages/svelte-query-devtools/package.json
- packages/vue-query-devtools/package.json
- integrations/react-webpack-4/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/rick-morty/package.json
- examples/angular/simple/package.json
- packages/eslint-plugin-query/package.json
- examples/vue/2.7-basic/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/default-query-function/package.json
- examples/svelte/simple/package.json
- packages/angular-query-persist-client/package.json
- packages/angular-query-experimental/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
integrations/react-next-15/package.jsonpackages/query-sync-storage-persister/package.jsonexamples/angular/auto-refetching/package.jsonexamples/svelte/load-more-infinite-scroll/package.jsonexamples/solid/solid-start-streaming/package.jsonpackages/query-broadcast-client-experimental/package.jsonintegrations/svelte-vite/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/vue/nuxt3/package.jsonexamples/svelte/star-wars/package.jsonexamples/angular/router/package.jsonexamples/svelte/auto-refetching/package.jsonpackages/react-query-next-experimental/package.jsonpackages/vue-query/package.jsonexamples/solid/default-query-function/package.jsonpackages/solid-query/package.jsonexamples/angular/devtools-panel/package.jsonpackages/query-devtools/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
examples/solid/default-query-function/package.jsonpackages/solid-query/package.jsonpackages/query-devtools/package.json
🔇 Additional comments (22)
examples/react/simple/package.json (1)
17-17: Dependency version bumps look good.The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a safe minor-version bump. This aligns with coordinated updates across other React examples.
examples/vue/dependent-queries/package.json (1)
11-11: Dependency updates are safe.Both updates are safe within their version ranges: @vitejs/plugin-vue patch bump (^5.2.4) and @tanstack/vue-query minor bump (^5.91.0).
Also applies to: 15-15
packages/solid-query/package.json (1)
74-74: Solid ecosystem devDependencies updated safely.All three updates are patch-level bumps within their caret ranges: npm-run-all2 (^5.0.2), solid-js (^1.9.10), and vite-plugin-solid (^2.11.10). These are consistent across solid-query packages.
Also applies to: 75-75, 77-77
packages/react-query-next-experimental/package.json (1)
61-61: Build and test tooling updates are safe.Minor bump for @vitejs/plugin-react (^4.7.0) and patch bump for npm-run-all2 (^5.0.2) are both safe within their ranges.
Also applies to: 63-63
packages/query-sync-storage-persister/package.json (1)
67-67: npm-run-all2 patch update is safe.The patch bump to ^5.0.2 is consistent across the repository.
packages/svelte-query-persist-client/package.json (1)
55-55: Svelte ecosystem updates are all safe.These are coordinated Svelte 5 ecosystem updates: minor bumps for svelte (5.43.6), @sveltejs/package (^2.5.4), eslint-plugin-svelte (^3.13.0), and patch bumps for testing/linting tools. All are within caret ranges and consistent with broader PR updates.
Also applies to: 59-59, 60-60, 61-61, 62-62, 63-63
integrations/react-next-15/package.json (1)
9-9: Verify @js-temporal/polyfill 0.5.1 compatibility.The @js-temporal/polyfill bump from ^0.4.4 to ^0.5.1 is a minor version update. Since the Temporal API is still in development (Stage 3), minor version updates may include breaking changes. Verify this is compatible with the Next.js 15.3.1 / React 19 combination being used in this integration.
integrations/svelte-vite/package.json (1)
12-12: Svelte 5.43.6 update is valid.Svelte 5.43.6 is the latest version, last published 15 hours ago. This update is safe. (Note: Past review comments flagged this version as non-existent because it was created before this release; it is now valid and available on npm.)
packages/vue-query/package.json (1)
66-66: LGTM!Patch-level updates to minor dependencies with no compatibility concerns.
Also applies to: 73-73
integrations/react-webpack-5/package.json (1)
14-18: LGTM!Babel and webpack tooling patch updates are straightforward with no apparent compatibility concerns.
examples/react/shadow-dom/package.json (1)
19-19: LGTM!@vitejs/plugin-react minor version bump is reasonable and aligns with other React examples in the PR.
examples/react/playground/package.json (1)
17-17: Clean devDependency update.The @vitejs/plugin-react minor bump (4.3.4 → 4.7.0) is non-breaking and aligns with ecosystem-wide updates in this PR.
examples/vue/nuxt3/package.json (1)
10-10: Routine patch update.The @tanstack/vue-query patch bump (5.90.2 → 5.91.0) is safe and expected.
integrations/angular-cli-20/package.json (1)
11-26: Safe Angular ecosystem updates.Angular framework packages and related tooling bumped from 20.0.0 to 20.3.x; all supporting dependencies (rxjs, tslib, zone.js) updated to compatible patch/minor versions. These are non-breaking updates within the Angular 20.x range.
packages/query-devtools/package.json (1)
67-75: Safe devDependency updates.Kobalte, solid-primitives, npm-run-all2, goober, solid-transition-group, superjson, and vite-plugin-solid all receive routine minor or patch bumps within their safe ranges.
Also applies to: 77-80
examples/angular/rxjs/package.json (1)
12-16: Safe Angular version updates.Angular framework packages (20.0.0 → 20.3.11) and tooling (20.3.x) are non-breaking minor bumps.
Also applies to: 23-25
examples/angular/auto-refetching/package.json (1)
12-15: Safe Angular version updates.Angular framework packages (20.0.0 → 20.3.11) and tooling (20.3.x) are non-breaking minor bumps.
Also applies to: 22-24
packages/query-broadcast-client-experimental/package.json (1)
62-67: Clean dependency and devDependency updates.broadcast-channel (7.0.0 → 7.2.0), @testing-library/react, @vitejs/plugin-react, and npm-run-all2 receive safe minor or patch bumps. All updates are non-breaking and align with ecosystem-wide changes in this PR.
package.json (2)
83-110:pnpm.overridessection correctly preserves workspace dependencies.The internal
@tanstack/*packages remain pinned toworkspace:*, ensuring consistent dependency resolution across the monorepo. This is correct.
8-8: Vite 6.3.6 and Vitest 3.2.4 are confirmed compatible—this concern is resolved.Vitest 3.x supports Vite 6, with compatibility for
^6.0.0, so[email protected]satisfies the range. No technical conflicts exist between these versions.The remaining verification item is confirming whether the root-level
viteaddition was intentional (e.g., for a new root-level build tool) or an unintended transitive bump. Check the PR description or commits to confirm the addition's purpose.examples/solid/default-query-function/package.json (1)
13-13: Routine patch updates for Solid example.
solid-jsandvite-plugin-solidare updated to stable patch versions. No breaking changes expected.Also applies to: 18-18
examples/solid/solid-start-streaming/package.json (1)
13-14: Solid Start streaming example updates are straightforward.Updates to
@solidjs/router,@solidjs/start,solid-js, andvinxiare all within non-major version ranges (patch and minor bumps). No breaking changes expected.Also applies to: 17-18
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.48.4", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "svelte": "^5.43.6", | ||
| "svelte-check": "^4.3.4", |
There was a problem hiding this comment.
🧩 Analysis chain
🚨 Critical: Verify Svelte versions given file's documented history of invalid versions.
This file has a documented history across multiple reviews of committing non-existent Svelte versions (5.41.2, 5.41.4, 5.43.2, 5.43.3, 5.43.5 were all flagged). Verify that the current versions exist on npm before merging:
- @sveltejs/[email protected]
- @sveltejs/[email protected]
- [email protected]
- [email protected]
Do not merge without confirmation these versions are published on npm.
🌐 Web query:
What are the latest available versions of @sveltejs/adapter-auto, @sveltejs/kit, svelte, and svelte-check as of November 2025
💡 Result:
As of November 12, 2025:
- svelte: 5.38.7. (npmjs.com)
- @sveltejs/adapter-auto: 6.1.0. (npmjs.com)
- @sveltejs/kit: 2.37.0. (npmjs.com)
- svelte-check: 4.3.1. (npmjs.com)
If you want I can re-check each package (npm registry) now to confirm there haven't been releases since these sources were crawled.
Citations:
- 1: https://www.npmjs.com/package/svelte?utm_source=openai
- 2: https://www.npmjs.com/package/%40sveltejs/adapter-auto?utm_source=openai
- 3: https://www.npmjs.com/package/%40sveltejs/kit?utm_source=openai
- 4: https://www.npmjs.com/package/svelte-check?utm_source=openai
Fix all invalid Svelte package versions—none exist on npm.
Verification against npm registry (Nov 12, 2025) confirms ALL versions in this file are invalid:
- [email protected] → latest is 5.38.7
- @sveltejs/[email protected] → latest is 6.1.0
- @sveltejs/[email protected] → latest is 2.37.0
- [email protected] → latest is 4.3.1
Update to valid versions immediately. npm install will fail with current versions.
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around lines 15 to 19,
the pinned Svelte-related package versions are invalid and will cause npm
install to fail; update the dependency versions to the valid releases (svelte ->
5.38.7, @sveltejs/adapter-auto -> 6.1.0, @sveltejs/kit -> 2.37.0, svelte-check
-> 4.3.1) and run npm install to verify; ensure package.json uses these exact
versions (or use caret ranges if you want minor/patch updates) and commit the
change.
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.48.4", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "@tailwindcss/vite": "^4.1.13", | ||
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "tailwindcss": "^4.1.13", | ||
| "@tailwindcss/vite": "^4.1.17", | ||
| "svelte": "^5.43.6", | ||
| "svelte-check": "^4.3.4", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify @sveltejs/adapter-auto version.
A past review flagged that @sveltejs/[email protected] does not exist (latest was 7.0.0). Confirm the current specification is valid before merging, and verify all Svelte package versions on npm.
🌐 Web query:
What is the latest available version of @sveltejs/adapter-auto on npm
💡 Result:
The latest published version is 7.0.0 (published Oct 16, 2025). [1][2]
Sources:
[1] Yarn package page for @sveltejs/adapter-auto. [2] Snyk package info for @sveltejs/adapter-auto.
I need to verify whether version 6.1.1 actually exists. The web search confirms 7.0.0 is latest, but I need to check the version history.
Update @sveltejs/adapter-auto to an available version.
Version 6.1.0 exists, but 6.1.1 does not. The caret range ^6.1.1 will fail during npm install. Update to either ^6.1.0 or ^7.0.0 (latest, published Oct 16, 2025).
🤖 Prompt for AI Agents
In examples/svelte/star-wars/package.json around lines 15 to 20 the dependency
"@sveltejs/adapter-auto": "^6.1.1" references a non-existent patch release;
update that entry to a published version to avoid npm install failures — change
it to either "^6.1.0" (the existing 6.x release) or "^7.0.0" (the latest
stable), ensuring package.json's dependency string is replaced accordingly and
run npm install to verify resolution.
6f61aa1 to
0f7d68b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
integrations/react-vite/package.json (1)
8-15: Critical: Vite and plugin remain in production dependencies — issue still unresolved.This is a repeat of a previous critical finding (flagged as "Addressed in commits 7783a7a to 4498005"). However,
viteand@vitejs/plugin-reactare still incorrectly classified in thedependenciessection. These are build-time tools only and must be moved todevDependencies. Keeping them independenciesbloats the production bundle and violates dependency classification best practices.Apply this diff to move the build tools to a dedicated
devDependenciessection:"dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", "react": "^19.0.0", - "react-dom": "^19.0.0", + "react-dom": "^19.0.0" + }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", "vite": "^6.3.6" }examples/svelte/star-wars/package.json (1)
15-15: @sveltejs/[email protected] does not exist—critical blocker.Version 6.1.1 is not a published release on npm. The latest in the 6.x line is 6.1.0; the overall latest is 7.0.0 (published Oct 16, 2025). This will fail
npm install. This issue was previously flagged and remains unresolved.Apply this diff to use an available version:
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^7.0.0",Alternatively, if staying on the 6.x line is intentional, use:
- "@sveltejs/adapter-auto": "^6.1.1", + "@sveltejs/adapter-auto": "^6.1.0",examples/angular/pagination/package.json (1)
19-19: 🔴 zone.js 0.15.1 is incompatible with Angular ^20.3.x peer dependencies—remains unresolved from previous review.Angular ^20.3.11 requires
zone.js ~0.14.xper peer dependency constraints. Version 0.15.1 will cause npm install to fail. This issue was flagged in previous reviews and still needs correction.Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"This fix must be applied consistently across all Angular example package.json files in this PR (examples/angular/auto-refetching, basic, devtools-panel, infinite-query-with-max-pages, optimistic-updates, query-options-from-a-service, router, rxjs, simple) to prevent peer dependency resolution failures in all examples.
examples/angular/query-options-from-a-service/package.json (1)
20-20: 🔴 zone.js 0.15.1 incompatible with Angular ^20.3.x—previously flagged, still unresolved.Same issue as other Angular examples: zone.js 0.15.1 violates Angular ^20.3.11's peer dependency requirement for
~0.14.x. This will break npm install.Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"examples/angular/infinite-query-with-max-pages/package.json (1)
19-19: 🔴 zone.js 0.15.1 incompatible with Angular ^20.3.x—same issue flagged in previous reviews.Angular ^20.3.11 requires zone.js ~0.14.x. Version 0.15.1 is out of range and will cause peer dependency resolution failures during npm install.
Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"examples/angular/rxjs/package.json (1)
20-20: 🔴 zone.js 0.15.1 incompatible with Angular ^20.3.x—blocking issue in all Angular examples.Angular ^20.3.11's peer dependency requires zone.js ~0.14.x. Pinning to 0.15.1 breaks npm install. This same issue appears in all 4 Angular example files under review and was previously flagged.
Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Consistency requirement: All Angular examples must use the same compatible zone.js version to ensure uniform installation behavior across the codebase.
examples/react/react-native/package.json (1)
19-19: 🔴 Regression: Critical incompatibility re-introduced despite prior flagging.This exact version combination has been flagged as a critical blocker in all 4 prior reviews. The issue persists unchanged:
- Expo SDK 52 (line 19) supports React Native 0.76–0.77 only.
- [email protected] (line 23) is incompatible with Expo SDK 52.
- [email protected] (line 26) supports RN 0.78–0.81 only; RN 0.82 requires Reanimated 4.1+.
These constraints cannot be simultaneously satisfied. Dependency resolution will fail during
pnpm install, and native builds will break.Prior reviews provided three remediation options:
- Option A: Downgrade
react-nativeto^0.77.x(or^0.76.x); alignreact-native-reanimatedand related packages to compatible versions.- Option B: Upgrade
expoto SDK 54+ (for RN 0.81) or SDK 55+ (for RN 0.83); upgradereact-native-reanimatedto v4.1+.Please confirm which remediation path you intend to apply before merge, then run
pnpm installlocally to verify the example builds successfully.Also applies to: 23-23, 26-26
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (53)
- examples/vue/persister/package.json
- examples/vue/2.6-basic/package.json
- examples/react/chat/package.json
- examples/solid/default-query-function/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/react-router/package.json
- packages/angular-query-experimental/package.json
- examples/react/simple/package.json
- packages/react-query/package.json
- packages/svelte-query-persist-client/package.json
- integrations/vue-vite/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/simple/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/svelte-query/package.json
- packages/query-persist-client-core/package.json
- integrations/react-next-15/package.json
- examples/react/basic-graphql-request/package.json
- examples/vue/nuxt3/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/basic-persister/package.json
- examples/react/algolia/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/basic/package.json
- examples/angular/auto-refetching/package.json
- packages/solid-query-devtools/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/basic/package.json
- examples/react/suspense/package.json
- examples/react/rick-morty/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/simple/package.json
- packages/svelte-query-devtools/package.json
- examples/react/playground/package.json
- examples/react/shadow-dom/package.json
- examples/vue/2.7-basic/package.json
- integrations/solid-vite/package.json
- packages/solid-query/package.json
- examples/svelte/playground/package.json
- packages/query-devtools/package.json
- packages/query-test-utils/package.json
- examples/angular/devtools-panel/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/angular-cli-20/package.json
- examples/angular/simple/package.json
- examples/angular/optimistic-updates/package.json
- examples/vue/dependent-queries/package.json
- packages/react-query-persist-client/package.json
- examples/angular/router/package.json
- examples/vue/simple/package.json
- integrations/svelte-vite/package.json
- packages/angular-query-persist-client/package.json
- package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-persist-client/package.jsonexamples/solid/basic/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/astro/package.json
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonexamples/solid/basic/package.jsonintegrations/react-vite/package.jsonexamples/solid/basic-graphql-request/package.jsonexamples/react/basic/package.jsonpackages/react-query-devtools/package.jsonexamples/react/offline/package.jsonpackages/vue-query/package.jsonpackages/query-async-storage-persister/package.jsonexamples/angular/query-options-from-a-service/package.jsonexamples/svelte/ssr/package.jsonexamples/svelte/star-wars/package.jsonpackages/query-core/package.jsonexamples/solid/astro/package.jsonpackages/vue-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (24)
examples/vue/basic/package.json (1)
16-16: Approved: patch-level dependency update.The
@vitejs/plugin-vuebump from^5.2.1to^5.2.4is a safe, patch-level update that aligns with similar updates across other Vue examples in the repository. Patch releases are typically backward compatible and contain bug fixes only.packages/eslint-plugin-query/package.json (1)
62-69: Dependency updates look good; all non-major version bumps.The five dependency updates (three @typescript-eslint packages, eslint, and npm-run-all2) are all patch or minor versions within their respective caret ranges. The three TypeScript-ESLint packages are updated in lockstep (^8.44.1 → ^8.46.4), which maintains consistency. The eslint bump (^9.36.0 → ^9.39.1) satisfies the peer dependency range (^8.57.0 || ^9.0.0).
Since Renovate's built-in dependency resolution validates compatibility, these updates should integrate without issues.
packages/vue-query-devtools/package.json (1)
58-58: Patch update to eslint-plugin-vue looks good.The bump from ^10.5.0 to ^10.5.1 is a patch-level update within the semver range already specified by the caret operator, so it's a safe, compatible update. No concerns here.
packages/vue-query/package.json (2)
66-66: Patch update to @vue/devtools-api is safe.The bump from ^6.6.3 to ^6.6.4 is a patch-level update within the semver range already specified. This is a low-risk maintenance update.
73-73: Patch update to eslint-plugin-vue is consistent and safe.The bump from ^10.5.0 to ^10.5.1 mirrors the update in packages/vue-query-devtools/package.json, indicating a coordinated dependency refresh across the monorepo. This patch-level update is within the semver range and poses no compatibility risk.
examples/svelte/star-wars/package.json (1)
16-21: Remaining devDependency updates look good once adapter-auto is fixed.The other version bumps (@sveltejs/kit, svelte, svelte-check, tailwindcss, @tailwindcss/vite) are reasonable non-major updates aligned with the PR objectives. These will be acceptable once the critical @sveltejs/adapter-auto issue is resolved.
integrations/react-webpack-4/package.json (1)
14-21: Dependency updates look good; React 19 config changes already addressed.The Babel and webpack-cli version bumps are safe non-major upgrades within compatible ranges. A past review flagged that webpack.config.js must use React 19's new JSX transform (runtime: "automatic"); per the earlier feedback, this was already addressed in commit eef0820.
examples/solid/basic/package.json (1)
13-13: Dependency version updates look good.The updates to solid-js (^1.9.10) and vite-plugin-solid (^2.11.10) are consistent with coordinated Solid ecosystem updates across the example projects in this PR. These are routine patch/minor version bumps.
Also applies to: 18-18
examples/solid/basic-graphql-request/package.json (1)
13-13: No issues found; all dependency versions are valid and up-to-date.Both graphql (^16.12.0) and graphql-request (^7.3.3) exist on npm and are currently the latest versions. The package versions in the PR are safe and will resolve correctly during installation.
examples/svelte/ssr/package.json (2)
15-15: Original review comment is incorrect—@sveltejs/adapter-auto 6.1.1 exists in npm registry.The version
^6.1.1specified on line 15 is valid and will not causenpm installto fail. Version 6.1.1 is a published release. No changes are required.Likely an incorrect or invalid review comment.
16-19: All requested package versions verified as valid.The npm registry confirms that @sveltejs/[email protected], [email protected], and [email protected] are all published versions. The specified versions on lines 16, 18, and 19 are correct and ready for merge.
examples/solid/astro/package.json (1)
13-23: ****The original review comment is based on incorrect peer dependency information. @astrojs/[email protected] requires astro: '^5.3.0', not '^5.14.3' as claimed. Since the package.json specifies astro@^5.5.6, which satisfies '^5.3.0', the versions are compatible. No update is required.
Likely an incorrect or invalid review comment.
integrations/react-webpack-5/package.json (2)
18-18: Verify html-webpack-plugin 5.6.4 release.The html-webpack-plugin patch bump (5.6.3 → 5.6.4) appears safe but should be confirmed as a legitimate release.
14-16: Dependency versions verified and compatible.All Babel 7.28.5 packages and html-webpack-plugin 5.6.4 exist on npm, and Babel 7.28.5 is compatible with React 19 for standard JSX transpilation. The version bumps are within safe semver ranges and pose no compatibility issues.
examples/react/devtools-panel/package.json (1)
17-17: Minor devDependency update—approve.@vitejs/plugin-react updated from ^4.3.4 to ^4.7.0 is a non-breaking minor bump within the ^4 range and consistent with updates across other React examples in the PR.
examples/react/basic/package.json (1)
23-23: Minor devDependency update—approve.@vitejs/plugin-react updated from ^4.3.4 to ^4.7.0 is a non-breaking minor bump and consistent with other React examples in the PR.
examples/react/default-query-function/package.json (1)
17-17: Minor devDependency update—approve.@vitejs/plugin-react updated from ^4.3.4 to ^4.7.0 is a non-breaking minor bump and consistent with other React examples in the PR.
examples/react/star-wars/package.json (3)
20-20: Minor devDependency update—approve.@vitejs/plugin-react updated from ^4.3.4 to ^4.7.0 is a non-breaking minor bump and consistent with other React examples in the PR.
15-16: react-router 6.30.1 is compatible with React 19.0.0—no changes needed.The packages' peer dependency for react-dom is an open range (>=16.8) and React Router docs state the project provides a "bridge to React 19", confirming compatibility with your dependency stack. The minor version bumps (6.25.1 → 6.30.1 for both react-router and react-router-dom) are safe within the v6 range with no breaking changes expected.
19-21: No issues found — package versions are compatible.@tailwindcss/[email protected] is the official Vite plugin for Tailwind CSS v4 and is intended to be used with [email protected]. The plugin has a strict peer dependency on Vite (^5.2.0 || ^6), which is satisfied by Vite 6.3.6. The specified versions are compatible and ready to use.
examples/react/offline/package.json (1)
16-22: All dependency updates are safe; no changes required.MSW 2.6.6 → 2.12.1 is verified safe: the codebase already uses correct v2.x imports (
msw/browser) and modern handler signatures (HttpResponse.json()), and v2.12.1 is a bugfix release with no new breaking API changes. The react-hot-toast (2.5.2 → 2.6.0) and @vitejs/plugin-react (4.3.4 → 4.7.0) updates are standard minor bumps. As a best practice, consider runningmsw initpost-upgrade to regenerate the service worker, but the current v2.1.7 file remains compatible.packages/query-async-storage-persister/package.json (1)
67-67: Patch version bump is safe.The npm-run-all2 patch update (^5.0.0 → ^5.0.2) is a low-risk change that maintains compatibility with the existing
npm-run-all --serialusage in line 21.packages/query-core/package.json (1)
63-63: Consistent patch bump across core package.The npm-run-all2 patch update aligns with the update in other packages and maintains compatibility with the TypeScript version testing workflow (lines 21–30).
packages/solid-query-persist-client/package.json (1)
73-76: Coordinated Solid.js ecosystem patch updates.The npm-run-all2, solid-js, and vite-plugin-solid patch bumps are consistent with updates across other Solid packages and maintain compatibility with the peerDependency constraint (line 80: solid-js ^1.6.0).
| "devDependencies": { | ||
| "@tanstack/react-query": "workspace:*", | ||
| "@testing-library/react": "^16.1.0", | ||
| "@testing-library/react": "^16.3.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify @testing-library/react and @vitejs/plugin-react for breaking changes.
The updates to @testing-library/react (^16.3.0) and @vitejs/plugin-react (^4.7.0) appear to be potentially major version bumps. The AI summary doesn't specify the previous versions for these packages, making it difficult to assess compatibility. The npm-run-all2 patch update is safe and consistent across the monorepo.
Can you confirm:
- What were the previous versions of @testing-library/react and @vitejs/plugin-react?
- Do these represent major version bumps (breaking changes) or routine patches/minor updates?
- Have any tests been run to ensure compatibility with react ^19.0.0?
Additionally, verify using web search if there are any known breaking changes in:
Also applies to: 88-88, 89-89
🌐 Web query:
@testing-library/react version 16 breaking changes migration guide
💡 Result:
Summary — main breaking change in @testing-library/react v16
- @testing-library/dom (and @types/react-dom for TypeScript users) were moved from a dependency to peerDependencies — you must explicitly install the compatible packages in your project. [1][2]
Quick migration steps
- Install the peer dependency:
- JavaScript:
npm install --save-dev @testing-library/dom
(or yarn add -D @testing-library/dom). [1][2]
- JavaScript:
- If you use TypeScript, also install the types for react-dom:
npm install --save-dev @types/react-dom
(only required if you typecheck files using @testing-library/react). [1][2] - Ensure versions are compatible with your @testing-library/react release (match major / minor where needed). If you use @testing-library/user-event, keep its version compatible with @testing-library/dom to avoid runtime mismatches. [1]
- Run your test suite and fix any remaining test failures (no other breaking API changes are called out in the v16 release notes). [1][2]
Sources
- Release notes for @testing-library/react v16.0.0. [1]
- NPM / release listing for @testing-library/react v16.0.0. [2]
🏁 Script executed:
#!/bin/bash
# Check the current package.json in packages/react-query-devtools for peer dependencies
cat packages/react-query-devtools/package.json | jq '.devDependencies, .dependencies, .peerDependencies'Length of output: 316
🏁 Script executed:
#!/bin/bash
# Search for @testing-library/dom and @types/react-dom in the package.json
rg -n '@testing-library/dom|@types/react-dom' packages/react-query-devtools/package.jsonLength of output: 0
🏁 Script executed:
#!/bin/bash
# Check git history to see what the previous versions were (if available)
git log -1 --pretty=format:"%H %s" -- packages/react-query-devtools/package.jsonLength of output: 87
🌐 Web query:
@vitejs/plugin-react version 4 breaking changes
💡 Result:
Key breaking changes in @vitejs/plugin-react v4 (summary):
-
include/exclude behavior changed: the plugin’s include/exclude now fully override which files are processed (file-extension based filtering + query-param fallback removed). This lets you explicitly target e.g. .mdx for Fast Refresh but can exclude files you previously relied on being matched implicitly. [1]
-
jsxRuntime classic-runtime auto-import removed: support that automatically injected classic JSX runtime imports when using the classic runtime was dropped — automatic runtime (new JSX runtime) is expected. If you rely on that injection you must add imports/adjust config. [1]
-
Plugin repository/packaging moved out of Vite core as part of Vite 4 ecosystem changes (plugin maintained separately); related Vite 4 changes (Node and Rollup targets) may affect plugin behavior in some projects. [2][3]
Migration tips:
- If you customized include/exclude, explicitly update them to cover all file types you need (e.g. /.(mdx|js|jsx|ts|tsx)$/). [1]
- Ensure your JSX runtime usage matches the new expectations (add explicit imports or switch to automatic runtime). [1]
- Check Vite 4 migration notes for broader environment changes (Node version, Rollup changes) that can impact plugin behavior. [2][3]
Sources:
[1] plugin-react v4 release/notes.
[2] Vite 4 announcement / blog.
[3] Vite migration docs (Vite 4 → Vite 5 / Rollup/Node changes).
🏁 Script executed:
#!/bin/bash
# Find and check vite config files in the project
fd -e vite.config.ts -e vite.config.js -e vite.config.mjsLength of output: 0
🏁 Script executed:
#!/bin/bash
# Check if @testing-library/dom or @types/react-dom are installed in root package.json
grep -E '@testing-library/dom|@types/react-dom' package.json || echo "Not found in root"Length of output: 70
---
🏁 Script executed:
```shell
#!/bin/bash
# Check root package.json for @testing-library/dom
grep -n '@testing-library/dom' package.json || echo "Not found in root package.json"
Length of output: 30
Add @testing-library/dom to packages/react-query-devtools/package.json — @testing-library/react v16 migration requires it.
@testing-library/react v16 moved @testing-library/dom from dependencies to peerDependencies, requiring explicit installation. The package is currently missing from both packages/react-query-devtools/package.json and the root package.json, which will cause test failures or runtime errors.
Additionally, @vitejs/plugin-react v4 includes breaking changes: include/exclude behavior changed and classic JSX runtime auto-import was removed. Verify your vite configuration handles these changes.
Required actions:
- Add
"@testing-library/dom": "^16.x.x"to packages/react-query-devtools/package.json devDependencies - If using TypeScript, ensure
@types/react-domis compatible (root has ^19.0.2) - Verify vite config (if present) explicitly defines include/exclude and JSX runtime settings for v4 compatibility
🤖 Prompt for AI Agents
In packages/react-query-devtools/package.json around line 86, tests may fail
because @testing-library/react v16 moved @testing-library/dom to a
peerDependency but it's not declared; add "@testing-library/dom": "^16.x.x" to
this package's devDependencies. Also ensure TypeScript setups are compatible by
verifying @types/react-dom version (root has ^19.0.2) and, if this package uses
Vite, update vite config to explicitly set include/exclude and configure the JSX
runtime to match @vitejs/plugin-react v4 breaking changes.
0f7d68b to
9c4e99e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
examples/angular/pagination/package.json (1)
12-24: Duplicate: zone.js 0.15.1 incompatible with Angular 20.3.x peer dependencies.This critical issue was already flagged in a past review. Angular 20.3.x requires zone.js ~0.14.x; version 0.15.1 will cause npm install failures.
examples/angular/devtools-panel/package.json (1)
20-20: 🔴 zone.js 0.15.1 incompatible with Angular 20.3.11.This issue was previously flagged and appears across multiple Angular example files in this PR. Angular 20.3.11 requires zone.js ~0.14.x per peer dependency constraints. Version 0.15.1 will fail during npm install with peer dependency resolution errors.
Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"This same correction must be applied to all other Angular example package.json files in this PR (examples/angular/auto-refetching, basic, pagination, router, etc.).
Also applies to: 20-20
packages/query-devtools/package.json (1)
76-76: 🔴 solid-js 1.9.10 does not exist on npm.This issue was flagged in prior reviews of this PR. The latest npm version of solid-js as of October 31, 2025 is 1.9.9. Version 1.9.10 cannot be resolved and will cause npm/pnpm install to fail.
Apply this diff:
- "solid-js": "^1.9.10" + "solid-js": "^1.9.9"Also applies to: 76-76
examples/angular/auto-refetching/package.json (1)
19-19: 🔴 zone.js 0.15.1 incompatible with Angular 20.3.11.Same critical issue as examples/angular/devtools-panel and other Angular examples. Angular 20.3.11 requires zone.js ~0.14.x per peer dependency constraints. Version 0.15.1 will fail npm install with peer dependency resolution errors.
Apply this diff:
- "zone.js": "0.15.1" + "zone.js": "^0.14.2"Apply this correction to all Angular example package.json files in the PR.
Also applies to: 19-19
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (64)
- packages/solid-query-persist-client/package.json
- examples/solid/simple/package.json
- examples/vue/2.7-basic/package.json
- examples/vue/simple/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/chat/package.json
- packages/react-query-persist-client/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/solid-query/package.json
- integrations/react-webpack-5/package.json
- packages/eslint-plugin-query/package.json
- examples/react/simple/package.json
- examples/react/devtools-panel/package.json
- integrations/react-vite/package.json
- examples/angular/router/package.json
- examples/angular/simple/package.json
- examples/react/eslint-legacy/package.json
- examples/react/basic/package.json
- integrations/svelte-vite/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/query-core/package.json
- examples/solid/astro/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/star-wars/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/react-query/package.json
- examples/vue/nuxt3/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/basic/package.json
- examples/react/react-router/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/playground/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/simple/package.json
- examples/react/offline/package.json
- integrations/vue-vite/package.json
- packages/query-test-utils/package.json
- integrations/react-webpack-4/package.json
- examples/angular/basic-persister/package.json
- integrations/solid-vite/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/rick-morty/package.json
- examples/svelte/ssr/package.json
- packages/vue-query/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-persist-client/package.json
- packages/angular-query-experimental/package.json
- examples/react/basic-graphql-request/package.json
- integrations/angular-cli-20/package.json
- packages/svelte-query/package.json
- packages/query-persist-client-core/package.json
- examples/react/algolia/package.json
- examples/react/suspense/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-devtools/package.json
- examples/vue/basic/package.json
- examples/react/default-query-function/package.json
- examples/vue/2.6-basic/package.json
- examples/react/react-native/package.json
- examples/react/playground/package.json
- examples/solid/basic/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/vue/dependent-queries/package.jsonintegrations/react-next-15/package.jsonexamples/solid/default-query-function/package.jsonpackages/solid-query-devtools/package.jsonexamples/angular/devtools-panel/package.jsonexamples/vue/persister/package.jsonexamples/angular/auto-refetching/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/react-query-next-experimental/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-devtools/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
examples/solid/default-query-function/package.jsonpackages/solid-query-devtools/package.jsonpackages/query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (11)
packages/vue-query-devtools/package.json (1)
58-58: Patch version bump for eslint-plugin-vue is safe.examples/vue/dependent-queries/package.json (1)
15-15: Patch version bump for @vitejs/plugin-vue is safe.examples/solid/default-query-function/package.json (1)
13-13: Minor/patch version bumps for Solid ecosystem tools are safe.Also applies to: 18-18
packages/solid-query-devtools/package.json (1)
71-72: Patch/minor version bumps for dev tools are safe.Also applies to: 74-74
packages/query-sync-storage-persister/package.json (1)
67-67: Patch version bump for npm-run-all2 is safe.examples/react/shadow-dom/package.json (1)
19-19: Minor version bump for @vitejs/plugin-react is safe.examples/vue/persister/package.json (1)
15-15: LGTM!Patch-level updates (idb-keyval ^6.2.2, @vitejs/plugin-vue ^5.2.4) are safe and consistent with other Vue examples in the PR.
Also applies to: 19-19
examples/react/star-wars/package.json (1)
15-16: LGTM!React Router and Tailwind/Vite plugin updates are all within safe caret ranges (minor/patch increments). Consistent with other React examples in the PR.
Also applies to: 19-21
packages/react-query-next-experimental/package.json (1)
61-61: LGTM!Patch/minor updates (@vitejs/plugin-react ^4.7.0, npm-run-all2 ^5.0.2) are safe and maintain consistency across the monorepo.
Also applies to: 63-63
package.json (2)
8-8: LGTM!Package manager bump to pnpm 10.22.0 (patch update) is safe and follows the standard maintenance release pattern.
Also applies to: 8-8
43-81: LGTM!DevDependency updates use safe caret/tilde versioning. TypeScript version aliases (typescript50–typescript57) are a standard multi-version testing pattern for monorepos. The vite entry point addition at ^6.3.6 aligns with build tooling consistency.
| }, | ||
| "dependencies": { | ||
| "@js-temporal/polyfill": "^0.4.4", | ||
| "@js-temporal/polyfill": "^0.5.1", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify @js-temporal/polyfill 0.5.1 compatibility with Next.js 15 and React 19.
The bump from ^0.4.4 to ^0.5.1 spans a minor version boundary. While Renovate flags it as non-major, confirm that this polyfill version aligns with the temporal API usage in your Next.js 15 integration and doesn't introduce breaking changes.
🌐 Web query:
What are the breaking changes or notable updates in @js-temporal/polyfill version 0.5.0 and 0.5.1?
💡 Result:
Summary — notable changes in @js-temporal/polyfill
0.5.0
- Major breaking release: implements the TC39 Temporal proposal changes adopted between May 2023 and March 2025 (many user‑visible/shape changes to the API). The release notes call it a breaking update and point to a migration guide for 0.4.x → 0.5.0. [1][2]
- Motivated largely by the June 2024 TC39 meeting where the scope of Temporal was reduced to address engine bundle‑size concerns. [1]
0.5.1
- Bug fixes: fixes an infinite recursion issue on Node 23.x with Intl.DurationFormat, includes correct package-lock.json, and avoids overriding TIMEOUT in test runs. [1]
- Non‑breaking updates: adds CI/test support for Node 22.x and 23.x; polyfilled Intl.DateTimeFormat now supports offset time zone identifiers (e.g., "-02:30") in Node 23.x; adds a migration guide for 0.4.x → 0.5.0; reduces production bundle size by removing assertions and minifying function names. [1]
Sources
- Release / version notes (yarn/npm listing). [1]
- Project changelog / repo notes mentioning v0.5 migration guidance. [2]
@js-temporal/polyfill 0.5.0 is a breaking release—verify and update temporal API usage.
The bump from 0.4.4 to 0.5.1 crosses a major breaking change: 0.5.0 implements TC39 Temporal proposal changes adopted between May 2023 and March 2025 with many user-visible API shape changes. A migration guide is available for 0.4.x → 0.5.0.
Review the migration guide and ensure the temporal API usage in this integration aligns with the 0.5.x API. Test the integration against the new polyfill to confirm compatibility.
This PR contains the following updates:
5.2.1->5.43.0^20.0.0->^20.3.11^20.0.0->^20.3.10^20.0.0->^20.3.10^20.0.0->^20.3.11^20.0.0->^20.3.11^20.0.0->^20.3.11^20.0.0->^20.3.11^20.0.0->^20.3.11^20.0.0->^20.3.11^20.0.0->^20.3.11^0.15.3->^0.18.2^0.9.4->^0.9.5^5.0.7->^5.1.3^8.1.3->^8.2.11^7.26.0->^7.28.5^7.24.9->^7.28.5^7.26.0->^7.28.5^7.25.9->^7.28.5^2.29.5->^2.29.7^9.2.1->^9.3.1^2.0.1->^2.3.5^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^1.2.2->^1.5.2^2.0.26->^2.1.3^0.15.3->^0.15.4^1.1.3->^1.2.0^6.1.0->^6.1.1^2.42.2->^2.48.4^2.4.0->^2.5.4^4.1.13->^4.1.17^4.0.14->^4.1.17^0.20.2->^0.22.0^5.90.2->^5.91.0^18.0.0->^18.1.1^10.4.0->^10.4.1^6.8.0->^6.9.1^16.1.0->^16.3.0^2.0.0->^2.0.2^5.2.8->^5.2.9^5.0.4->^5.0.6^8.44.1->^8.46.4^8.44.1->^8.46.4^8.44.1->^8.46.4^4.3.4->^4.7.0^5.2.1->^5.2.4^1.1.36->^1.4.2^6.6.3->^6.6.4^8.3.0->^8.4.1^7.0.0->^7.2.0^9.36.0->^9.39.1^50.5.0->^50.8.0^3.11.0->^3.13.0^10.5.0->^10.5.1^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^2.1.16->^2.1.18^16.9.0->^16.12.0^7.1.2->^7.3.3^5.6.3->^5.6.4^6.2.1->^6.2.2^27.0.0->^27.2.0^5.63.1->^5.69.1^2.6.6->^2.12.1^5.0.0->^5.0.2^3.12.4->^3.20.121.5.3->21.6.810.17.0->10.22.0^0.3.13->^0.3.15^2.5.2->^2.6.0^0.76.3->^0.82.1^2.20.2->^2.29.1^5.12.5->^5.14.5^3.16.2->^3.19.4^4.12.0->^4.14.1^4.1.0->^4.18.0^0.19.13->^0.21.2^6.25.1->^6.30.1^6.25.1->^6.30.1^8.0.0->^8.4.0~7.8.0->~7.8.2^1.6.1->^1.8.0^1.9.7->^1.9.10^0.2.3->^0.3.0^2.2.2->^2.2.5^5.39.3->^5.43.6^4.3.1->^4.3.4^4.1.13->^4.1.17^3.4.7->^3.4.18^4.0.14->^4.1.17^2.3.0->^2.8.1^0.5.3->^0.5.84.2.3->4.5.4^0.9.0->^0.10.0^2.11.6->^2.11.10~0.15.0->~0.15.10.15.0->0.15.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
algolia/algoliasearch-client-javascript (@algolia/client-search)
v5.43.0Compare Source
v5.42.0Compare Source
facetsquery parameter in Composition API (#5477) by @ClaraMullerv5.41.0Compare Source
facetsquery parameter available at run time (#5486) by @ClaraMullerConfiguration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit