gpl: include endcaps as fixed objects in placement #8549
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 5, 2025
Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
gadfort
reviewed
Oct 5, 2025
| for (dbInst* db_inst : db_insts) { | ||
| auto type = db_inst->getMaster()->getType(); | ||
| if (!type.isCore() && !type.isBlock()) { | ||
| if (!type.isCore() && !type.isBlock() && !type.isEndCap()) { |
There was a problem hiding this comment.
this includes PAD corner cells, will that cause an issue?
There was a problem hiding this comment.
We exclude anything outside the core area.
There was a problem hiding this comment.
The reason I ask is that the corner outlines can extend into the core in some processes.
There was a problem hiding this comment.
Do they then block those sites?
There was a problem hiding this comment.
no they don't, but they appear to because their bounding box can be fairly large.
There was a problem hiding this comment.
They have a bounding box that exceeds their true size? Do you have an image you could share?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.