test/orfs/mock-array: check for read_spef warnings in OpenSTA #8743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Øyvind Harboe <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 27, 2025
Member
|
The change is fine but as the tests fail it can't be merged (and needs a tcl format) |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Øyvind Harboe <[email protected]>
Signed-off-by: Øyvind Harboe <[email protected]>
Signed-off-by: Øyvind Harboe <[email protected]>
Collaborator
Author
|
Tested warning mechanism locally by injecting false positives. @jhkim-pii Fixed the other unexpected warnings. |
Collaborator
Author
|
@maliberty automerge? |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
oharboe
force-pushed
the
power-read-spef-warning-check
branch
from
162eb61 to
6a50382
Compare
Collaborator
Author
|
force pushed to clean up my git gaffe |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
@vvbandeira unrelated CI error in pr-merge 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jhkim-pii Warning checking at home. We have this sort of warning checking code in ORFS, but this is good 'nuf for our current purposes.