Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Nov 11, 2025

I only changed HMC/NUTS here to use FastLDF for now.

I think the easier thing is if we replace LogDensityFunction in DynamicPPL, then we don't need to change it here.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (4153a83) to head (1544a40).

Files with missing lines Patch % Lines
src/mcmc/gibbs.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2713      +/-   ##
==========================================
- Coverage   86.47%   82.03%   -4.45%     
==========================================
  Files          21       21              
  Lines        1420     1414       -6     
==========================================
- Hits         1228     1160      -68     
- Misses        192      254      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Turing.jl documentation for PR #2713 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2713/

@penelopeysm penelopeysm force-pushed the py/fldf branch 4 times, most recently from ce9c0a0 to 0cc3e45 Compare November 11, 2025 23:17
@mhauru
Copy link
Member

mhauru commented Nov 12, 2025

I think the easier thing is if we replace LogDensityFunction in DynamicPPL, then we don't need to change it here.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants