VCST-4174: Add optional container attribute #54
Conversation
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.739
Timestamp: 28-10-2025T08:57:31
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.483
Timestamp: 30-10-2025T07:36:07
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.83
Timestamp: 30-10-2025T09:02:36
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.452
Timestamp: 30-10-2025T09:12:32
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.473
Timestamp: 30-10-2025T15:44:56
| } | ||
| else if (cultureName.Length == 2) | ||
| { | ||
| cultureName = availableLanguages.FirstOrDefault(x => cultureName == x.TwoLetterLanguageName)?.CultureName; |
There was a problem hiding this comment.
Bug: Case-sensitive culture name comparison breaks lookup
The culture name lookup compares cultureName with TwoLetterLanguageName using case-sensitive equality, but culture names are case-insensitive by convention in .NET. A 2-letter code like "EN" won't match "en", causing the language lookup to fail when it should succeed. Use StringComparison.OrdinalIgnoreCase for the comparison.
|
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.125
Timestamp: 21-11-2025T13:41:26
Description
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4174
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Xapi_3.928.0-pr-54-c535.zip