This repository was archived by the owner on Oct 11, 2019. It is now read-only.
Export/dev VP-255 use export in do export in pricing #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yecli
reviewed
Aug 15, 2019
...es/vc-module-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/ExportablePricingFull.cs
Outdated
Show resolved
Hide resolved
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Outdated
Show resolved
Hide resolved
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Outdated
Show resolved
Hide resolved
| { | ||
| var newExportDataQuery = new T(); | ||
| newExportDataQuery.Skip = _dataQuery.Skip; | ||
| newExportDataQuery.Take = _dataQuery.Take; |
Contributor
There was a problem hiding this comment.
Not sure we need to fill Skip and Take here with source dataQuery values
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Outdated
Show resolved
Hide resolved
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Show resolved
Hide resolved
| state.Result = Array.Empty<IExportable>(); | ||
| if (state.ReceivedCount < state.TotalCount) | ||
| { | ||
| state.DataQuery.Take = takeNext; |
Contributor
There was a problem hiding this comment.
How dataQuery pagination is respected here? If we sent dataQuery.Take and Skip (e.g. dynamic scroll in viewer), they should be respected based on the states TotalCount-s.
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Outdated
Show resolved
Hide resolved
...e-pricing/VirtoCommerce.PricingModule.Data/ExportImport2/PricingFullExportPagedDataSource.cs
Outdated
Show resolved
Hide resolved
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
use master DataSourse .Take and .Skip Ensure have total count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add PricingFullPagedDataSource
update metadata getters