Adding form_submission prerendering explainer #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
reviewed
Nov 28, 2025
Collaborator
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Looks mostly good to me, with some nits.
Collaborator
|
This generally looks good to me. I've tweaked one of @tunetheweb's code suggestions above just a tiny bit, but I think we can land this explainer once the rest are resolved. I'd clarify in the title of this PR that this is just an explainer addition though, and that we're not actually adding the feature to the spec yet (which is what the current title kind of suggests). |
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
robertlin-chromium
changed the title
tunetheweb
changed the title
tunetheweb
approved these changes
Dec 3, 2025
Collaborator
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Some more nits but overall LGTM so going ahead and approving.
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Collaborator
|
Thanks! I think this is good to merge. Will let @domfarolino have one more chance to review and then merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.