Skip to content

Sorting Count Mismatch #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirLouen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sorting Count Mismatch #5428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions api/api/controllers/search_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,13 +603,16 @@ def _get_result_and_page_count(
if len(results) < page_size:
if page_count == 1:
result_count = len(results)

# If we have fewer results than the requested page size and are
# not on the first page that means that we've reached the end of
# the query and can set the page_count to the currently requested
# page. This means that the `page_count` can change during
# pagination for the same query, but it's the only way to
# communicate under the current v1 API that a query has been exhausted.
page_count = page
page_count = 1
else:
# If we have fewer results than the requested page size and are
# not on the first page that means that we've reached the end of
# the query. Calculate the actual total based on previous pages + current results
actual_total = (page - 1) * page_size + len(results)
result_count = min(result_count, actual_total)
# Set the page_count to the currently requested page. This means that the
# `page_count` can change during pagination for the same query, but it's the
# only way to communicate under the current v1 API that a query has been exhausted.
page_count = page

return result_count, page_count
Loading