Skip to content

Remove ignored in:body GraphQL search query #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove ignored in:body GraphQL search query #10439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cd0631
Remove invalid `in:body` qualifier
desrosj Oct 31, 2025
acc8602
Match both `Core-` and `core-`
desrosj Oct 31, 2025
32cfe07
Remove the `state` field
desrosj Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/reusable-cleanup-pull-requests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,28 +54,36 @@ jobs:

for (const ticket of fixedList) {
const tracTicketUrl = `https://core.trac.wordpress.org/ticket/${ticket}`;
const corePrefix = `Core-${ticket}`;
const corePrefix = `core-${ticket}`;

const query = `
query($searchQuery: String!) {
search(query: $searchQuery, type: ISSUE_ADVANCED, first: 20) {
nodes {
... on PullRequest {
number
state
bodyText
}
}
}
}
`;

const searchQuery = `repo:${context.repo.owner}/${context.repo.repo} is:pr is:open in:body ( "${tracTicketUrl}" OR "${corePrefix}" )`;
const searchQuery = `repo:${context.repo.owner}/${context.repo.repo} is:pr is:open ( "${tracTicketUrl}" OR "${corePrefix}" )`;

const result = await github.graphql(query, {
searchQuery,
});

prNumbers.push(...result.search.nodes.map(pr => pr.number));
// Since search queries will match anywhere for any activity on a pull request, the body specifically needs to be manually checked.
const matchingPRs = result.search.nodes
.filter(
const bodyLower = pr.bodyText.toLowerCase();
Copy link
Member

@westonruter westonruter Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a syntax error to me. Shouldn't the arg to the filter() method look something like:

( pr ) => {
    const bodyLower = pr.bodyText.toLowerCase();
    return bodyLower.includes(tracTicketUrl) || bodyLower.includes(corePrefix);
}

Copy link
Member

@westonruter westonruter Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like so: https://github.com/WordPress/wordpress-develop/pull/10439/files#r2479947685

pr => pr.bodyText.includes(tracTicketUrl) || pr.bodyText.includes(corePrefix)
)
Comment on lines +80 to +83
Copy link
Member

@westonruter westonruter Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.filter(
const bodyLower = pr.bodyText.toLowerCase();
pr => pr.bodyText.includes(tracTicketUrl) || pr.bodyText.includes(corePrefix)
)
.filter(( pr ) => {
const bodyLower = pr.bodyText.toLowerCase();
return bodyLower.includes(tracTicketUrl) || bodyLower.includes(corePrefix);
})

.map(pr => pr.number);

prNumbers.push(...matchingPRs);
}

return prNumbers;
Expand Down