Skip to content

Conversation

@asadister
Copy link

Summary

Adds support for loading ltr.css in RTL-based multilingual WordPress sites, mirroring the existing rtl.css behavior.

Details

  • Introduces wp_style_add_data( $handle, 'ltr', 'replace' ) and 'suffix' modes
  • Uses extra['ltr'] and _css_href() for consistent file resolution
  • Applies style_loader_tag filter for extensibility
  • Ensures compatibility with single-file enqueue behavior in WordPress Core

Trac ticket: https://core.trac.wordpress.org/ticket/64193


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

### Summary
Adds support for loading `ltr.css` in RTL-based multilingual WordPress sites, mirroring the existing `rtl.css` behavior.

### Details
- Introduces `wp_style_add_data( $handle, 'ltr', 'replace' )` and `'suffix'` modes
- Uses `extra['ltr']` and `_css_href()` for consistent file resolution
- Applies `style_loader_tag` filter for extensibility
- Ensures compatibility with single-file enqueue behavior in WordPress Core

### Trac Ticket
See: https://core.trac.wordpress.org/ticket/64193
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Hi @asadister! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props asadister.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@asadister asadister changed the title Update class-wp-styles.php Add ltr.css support for RTL-based multilingual sites Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

remove trailing whitespace on line 274
@asadister
Copy link
Author

Closing in favor of #10476, which includes updated unit tests and resolves coding standards issues.
Thanks for the initial feedback!

@asadister asadister closed this Nov 6, 2025
@asadister asadister deleted the feature/ltr-css-support branch November 6, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant