-
Notifications
You must be signed in to change notification settings - Fork 3.1k
#64194: 6.9 Fetch priority can add 10-20 seconds in page load time #10459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+91
−11
Closed
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f1cf211
Fix for https://core.trac.wordpress.org/ticket/64194#ticket
ciobanu0151 d5ca1d1
Better solution for issue 64194
ciobanu0151 3878d18
coding standards fixes
ciobanu0151 df6561f
Fixed performance issue from ticket 64194 for filter_eligible_strateg…
ciobanu0151 e602aa5
fix for filter_eligible_strategies
ciobanu0151 929af8e
minor code standard fix and also allow empty values in the cache resu…
ciobanu0151 1b15f97
fixed build error
ciobanu0151 be2c24b
Tidy phpdoc
westonruter 8c068bb
Ignore false positive from PHPStan
westonruter 2b2c09c
Clarify test phpdoc
westonruter 0ba1343
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter 3116117
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter 33e8d93
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
westonruter 2115fa9
Simplify test_filter_eligible_strategies_uses_cached_result_for_share…
westonruter eb741e1
Simplify test_highest_fetchpriority_with_dependents_uses_cached_resul…
westonruter 371719b
Update test naming after simplification
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why the lack of a reference caused a performance problem here specifically.
In WordPress 6.3 the same approach was used in the
filter_eligible_strategiesmethod:wordpress-develop/src/wp-includes/class-wp-scripts.php
Line 1005 in f1cf211