Never show notes on the comments page

[adamsilverstein]

Fix an issue where notes can appear on the Comments page if the comment_type=note query parameter is passed to the page.

Even though notes are stored in the comments table, they are distinct and have somewhat different in behavior that makes them i'll suited to displaying on the Comments page. For example, comments are approved, notes are resolved. Comments can be trashed and later restored, noted can only be 'deleted' (although technically they still go in the trash).

We did explore displaying notes on the Comments page anod other surfaces outside the editor such as the Post list pages in WordPress/gutenberg#71743 without arriving at a satisfactory solution.

Trac ticket: Core-64198

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein, desrosj, jeffpaul.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[desrosj]

This looks good and tests well! I had a small nit that I don't feel too strongly about.

The only other thing to call out is that the page will show just the normal "All" view. In my opinion that is fine, but wanted to make note of it.

[jeffpaul]

The only other thing to call out is that the page will show just the normal "All" view. In my opinion that is fine, but wanted to make note of it.

Yeah, there was some heavy conversation a couple weeks ago about more clearly separating out Notes (then Block Comments) from "regular" Comments but it was decided to not make changes there and to come back to that in 7.0. Sorry I don't have a great reference link for that conversation, but its likely in a GitHub issue/PR or two.