-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(spec): Adding a comprehensive error handling description for gRPC and … #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7ff351d
6790a30
f138a48
c263c16
4864c21
5660a4b
6426867
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1542,3 +1542,17 @@ export type A2AError = | |
| | InvalidAgentResponseError | ||
| | AuthenticatedExtendedCardNotConfiguredError; | ||
| // --8<-- [end:A2AError] | ||
|
|
||
| // --8<-- [start:JSONError] | ||
| /** | ||
| * Represents the error format for HTTP+JSON/REST transport error responses. | ||
| */ | ||
| export interface JSONError { | ||
| /** A2A-specific error identifier (e.g., "TASK_NOT_FOUND"). */ | ||
| code: string; | ||
| /** Human-readable error description. */ | ||
| message: string; | ||
| /** Optional additional structured error information. */ | ||
| details?: any; | ||
| } | ||
| // --8<-- [end:JSONError] | ||
|
Comment on lines
+1546
to
+1558
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if I missed this on my earlier review. Is there a reason to have another type here in addition to the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It maps generic json-rpc errors (iow ones in 8.1 in the spec) while a2aerrror maps specific a2A (the ones in 8.2 in the spec). They are different kind of error and I think is more clear this way
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @holtskinner does my previous comment make sense to you? |
||
Uh oh!
There was an error while loading. Please reload this page.