feat: enable geo #2824
feat: enable geo #2824
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| trackingOptions: { | ||
| ipAddress: false, | ||
| ipAddress: true, | ||
| language: false, |
There was a problem hiding this comment.
In rejectAnalytics, the minimal Amplitude init used solely to send analytics_consent_declined now sets trackingOptions.ipAddress to true. The function then temporarily disables opt-out and dispatches the decline event, so even users who explicitly refuse analytics will have their IP/geo data collected for that event. Previously IP collection was disabled in this path, so this is a privacy regression for opt-out users; the rejection flow should not send PII like IP addresses.
Useful? React with 👍 / 👎.
src/store/analyticsSlice.ts
Outdated
| autocapture: false, | ||
| trackingOptions: { | ||
| ipAddress: false, | ||
| ipAddress: true, |
There was a problem hiding this comment.
maybe worth it to double check with legal if we can track IPs while opted out/not opted in yet
There was a problem hiding this comment.
yeah we should not, ive removed
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files