Skip to content

update to node 22 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

update to node 22 #19

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d43eb69
update to node 22
mollpo Jul 24, 2025
59c07d1
add node version file
mollpo Jul 24, 2025
28f6e44
update npm version
mollpo Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ concurrency:

jobs:
checks:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
timeout-minutes: 10
strategy:
matrix:
node_version: [16, 18, 20]
node_version: [ 18, 20, 22 ]
steps:
- uses: actions/checkout@v4
- uses: aboutbits/github-actions-node/setup-and-install@v2
Expand All @@ -26,11 +26,11 @@ jobs:
shell: bash

test:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
timeout-minutes: 10
strategy:
matrix:
node_version: [16, 18, 20]
node_version: [ 18, 20, 22 ]
steps:
- uses: actions/checkout@v4
- uses: aboutbits/github-actions-node/setup-and-install@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ on:
- 'v*'

env:
NODE_VERSION: 20
NODE_VERSION: 22

jobs:
build:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
],
"engines": {
"npm": ">=8",
Copy link

@ThoSap ThoSap Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://help.readymage.com/project-development/node.js-version

npm 10 with Node.js 18
Please do a NPM install after this change

I know I forgot this in https://github.com/aboutbits/zod-locales-formatjs/pull/9/files

Suggested change
"npm": ">=8",
"npm": ">=10"

"node": ">=16"
"node": ">=18"
},
"scripts": {
"build": "rimraf dist && npm run build:esm && npm run build:cjs",
Expand Down