Skip to content

CLI: Pass --no-audit param to npm install command #21591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enisn merged 1 commit into from
Dec 11, 2024
Merged

CLI: Pass --no-audit param to npm install command #21591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/LIbs/InstallLibsService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public async Task InstallLibsAsync(string directory)
}
else
{
NpmHelper.RunNpmInstall(projectDirectory);
NpmHelper.RunNpmInstall(projectDirectory, "--no-audit");
}
}

Expand All @@ -92,7 +92,7 @@ public async Task InstallLibsAsync(string directory)
}
else
{
NpmHelper.RunNpmInstall(projectDirectory);
NpmHelper.RunNpmInstall(projectDirectory, "--no-audit");
}

await CleanAndCopyResources(projectDirectory);
Expand Down
5 changes: 3 additions & 2 deletions framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Utils/NpmHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
Expand Down Expand Up @@ -48,10 +49,10 @@ public bool IsYarnAvailable()
return version > SemanticVersion.Parse("1.20.0");
}

public void RunNpmInstall(string directory)
public void RunNpmInstall(string directory, params string[] args)
{
Logger.LogInformation($"Running npm install on {directory}");
CmdHelper.RunCmd($"npm install", directory);
CmdHelper.RunCmd($"npm install {args.JoinAsString(" ")}", directory);
}

public void RunYarn(string directory)
Expand Down
Loading