Optimization of Stream and Resource Management #21631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced TryCopyToMemoryStreamAsync methods with direct response stream returns in AliyunBlobProvider, AwsBlobProvider, AzureBlobProvider, and FileSystemBlobProvider. - Used using to properly dispose of Image objects in ImageSharpImageCompressorContributor and ImageSharpImageResizerContributor. - Replaced Dispose calls with DisposeAsync for asynchronous resource management in ImageSharpImageCompressorContributor and ImageSharpImageResizerContributor. - Simplified image resizing code in SkiaSharpImageResizerContributor with nested using statements.
Contributor
Author
|
Hi @maliming, could you please take a look at this PR when you have some time? |
Member
|
ok |
maliming
approved these changes
Apr 22, 2025
Member
|
Thanks @1d0n7kn0w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #xxxx (write the related issue number if available)
TODO: Describe what this PR has changed, add screenshot or animated GIF if available, write if it is a breaking change, and how to fix the breaking changes for existing applications if so.
Checklist
How to test it?
Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.