Lazy expandable feature for documentation #21689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salihozkara
requested changes
Dec 23, 2024
Member
There was a problem hiding this comment.
Can you create the url with Url.Page instead of creating it from js? We may have changed the routing in Asp Net Core.
https://github.com/abpframework/abp/blob/dev/modules/docs/src/Volo.Docs.Web/Utils/IDocsLinkGenerator.cs
modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/index.js
Outdated
Show resolved
Hide resolved
modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/Index.cshtml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@salihozkara okay , I added a new |
oykuermann
requested changes
Dec 23, 2024
Contributor
oykuermann
left a comment
oykuermann
left a comment
There was a problem hiding this comment.
Items should be rendered if the main page is open.
salihozkara
approved these changes
Dec 25, 2024
Contributor
This problem still not resolved: |
oykuermann
requested changes
Dec 25, 2024
Contributor
oykuermann
left a comment
oykuermann
left a comment
There was a problem hiding this comment.
I'll check after changes.
oykuermann
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #21095
Checklist
How to test it?
Run the
VoloDocs.Webapp