Skip to content

Conversation

@LordofAvernus
Copy link
Collaborator

@LordofAvernus LordofAvernus commented Dec 3, 2025

User description

…sh and Chinese locales

关联的 issue

https://github.com/actiontech/dms-ee/issues/703

描述你的变更

增加导出邮件提示:导出工单审批通过后,必须在24小时内执行导出,否则将无法导出

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc


Description

  • 新增导出工单审批提醒消息

  • 更新中英文语言配置

  • 增强导出工单审批流程提示


Diagram Walkthrough

flowchart LR
  A["导出工单审批提醒"] -- "中文消息" --> B["internal/pkg/locale/message_zh.go"]
  A -- "英文消息" --> C["internal/pkg/locale/active.en.toml"]
  A -- "中文消息" --> D["internal/pkg/locale/active.zh.toml"]
Loading

File Walkthrough

Relevant files
Enhancement
message_zh.go
添加中文审批提醒配置                                                                                             

internal/pkg/locale/message_zh.go

  • 新增导出工单审批提醒消息键
+1/-0     
active.en.toml
添加英文审批提醒配置                                                                                             

internal/pkg/locale/active.en.toml

  • 增加导出审批提醒英文提示
+1/-0     
active.zh.toml
更新中文审批提醒配置                                                                                             

internal/pkg/locale/active.zh.toml

  • 添加中文审批提醒提示
+1/-0     

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

配置消息更新

请确认新增的提醒消息文本与现有语言配置格式、命名及业务需求保持一致,确保在实际使用中无歧义。

NotifyDataWorkflowBodyApprovalReminder  = &i18n.Message{ID: "NotifyDataWorkflowBodyApprovalReminder", Other: "⏰ 导出工单已审批通过,请在1天内完成导出,过期后将无法执行"}
配置消息更新

请核查英文提醒消息内容是否与中文版本及业务需求保持同步,确保信息传达准确无误。

NotifyDataWorkflowBodyApprovalReminder = "⏰ The export workflow has been approved. Please complete the export within 1 day, otherwise it will expire and cannot be executed"
配置消息更新

请检查中文提醒消息是否与其他语言版本统一,并符合业务中对导出工单审批提醒的逻辑要求。

NotifyDataWorkflowBodyApprovalReminder = "⏰ 导出工单已审批通过,请在1天内完成导出,过期后将无法执行"

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@littleniannian littleniannian merged commit 4eecd14 into main Dec 3, 2025
1 check passed
@littleniannian littleniannian deleted the export_workflow_notify branch December 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants