Remove empty key value pairs when using advanced search hash #1653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a condition in the advanced search hash has an empty value, the condition is not removed so the "LEFT OUTER JOIN" is added to the SQL query without a "WHERE" clause.
Problem
The behavior is not the same when using a simple condition hash (example:
{children_name_eq: ''}) versus using an advanced search hash (example:{c: {'0' => {a: ['children_name'], p: 'eq', v: ['']}}}).The first example results in the following query :
The second example results in the following query :
Proposed solution
I added code to remove conditions with a blank value in the same way it is done with the simple condition.
Do you see a better way to handle this ?