Skip to content

Conversation

@pelby
Copy link

@pelby pelby commented Nov 21, 2025

This commit fixes the "Invalid literal value, expected object" errors that were preventing MCP tools from registering properly.

Changes:

  1. Downgrade Zod from ^4.1.9 to ^3.23.8 (v4 doesn't exist yet)
  2. Remove incorrect .shape extraction in raindropmcp.service.ts line 570
    • Before: inputSchema: (config.inputSchema as z.ZodObject).shape
    • After: inputSchema: config.inputSchema

Testing completed:

  • All 10 MCP tools now register with valid schemas
  • Verified complex parameter types (arrays, objects, enums, booleans)
  • Confirmed proper error handling and validation
  • Tested with Super-MCP integration successfully

🤖 Generated with Claude Code

This commit fixes the "Invalid literal value, expected object" errors
that were preventing MCP tools from registering properly.

Changes:
1. Downgrade Zod from ^4.1.9 to ^3.23.8 (v4 doesn't exist yet)
2. Remove incorrect .shape extraction in raindropmcp.service.ts line 570
   - Before: inputSchema: (config.inputSchema as z.ZodObject<any>).shape
   - After: inputSchema: config.inputSchema

Testing completed:
- All 10 MCP tools now register with valid schemas
- Verified complex parameter types (arrays, objects, enums, booleans)
- Confirmed proper error handling and validation
- Tested with Super-MCP integration successfully

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@gemini-code-assist
Copy link

Summary of Changes

Hello @pelby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical schema registration failures affecting MCP tools. By adjusting the Zod dependency to a compatible version and correcting the way input schemas are processed, it ensures that all tools can now register correctly, improving the stability and functionality of the MCP system.

Highlights

  • Zod Version Downgrade: Downgraded the zod dependency from ^4.1.9 to ^3.23.8 to resolve compatibility issues that were causing schema registration failures.
  • Schema Handling Correction: Removed the incorrect .shape extraction from config.inputSchema in raindropmcp.service.ts, which was leading to "Invalid literal value, expected object" errors during MCP tool registration.
  • MCP Tool Registration Fix: Addressed and resolved the "Invalid literal value, expected object" errors, successfully enabling all 10 MCP tools to register with valid schemas.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves issues with MCP schema registration. The Zod dependency in package.json is updated to a valid version, and the inputSchema assignment in raindropmcp.service.ts is fixed by passing the entire Zod schema object instead of its .shape. These changes are accurate, well-described, and effectively fix the bug, making the tool registration process more robust. Great job on this targeted fix!

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Regenerated bun.lock to match package.json Zod version specification.
Addresses bot feedback on PR adeze#42.

Build and runtime verified working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant