-
Notifications
You must be signed in to change notification settings - Fork 17
fix: resolve MCP schema registration with Zod v3.23.8 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit fixes the "Invalid literal value, expected object" errors that were preventing MCP tools from registering properly. Changes: 1. Downgrade Zod from ^4.1.9 to ^3.23.8 (v4 doesn't exist yet) 2. Remove incorrect .shape extraction in raindropmcp.service.ts line 570 - Before: inputSchema: (config.inputSchema as z.ZodObject<any>).shape - After: inputSchema: config.inputSchema Testing completed: - All 10 MCP tools now register with valid schemas - Verified complex parameter types (arrays, objects, enums, booleans) - Confirmed proper error handling and validation - Tested with Super-MCP integration successfully 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Summary of ChangesHello @pelby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical schema registration failures affecting MCP tools. By adjusting the Zod dependency to a compatible version and correcting the way input schemas are processed, it ensures that all tools can now register correctly, improving the stability and functionality of the MCP system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly resolves issues with MCP schema registration. The Zod dependency in package.json is updated to a valid version, and the inputSchema assignment in raindropmcp.service.ts is fixed by passing the entire Zod schema object instead of its .shape. These changes are accurate, well-described, and effectively fix the bug, making the tool registration process more robust. Great job on this targeted fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Regenerated bun.lock to match package.json Zod version specification. Addresses bot feedback on PR adeze#42. Build and runtime verified working.
This commit fixes the "Invalid literal value, expected object" errors that were preventing MCP tools from registering properly.
Changes:
Testing completed:
🤖 Generated with Claude Code