Skip to content

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Nov 20, 2025

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream contains several changes that require adjustments to the aiobotocore codebase. In particular, login credentials are now supported. This feature relies on a recent version of awscrt. In order to provide optimal test coverage, CI now includes an optional with-awscrt matrix entry, which in turn is enabled by a new optional dependency group awscrt.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version
  • I have added URL to diff: boto/botocore@1.40.70...1.41.5

@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 99.17012% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.59%. Comparing base (12ae615) to head (19871c3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/credentials.py 95.83% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
+ Coverage   91.39%   91.59%   +0.20%     
==========================================
  Files          74       75       +1     
  Lines        7855     8067     +212     
==========================================
+ Hits         7179     7389     +210     
- Misses        676      678       +2     
Flag Coverage Δ
no-httpx 88.46% <40.66%> (-1.51%) ⬇️
os-ubuntu-24.04 91.59% <99.17%> (+0.20%) ⬆️
os-ubuntu-24.04-arm 89.59% <40.66%> (-1.54%) ⬇️
python-3.10 89.56% <40.66%> (-1.54%) ⬇️
python-3.11 89.56% <40.66%> (-1.54%) ⬇️
python-3.12 89.56% <40.66%> (-1.54%) ⬇️
python-3.13 89.56% <40.66%> (-1.54%) ⬇️
python-3.14 91.56% <99.17%> (+0.20%) ⬆️
python-3.9 89.58% <40.66%> (-1.55%) ⬇️
unittests 91.59% <99.17%> (+0.20%) ⬆️
with-awscrt 91.23% <96.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller force-pushed the bump-botocore branch 5 times, most recently from 0dac5f9 to b690342 Compare November 20, 2025 20:57
@jakob-keller jakob-keller marked this pull request as ready for review November 20, 2025 21:02
@jakob-keller jakob-keller force-pushed the bump-botocore branch 3 times, most recently from 29fa2ca to 8dfdb6f Compare November 27, 2025 08:51
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Nov 27, 2025
webknjaz
webknjaz previously approved these changes Nov 27, 2025
@jakob-keller jakob-keller added this pull request to the merge queue Nov 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2025
@jakob-keller jakob-keller added this pull request to the merge queue Nov 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2025
@jakob-keller
Copy link
Collaborator Author

Well, that's a bummer: As soon as the first matrix jobs complete, CodeCov reports a failure due to insufficient coverage. Only after the remaining jobs complete (and combined coverage is sufficient), CodeCov updates its result to success. But that's apparently too late and the pull request has already been automatically removed from the merge queue. Any ideas what can be done about it?

@jakob-keller
Copy link
Collaborator Author

Well, that's a bummer: As soon as the first matrix jobs complete, CodeCov reports a failure due to insufficient coverage. Only after the remaining jobs complete (and combined coverage is sufficient), CodeCov updates its result to success. But that's apparently too late and the pull request has already been automatically removed from the merge queue. Any ideas what can be done about it?

I learned about after_n_builds, which resolves that issue.

@webknjaz
Copy link
Member

Yep, I've been using it everywhere. But it's a pain to track the number of expected uploads. So I've been migrating to explicit notifications: aio-libs/yarl#1577.

@jakob-keller jakob-keller mentioned this pull request Nov 27, 2025
14 tasks
@jakob-keller
Copy link
Collaborator Author

aio-libs/yarl#1577

Neat! See #1437

@jakob-keller jakob-keller marked this pull request as draft November 27, 2025 20:34
auto-merge was automatically disabled November 27, 2025 20:34

Pull request was converted to draft

@jakob-keller jakob-keller marked this pull request as ready for review November 27, 2025 20:57
@jakob-keller jakob-keller added this pull request to the merge queue Nov 28, 2025
Merged via the queue into aio-libs:master with commit 790af50 Nov 28, 2025
23 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch November 28, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants