-
-
Notifications
You must be signed in to change notification settings - Fork 205
Bump botocore dependency specification
#1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
+ Coverage 91.39% 91.59% +0.20%
==========================================
Files 74 75 +1
Lines 7855 8067 +212
==========================================
+ Hits 7179 7389 +210
- Misses 676 678 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0dac5f9 to
b690342
Compare
29fa2ca to
8dfdb6f
Compare
8dfdb6f to
eaa0a9c
Compare
|
Well, that's a bummer: As soon as the first matrix jobs complete, CodeCov reports a failure due to insufficient coverage. Only after the remaining jobs complete (and combined coverage is sufficient), CodeCov updates its result to success. But that's apparently too late and the pull request has already been automatically removed from the merge queue. Any ideas what can be done about it? |
I learned about after_n_builds, which resolves that issue. |
|
Yep, I've been using it everywhere. But it's a pain to track the number of expected uploads. So I've been migrating to explicit notifications: aio-libs/yarl#1577. |
|
Neat! See #1437 |
Pull request was converted to draft
43a4839 to
19871c3
Compare
Description of Change
This PR intends to improve general compatibility of
aiobotocorewithin the Python ecosystem by bumping the dependency specification ofbotocore, as well asboto3andawscli.Assumptions
Upstream contains several changes that require adjustments to the aiobotocore codebase. In particular, login credentials are now supported. This feature relies on a recent version of
awscrt. In order to provide optimal test coverage, CI now includes an optionalwith-awscrtmatrix entry, which in turn is enabled by a new optional dependency groupawscrt.Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions