fix(RenderCircle): auto-set size to diameter for correct bounding box #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make RenderCircle automatically set its size (width/height) to the diameter (radius * 2) when the radius property is set, ensuring the bounding box is correct and consistent with RenderRect and RenderRRect. Changes: - RenderCircle.handleRadiusChange(): automatically sets size to diameter when radius is set, or to 0x0 when radius is 0 - Updated render-circle.stories.tsx to use radius API instead of manually setting width/height Benefits: - Bounding box now correctly matches the visual circle size - Consistent behavior with other shape components (Rect, RRect) - Simplifies usage - users only need to set radius, not width/height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 您好
I ran into this while attempting to create a slider component.
This PR fixes RenderCircle to automatically set its size (width/height) to the diameter (radius * 2) when the radius property is set, ensuring the bounding box is correct and consistent with RenderRect and RenderRRect.
Changes:
Benefits: