some clean up work #100
Merged
some clean up work #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your pull request is automatically being deployed to Dagster Cloud.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to workflows, configuration files, and code improvements. The most important changes include updating the Python version in various workflows, adding new pre-commit hooks, and making various code simplifications and formatting improvements.
Workflow and Configuration Updates:
.github/workflows/branch_deployments.yml: UpdatedPYTHON_VERSIONto3.11and addedDAGSTER_CLOUD_WORKSPACE_PATH..github/workflows/deploy.yml: UpdatedPYTHON_VERSIONto3.11and addedDAGSTER_CLOUD_WORKSPACE_PATH..github/workflows/pre-commit.yaml: Updatedpython-versionto3.11and addedextra_argsfor pre-commit..github/workflows/pytest.yaml: Updated Python setup to version3.11..pre-commit-config.yaml: Addedruff-pre-commithook and updatedisortarguments format.Code Simplifications and Formatting:
anomstack/alerts/asciiart.py: Simplified several methods by removing unnecessary variables and adding comments for clarity. [1] [2] [3] [4] [5] [6]anomstack/alerts/email.py: Added comments for clarity and ignored type checking forserver.login. [1] [2]anomstack/alerts/send.py: Reformatted docstrings for better readability. [1] [2]anomstack/alerts/slack.py: Reformatted docstrings for better readability.anomstack/df/save.py: Reformatted docstrings for better readability.anomstack/df/wrangle.py: Reformatted docstrings and comments for better readability. [1] [2]anomstack/external/gcp/bigquery.py: Reformatted docstrings and added comments for clarity. [1] [2] [3] [4]anomstack/external/gcp/credentials.py: Reformatted docstrings for better readability.New Features:
.vscode/settings.json: Added SQLTools connection settings for SQLite.Makefile: Addedkill-localdandps-localdtargets to manage local Dagster processes. [1] [2]