-
Notifications
You must be signed in to change notification settings - Fork 12
add more demo batches #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…. This cleanup eliminates unused code and YAML settings related to the Hacker News integration.
WalkthroughThe changes update a metrics configuration file by renaming a batch identifier and expand a demo environment profile to include default schedule statuses for several new data sources. No code or public entity declarations are affected; all modifications are limited to configuration files. Changes
Estimated code review effort1 (~2 minutes) Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📊 Test Coverage ReportCoverage: 59% (yellow) ✅ Coverage maintained or improved!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
profiles/demo.env (1)
54-108: Verify new datasource identifiers are aligned with pipeline codeThe added blocks follow the existing pattern, but the orchestration code must recognise the exact identifier string after the double underscores (
__YFINANCE__,__HACKERNEWS__, etc.).
Please double-check that:
- Each integration actually uses the same canonical name (case & spelling) inside its Dagster resources / solids.
- None of these variables are already defined elsewhere in the stack, which would silently override one of the values at runtime.
A quick
grep -R "ANOMSTACK__YFINANCE__"across the repo is usually enough to confirm.
If the identifiers differ (e.g.HNvsHACKERNEWSorCOIN_DESKvsCOINDESK), schedules will never start.metrics/examples/hackernews/hackernews.yaml (1)
12-13: Ingestion script path still carries the old name – consider renaming for consistencyThe batch is now
"hackernews", yet the script included ishn_top_stories_scores.py.
Keeping mismatched naming makes future maintenance harder.Option A (preferred): rename the file to
hackernews.py(and update this include).
Option B: keep the file name but add a comment explaining the legacy name.No functional breakage right now, but aligning names avoids drift.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
metrics/examples/hackernews/hackernews.yaml(1 hunks)profiles/demo.env(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
metrics/examples/hackernews/hackernews.yaml (1)
1-1: Confirm every downstream reference to the old batch ID is goneChanging
metric_batchto"hackernews"is fine, but any code, DB table, or dashboard still keyed on the previous string (hn_top_stories_scores) will now be orphaned.
Please run an automated search to ensure no hard-coded references remain.
This pull request introduces changes to streamline metric configurations and enable default schedules for various data sources. The key updates include renaming a metric configuration file and updating its content, as well as adding default schedule statuses for multiple data sources in the environment configuration.
Metric configuration updates:
metrics/examples/hackernews/hn_top_stories_scores.yamltometrics/examples/hackernews/hackernews.yamland updated themetric_batchvalue fromhn_top_stories_scorestohackernewsfor consistency.Environment configuration updates:
YFinance,HackerNews,CoinDesk,Weather,EirGrid,PostHog, andPrometheus) inprofiles/demo.env. Each data source hasINGEST,TRAIN,SCORE,ALERT, andCHANGEschedules set toRUNNING, whileLLMALERTschedules are set toSTOPPED.Summary by CodeRabbit