Skip to content

Conversation

@andrewm4894
Copy link
Owner

@andrewm4894 andrewm4894 commented Jul 22, 2025

This pull request introduces changes to streamline metric configurations and enable default schedules for various data sources. The key updates include renaming a metric configuration file and updating its content, as well as adding default schedule statuses for multiple data sources in the environment configuration.

Metric configuration updates:

  • Renamed metrics/examples/hackernews/hn_top_stories_scores.yaml to metrics/examples/hackernews/hackernews.yaml and updated the metric_batch value from hn_top_stories_scores to hackernews for consistency.

Environment configuration updates:

  • Added default schedule statuses for several new data sources (YFinance, HackerNews, CoinDesk, Weather, EirGrid, PostHog, and Prometheus) in profiles/demo.env. Each data source has INGEST, TRAIN, SCORE, ALERT, and CHANGE schedules set to RUNNING, while LLMALERT schedules are set to STOPPED.

Summary by CodeRabbit

  • Chores
    • Updated metric batch identifier for HackerNews in the configuration.
    • Added environment variable settings to enable default schedule statuses for several new data sources, including YFinance, HackerNews, CoinDesk, Weather, EirGrid, PostHog, and Prometheus. Most scheduled tasks are enabled by default, except for LLMALERT, which remains stopped.

…. This cleanup eliminates unused code and YAML settings related to the Hacker News integration.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

The changes update a metrics configuration file by renaming a batch identifier and expand a demo environment profile to include default schedule statuses for several new data sources. No code or public entity declarations are affected; all modifications are limited to configuration files.

Changes

File(s) Change Summary
metrics/examples/hackernews/hackernews.yaml Renamed metric batch identifier from "hn_top_stories_scores" to "hackernews".
profiles/demo.env Added environment variable settings to enable default schedule statuses for YFinance, HackerNews, CoinDesk, Weather, EirGrid, PostHog, and Prometheus data sources.

Estimated code review effort

1 (~2 minutes)

Poem

In configs and envs, the changes are neat,
New sources now march to a scheduled beat.
HackerNews gets a fresh new name,
While demo.env joins the integration game.
🐇 With each tweak and variable set,
The system grows stronger—on that, you can bet!

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@andrewm4894 andrewm4894 marked this pull request as ready for review July 22, 2025 22:33
@github-actions
Copy link

📊 Test Coverage Report

Coverage: 59% (yellow)

✅ Coverage maintained or improved!

💡 See detailed coverage report in the tests README

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
profiles/demo.env (1)

54-108: Verify new datasource identifiers are aligned with pipeline code

The added blocks follow the existing pattern, but the orchestration code must recognise the exact identifier string after the double underscores (__YFINANCE__, __HACKERNEWS__, etc.).
Please double-check that:

  1. Each integration actually uses the same canonical name (case & spelling) inside its Dagster resources / solids.
  2. None of these variables are already defined elsewhere in the stack, which would silently override one of the values at runtime.

A quick grep -R "ANOMSTACK__YFINANCE__" across the repo is usually enough to confirm.
If the identifiers differ (e.g. HN vs HACKERNEWS or COIN_DESK vs COINDESK), schedules will never start.

metrics/examples/hackernews/hackernews.yaml (1)

12-13: Ingestion script path still carries the old name – consider renaming for consistency

The batch is now "hackernews", yet the script included is hn_top_stories_scores.py.
Keeping mismatched naming makes future maintenance harder.

Option A (preferred): rename the file to hackernews.py (and update this include).
Option B: keep the file name but add a comment explaining the legacy name.

No functional breakage right now, but aligning names avoids drift.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd78d99 and bc9190b.

📒 Files selected for processing (2)
  • metrics/examples/hackernews/hackernews.yaml (1 hunks)
  • profiles/demo.env (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
🔇 Additional comments (1)
metrics/examples/hackernews/hackernews.yaml (1)

1-1: Confirm every downstream reference to the old batch ID is gone

Changing metric_batch to "hackernews" is fine, but any code, DB table, or dashboard still keyed on the previous string (hn_top_stories_scores) will now be orphaned.
Please run an automated search to ensure no hard-coded references remain.

@andrewm4894 andrewm4894 merged commit d0edee2 into main Jul 22, 2025
3 checks passed
@andrewm4894 andrewm4894 deleted the enable-more-demo-batches branch July 22, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants