-
Notifications
You must be signed in to change notification settings - Fork 263
Update README to include RC #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cy245, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the project's documentation by introducing a new section in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a section on Restore Credentials to the README file. The explanation is mostly correct and provides a good overview. I've suggested a minor wording change to improve the clarity and technical accuracy of one sentence.
| new device. In Shrine, this is created in `AuthenticationScreen.kt` upon signing in successfully and | ||
| passing the `createRestoreKey()` function in to the View Model. This is also done in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of how a restore credential is created is a bit confusing and technically inaccurate. It says a function is passed to the View Model, but it's more accurate to say a View Model function is called. Also, "in to" should be "into", and using "a restore credential" instead of "this" would be clearer. I suggest rephrasing for better clarity and accuracy.
| new device. In Shrine, this is created in `AuthenticationScreen.kt` upon signing in successfully and | |
| passing the `createRestoreKey()` function in to the View Model. This is also done in | |
| new device. In Shrine, a restore credential is created in `AuthenticationScreen.kt` upon successful | |
| sign-in by calling the View Model's `createRestoreKey()` function. This is also done in |
shumelchyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.