🎉Add new `NumberExtensionsCS14` nuget package #1620

Ted-Jin-Lab · 2025-09-20T03:58:10Z

Add new project NumberExtensionsCS14 to use the C#14 feature extension members for making 5.Meters work.

Please merge after C#14 is officially released.

angularsen · 2025-09-21T13:33:27Z

@claude Review this PR. In addition to the standard prompt, also comment on what target frameworks we should use for the two projects.

claude · 2025-09-21T13:33:40Z

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

angularsen · 2025-09-21T13:40:17Z

@claude Review PR

claude · 2025-09-21T13:40:32Z

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

angularsen · 2025-09-21T13:48:52Z

Seems Claude doesn't work for PRs from forks due to security:
anthropics/claude-code-action#339

UnitsNet.NumberExtensions.CS14/UnitsNet.NumberExtensions.CS14.csproj

angularsen · 2025-09-21T15:20:55Z

Local review by Claude:

PR Review: Add C# 14 Extension Members Support

Thank you for this contribution! The implementation of C# 14's extension members feature is well-structured and properly integrated into the code
generation pipeline. However, there are several issues that need to be addressed before merging.

🔴 Issues to Fix

Package ID Conflict
- The UnitsNet.NumberExtensions.CS14.csproj has <PackageId>UnitsNet.NumberExtensions</PackageId> which conflicts with the existing package
- Fix: Change to <PackageId>UnitsNet.NumberExtensions.CS14</PackageId>
Missing Documentation
- No README updates or documentation explaining the new package
- Users need to know:
  - How to use the new syntax (5.Meters vs Length.FromMeters(5))
  - C# 14 preview requirement
  - Differences from the existing NumberExtensions package
Test Coverage Gap (wrong, they do test correct syntax)
- While test files are generated, they don't actually test the extension member syntax
- The tests use traditional syntax, not the new 5.Meters syntax
- Consider adding integration tests that verify the extension syntax works correctly
Typo in PR Title
- "pakcage" → "package"

⚠️ Considerations

C# 14 Status
- C# 14 is not yet officially released
- The project uses <LangVersion>preview</LangVersion> requiring preview compiler
- As mentioned in the PR description, consider waiting for official C# 14 release
Maintenance Burden
- This adds another package to maintain
- Generated code size increases significantly (260+ new files)
- Consider if this should be a separate package or integrated into the main NumberExtensions package once C# 14 is stable

✅ Good Implementation

Properly integrated into the existing code generation pipeline
Follows project structure and patterns
Conditional compilation for different .NET versions
Code builds successfully
Strong naming and package metadata properly configured

📋 Checklist Before Merge

Fix PackageId to UnitsNet.NumberExtensions.CS14
Add documentation/README section explaining the new package
Add example usage in documentation showing 5.Meters syntax
Consider adding integration tests for extension member syntax
Fix typo in PR title
Confirm timeline - wait for C# 14 official release?

💡 Suggestion

Consider adding a simple example in the PR description or README:

// Old way (existing NumberExtensions)
using UnitsNet.NumberExtensions.NumberToLength;
var length = 5.Meters();

// New way (CS14 extension members)
using UnitsNet.NumberExtensions.NumberToLength;
var length = 5.Meters; // No parentheses needed!

Overall, this is a solid implementation that will be valuable once C# 14 is released. The issues above are mostly configuration and documentation
related, with the core implementation being sound.

This review provides clear, actionable feedback with specific issues to fix, formatted for easy reading on GitHub.

angularsen

Per Claude review:

Fix PackageId to UnitsNet.NumberExtensions.CS14
Add documentation/README section explaining the new package
Add example usage in documentation showing 5.Meters syntax
Fix typo in PR title
Confirm timeline - wait for C# 14 official release?

See inline comments above:
#1620 (review)

angularsen

Also, build scripts must be updated to include new projects:

angularsen · 2025-09-21T15:25:33Z

CodeGen/Generators/UnitsNetGenerator.cs

            var extensionsOutputDir = $"{rootDir}/UnitsNet.NumberExtensions/GeneratedCode";
            var extensionsTestOutputDir = $"{rootDir}/UnitsNet.NumberExtensions.Tests/GeneratedCode";
+            var extensionsCs14OutputDir = $"{rootDir}/UnitsNet.NumberExtensions.CS14/GeneratedCode";
+            var extensionsCs14TestOutputDir = $"{rootDir}/UnitsNet.NumberExtensions.CS14.Tests/GeneratedCode";


The CS14 projects are NOT included in the build-functions.psm1 file. This means:

Build Script Issues Found

The new CS14 projects are missing from the build pipeline:

Not in test list (line 63-67): UnitsNet.NumberExtensions.CS14.Tests is not included in the Start-Tests function

Not in NuGet pack list (line 102-106): UnitsNet.NumberExtensions.CS14 is not included in the Start-PackNugets function

This means:

✅ The projects ARE in the solution file and will build with dotnet build

❌ The tests won't run in CI/CD pipeline

❌ The NuGet package won't be created in CI/CD pipeline

Here's the additional feedback to add to the PR review:

🔴 Build Pipeline Issue

The new CS14 projects are missing from the build pipeline configuration:

File: Build/build-functions.psm1

Tests not running in CI - Add to line ~65:

$projectPaths = @( "UnitsNet.Tests\UnitsNet.Tests.csproj", "UnitsNet.NumberExtensions.Tests\UnitsNet.NumberExtensions.Tests.csproj", "UnitsNet.NumberExtensions.CS14.Tests\UnitsNet.NumberExtensions.CS14.Tests.csproj", # ADD THIS "UnitsNet.Serialization.JsonNet.Tests\UnitsNet.Serialization.JsonNet.Tests.csproj" ) 2. NuGet package not created in CI - Add to line ~105: $projectPaths = @( "UnitsNet\UnitsNet.csproj", "UnitsNet.Serialization.JsonNet\UnitsNet.Serialization.JsonNet.csproj", "UnitsNet.NumberExtensions\UnitsNet.NumberExtensions.csproj", "UnitsNet.NumberExtensions.CS14\UnitsNet.NumberExtensions.CS14.csproj" # ADD THIS ) Without these changes, the CS14 package won't be tested or published by the CI/CD pipeline. This is a critical issue that would prevent the package from being properly tested and published.

We could merge this earlier if we get the CI pipeline to build and run tests with .NET 10 SDK preview.

I pushed an attempt to fix this, let's see if the pipeline works now.

Claude happily fixed these issues, so I pushed a fix for the build scripts also.

Oh, thanks. I didn't check the Package Id, description and the build script. Sorry about that.

No worries, that's what reviews are for 👍

- Add .NET 10 SDK preview installation to Azure Pipelines - Include CS14 projects in build, test, and pack scripts

- Fix ID conflict (now UnitsNet.NumberExtensions.CS14) - Update package title and description for clarity

- Document new UnitsNet.NumberExtensions.CS14 package - Show examples of C# 14 extension members syntax (no parentheses) - Compare with classic extension methods syntax - Note requirements for C# 14 preview and .NET 10 SDK

- Ensures consistent SDK version across development environments - Required for C# 14 extension members support - Allows prerelease versions with rollForward to latest feature

The .NET 10 preview SDK doesn't include the .NET 9 runtime, which is required to run the CodeGen project (targets net9.0). Install both .NET 9 and .NET 10 SDKs to ensure all runtimes are available.

The ILLink analyzer throws InvalidCastException with C# 14 extension members due to incompatibility with the preview syntax. Disable AOT until this is fixed. This resolves the CSC error AD0001 during compilation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> # Conflicts: # .claude/settings.local.json

The pipeline was missing .NET 8 SDK installation, causing test failures when trying to run net8.0 targeted tests. Added .NET 8 SDK installation to both azure-pipelines.yml and azure-pipelines-pr.yml. Error was: "You must install or update .NET to run this application" for the net8.0 test assemblies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Changed global.json to require minimum .NET 9 SDK with rollForward to latestMajor, allowing it to use .NET 10 preview when available but fall back to .NET 9 on CI runners. Previous setting required exact version 10.0.0 which didn't match the installed 10.0.0-rc.1.x preview versions, causing build failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Configure global.json to allow both latest .NET 9 SDK and any .NET 10 preview SDKs: - Minimum version: 9.0.0 - allowPrerelease: true (allows .NET 10 previews/RCs) - rollForward: latestMajor (allows using newer major versions) This ensures the project uses .NET 10 preview when available for C# 14 support, but gracefully falls back to .NET 9 on systems without it. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

This reverts commit e7fd329.

angularsen · 2025-09-21T21:05:26Z

Sorry for hijacking this, but Claude just went with it and decided to try and make it work with preview .NET10 SDK. Looks good in our PR and CI pipelines, so I'll merge this for now as it should no longer block anything.

angularsen · 2025-09-22T06:04:00Z

Nuget is out @ArchiDog1998
https://www.nuget.org/packages/UnitsNet.NumberExtensions.CS14/6.0.0-pre017

It's prerelease, as v6 currently is.

Ted-Jin-Lab · 2025-09-22T06:23:19Z

Sadly, it doesn’t work right now. Maybe it will after C# 14 is officially released.

angularsen · 2025-09-22T12:24:25Z

Does it compile with dotnet build though and .NET 10 SDK?

Ted-Jin-Lab and others added 3 commits September 20, 2025 11:53

🎉Add new NumberExtensionsCS14 nuget pakcage to make 5.Meters work (…

0a404e8

…angularsen#1619)

🐛langversion fix.

fb2c9f1

Merge branch 'master' into number-extensions-cs14

28224d6

angularsen reviewed Sep 21, 2025

View reviewed changes

UnitsNet.NumberExtensions.CS14/UnitsNet.NumberExtensions.CS14.csproj Outdated Show resolved Hide resolved

UnitsNet.NumberExtensions.CS14/UnitsNet.NumberExtensions.CS14.csproj Outdated Show resolved Hide resolved

angularsen changed the title ~~🎉Add new NumberExtensionsCS14 nuget pakcage~~ 🎉Add new NumberExtensionsCS14 nuget package Sep 21, 2025

angularsen requested changes Sep 21, 2025

View reviewed changes

angularsen and others added 14 commits September 21, 2025 17:32

Fix CI/CD pipeline for new projects and C# 14 support

9546427

- Add .NET 10 SDK preview installation to Azure Pipelines - Include CS14 projects in build, test, and pack scripts

Fix PackageId and update title/description

59e165e

- Fix ID conflict (now UnitsNet.NumberExtensions.CS14) - Update package title and description for clarity

Merge branch 'master' into number-extensions-cs14

ac06e03

Add C# 14 extension members documentation to README

a88e09f

- Document new UnitsNet.NumberExtensions.CS14 package - Show examples of C# 14 extension members syntax (no parentheses) - Compare with classic extension methods syntax - Note requirements for C# 14 preview and .NET 10 SDK

Fix CI and add global.json to specify .NET 10 SDK preview

ef3fdbe

- Ensures consistent SDK version across development environments - Required for C# 14 extension members support - Allows prerelease versions with rollForward to latest feature

Merge branch 'master' into number-extensions-cs14

fcd388e

Fix CI/CD pipeline to install .NET 9 SDK

af9d18a

The .NET 10 preview SDK doesn't include the .NET 9 runtime, which is required to run the CodeGen project (targets net9.0). Install both .NET 9 and .NET 10 SDKs to ensure all runtimes are available.

Merge branch 'master' into number-extensions-cs14

e2e4af5

Add permissions for claude in pr/ci workflows

e7fd329

Revert "Add permissions for claude in pr/ci workflows"

ee2f64b

This reverts commit e7fd329.

Merge branch 'master' into number-extensions-cs14

8ff09ab

angularsen merged commit 5db5782 into angularsen:master Sep 21, 2025

🎉Add new NumberExtensionsCS14 nuget package #1620

🎉Add new NumberExtensionsCS14 nuget package #1620

Uh oh!

Conversation

Ted-Jin-Lab commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angularsen commented Sep 21, 2025

Uh oh!

claude bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angularsen commented Sep 21, 2025

Uh oh!

claude bot commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angularsen commented Sep 21, 2025

Uh oh!

Uh oh!

Uh oh!

angularsen commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: Add C# 14 Extension Members Support

🔴 Issues to Fix

⚠️ Considerations

✅ Good Implementation

📋 Checklist Before Merge

💡 Suggestion

Uh oh!

angularsen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angularsen left a comment

Choose a reason for hiding this comment

Uh oh!

angularsen Sep 21, 2025

Choose a reason for hiding this comment

🔴 Build Pipeline Issue

Uh oh!

angularsen Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

angularsen Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

Ted-Jin-Lab Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

angularsen Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

angularsen commented Sep 21, 2025

Uh oh!

angularsen commented Sep 22, 2025

Uh oh!

Ted-Jin-Lab commented Sep 22, 2025

Uh oh!

angularsen commented Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

🎉Add new `NumberExtensionsCS14` nuget package #1620

🎉Add new `NumberExtensionsCS14` nuget package #1620

Ted-Jin-Lab commented Sep 20, 2025 •

edited

Loading

claude bot commented Sep 21, 2025 •

edited

Loading

claude bot commented Sep 21, 2025 •

edited

Loading

angularsen commented Sep 21, 2025 •

edited

Loading

angularsen left a comment •

edited

Loading