Skip to content

fix(brush-select): change onSelect callback return type from state ob… #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aarebecca merged 2 commits into from
Nov 27, 2025
+3 −4
Merged

fix(brush-select): change onSelect callback return type from state ob… #7348

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cf62c
fix(brush-select): change onSelect callback return type from state ob…
lyw405 Aug 20, 2025
2d36d3c
Merge branch 'v5' into fix/brush-select-onselect-callback-#7303
Aarebecca Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/g6/src/behaviors/brush-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ export interface BrushSelectOptions extends BaseBehaviorOptions {
*
* <en/> Callback when brush select elements.
* @param states - 选中的元素状态
* @returns 选中的元素状态
*/
onSelect?: (states: Record<ID, State | State[]>) => Record<ID, State | State[]>;
onSelect?: (states: Record<ID, State | State[]>) => void;
}
/**
* <zh/> 框选一组元素
Expand Down Expand Up @@ -246,7 +245,7 @@ export class BrushSelect extends BaseBehavior<BrushSelectOptions> {

const selectedIds = this.selector(graph, points, enableElements);

let states: Record<ID, State | State[]> = {};
const states: Record<ID, State | State[]> = {};

switch (mode) {
case 'union':
Expand Down Expand Up @@ -274,7 +273,7 @@ export class BrushSelect extends BaseBehavior<BrushSelectOptions> {
break;
}

if (isFunction(onSelect)) states = onSelect(states);
if (isFunction(onSelect)) onSelect(states);

graph.setElementState(states, this.options.animation);
}
Expand Down
Loading