-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: drag-element add trigger config #7497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @XiaoMing-xmg666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 为 drag-element 行为增加了一个 trigger 配置项,允许用户通过组合键来触发拖拽,这是一个很好的功能增强。代码整体实现清晰,但在 isKeydown 方法的实现上,我发现一个问题可能会导致默认行为发生非预期的改变。当 trigger 未配置或为空数组时,拖拽应该总是允许的,但目前的实现会限制在没有任何按键按下的情况下才能拖拽。我已经在具体的代码行提出了修改建议以修正此问题。
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #7497 +/- ##
==========================================
- Coverage 95.60% 95.59% -0.01%
==========================================
Files 188 188
Lines 9874 9881 +7
Branches 2083 2133 +50
==========================================
+ Hits 9440 9446 +6
- Misses 402 435 +33
+ Partials 32 0 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
482db53 to
b5a5d31
Compare
|
文档和代码在一个 pr 里面完成吧,避免官网出现不一致。 |
@hustcc 加上了 |
Feat: #7100

增加了drag-element trigger配置项,文档改动之后再提一个pr,效果如下