-
Notifications
You must be signed in to change notification settings - Fork 367
add AmsAssignService and ZkBucketAssignStore to implement balanced bucket allocation in master-slave mode #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wardlican
wants to merge
12
commits into
apache:master
Choose a base branch
from
wardlican:amoro#3921
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
…on in master-slave mode. apache#3921
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3922 +/- ##
============================================
+ Coverage 29.00% 29.22% +0.22%
- Complexity 3850 3915 +65
============================================
Files 631 630 -1
Lines 50770 50997 +227
Branches 6543 6518 -25
============================================
+ Hits 14724 14906 +182
- Misses 34989 35039 +50
+ Partials 1057 1052 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This implements the logic for dynamically and evenly distributing buckets based on the number of AMS nodes.
Close #3921 .
Brief change log
AmsAssignService Functionality
ZkBucketAssignStore Features
/{cluster}/amoro/ams/bucket-assignments/{nodeKey}/assignmentsand/{cluster}/amoro/ams/bucket-assignments/{nodeKey}/last-update-timetwo classes that work together to implement dynamic bucket ID allocation and storage in master-slave mode.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation