Skip to content

Conversation

@AbhishekPathania
Copy link
Contributor

@AbhishekPathania AbhishekPathania commented Nov 24, 2025

What changes were proposed in this pull request?

Adds support for custom volumes and volumeMounts in Amoro Helm chart, enabling users to mount additional volumes without modifying chart templates.

Resolves #3966

Why are the changes needed?

Users need to mount custom resources like:

  • Java truststore for SSL/TLS certificates
  • Configuration files
  • Secrets (API keys, credentials)
  • Persistent volumes

Currently, these require forking/patching the chart.

Does this PR introduce any user-facing change?

Yes. Users can now specify custom volumes in values.yaml:

volumes:
  - name: java-truststore
    secret:
      secretName: java-truststore-secret

volumeMounts:
  - name: java-truststore
    mountPath: /opt/java/truststore
    readOnly: true

How was this patch tested?

  • Verified Helm template rendering with custom volumes
  • Tested with Java truststore secret mount
  • Confirmed backward compatibility (no volumes specified = no change)

@AbhishekPathania AbhishekPathania changed the title [Improvement][Helm] Support custom volumes and volumeMounts [AMORO-3966][Helm] Support custom volumes and volumeMounts Nov 24, 2025
Copy link
Contributor

@xxubai xxubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks @AbhishekPathania

@xxubai xxubai merged commit cbdc517 into apache:master Nov 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Support custom volumes and volumeMounts in Helm chart

2 participants