-
Notifications
You must be signed in to change notification settings - Fork 44
GraphLike with addAll #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Would you please look into fixing the Java 21 build? I'm not comfortable adding new feature until we get builds on Java LTS versions fixed. TY! |
garydgregory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @naturzukunft
-1 as is because there are no unit tests.
FYI: New public and protected elements need Javadoc since tags.
- RepositoryDatasetImpl#addAll - RepositoryGraphImpl#addAll
|
@garydgregory Tests added |
|
@garydgregory please do not merge this PR yet. i was able to run my tests with 0.6.0-SNAPSHOT and have a strange behaviour. i have to find that problems first. |
Then please make this a draft PR. |
|
Hello @naturzukunft Thank you for your updates. I just did a bit of housekeeping. Would you mind rebasing this PR on git master? |
done |
|
@garydgregory do you find time to review this PR? |
|
@garydgregory ??? |
|
JaCoCo says the PR lowers the test coverage. |
I'm a bit lost in the github PRs so I decided to close PR 205 and create this one.
Original Description
Sorry for the inconvenience !