Skip to content

Conversation

@naturzukunft
Copy link
Contributor

I'm a bit lost in the github PRs so I decided to close PR 205 and create this one.

Original Description

Sorry for the inconvenience !

@garydgregory
Copy link
Member

Hi @naturzukunft

Would you please look into fixing the Java 21 build? I'm not comfortable adding new feature until we get builds on Java LTS versions fixed.

TY!

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @naturzukunft

-1 as is because there are no unit tests.

FYI: New public and protected elements need Javadoc since tags.

- RepositoryDatasetImpl#addAll
- RepositoryGraphImpl#addAll
@naturzukunft
Copy link
Contributor Author

@garydgregory Tests added

@naturzukunft
Copy link
Contributor Author

@garydgregory please do not merge this PR yet. i was able to run my tests with 0.6.0-SNAPSHOT and have a strange behaviour. i have to find that problems first.

@garydgregory
Copy link
Member

@garydgregory please do not merge this PR yet. i was able to run my tests with 0.6.0-SNAPSHOT and have a strange behaviour. i have to find that problems first.

Then please make this a draft PR.

@garydgregory
Copy link
Member

Hello @naturzukunft

Thank you for your updates. I just did a bit of housekeeping. Would you mind rebasing this PR on git master?

@naturzukunft
Copy link
Contributor Author

Hello @naturzukunft

Thank you for your updates. I just did a bit of housekeeping. Would you mind rebasing this PR on git master?

done

@naturzukunft
Copy link
Contributor Author

@garydgregory do you find time to review this PR?
How is the release plan for commons-rdf 0.6.0 ?

@naturzukunft
Copy link
Contributor Author

@garydgregory ???

@garydgregory
Copy link
Member

@naturzukunft

JaCoCo says the PR lowers the test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants