-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[Fix-17396] Update old command key constants #17397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we can deserialize the task params to SubWorkflowParameters in method checkSubWorkflowDefinitionValid.
yes, i realized, i committed a new code. should i revert |
No, you can do change on |
ok. |
f457146 to
128a3e9
Compare
|



Purpose of the pull request
close #17396 .
Brief change log
update constants.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md