Skip to content

Conversation

@reele
Copy link
Contributor

@reele reele commented Aug 5, 2025

Purpose of the pull request

close #17396 .

Brief change log

update constants.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@reele reele requested a review from SbloodyS as a code owner August 5, 2025 08:02
@SbloodyS SbloodyS added the bug Something isn't working label Aug 5, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone Aug 5, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we can deserialize the task params to SubWorkflowParameters in method checkSubWorkflowDefinitionValid.

@reele
Copy link
Contributor Author

reele commented Aug 5, 2025

It would be better if we can deserialize the task params to SubWorkflowParameters in method checkSubWorkflowDefinitionValid.

yes, i realized, i committed a new code.

should i revert CommandKeyConstants ?

@reele reele requested a review from caishunfeng as a code owner August 5, 2025 09:08
@ruanwenjun
Copy link
Member

It would be better if we can deserialize the task params to SubWorkflowParameters in method checkSubWorkflowDefinitionValid.

yes, i realized, i committed a new code.

should i revert CommandKeyConstants ?

No, you can do change on CommandKeyConstants if we still need to use this class, if we don't rely on this class, then we can remove it.

@reele
Copy link
Contributor Author

reele commented Aug 5, 2025

It would be better if we can deserialize the task params to SubWorkflowParameters in method checkSubWorkflowDefinitionValid.

yes, i realized, i committed a new code.
should i revert CommandKeyConstants ?

No, you can do change on CommandKeyConstants if we still need to use this class, if we don't rely on this class, then we can remove it.

ok.

@sonarqubecloud
Copy link

@SbloodyS SbloodyS modified the milestones: 3.3.1, 3.3.2 Aug 21, 2025
@SbloodyS SbloodyS modified the milestones: 3.3.2, 3.3.3 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working priority:high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [CommandKeyConstants] Constants need to be updated.

3 participants