Skip to content

[Improvement-17570][Task-Plugin] Use protoc in gRPC Task Plugin #17603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[Improvement-17570][Task-Plugin] Use protoc in gRPC Task Plugin #17603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ed80db0
[Build] Add dependency for protoc
npofsi Oct 27, 2025
016cbe5
Merge branch 'dev' into subr
SbloodyS Oct 27, 2025
2f18423
Merge branch 'dev' into subr
SbloodyS Oct 27, 2025
c0d40fd
Merge branch 'dev' into subr
SbloodyS Oct 30, 2025
a3b8cb3
[Feat] Add desc file parser
npofsi Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,30 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.github.os72</groupId>
<artifactId>protobuf-dynamic</artifactId>
<version>0.9.5</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.github.os72</groupId>
<artifactId>protoc-jar</artifactId>
<version>3.11.4</version>
</dependency>
<dependency>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions ...c/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protofactory/DynamicService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package org.apache.dolphinscheduler.plugin.task.grpc.protofactory;

public class DynamicService {
}
25 changes: 25 additions & 0 deletions ...src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protofactory/ProtoFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package org.apache.dolphinscheduler.plugin.task.grpc.protofactory;
import com.github.os72.protocjar.Protoc;
import com.google.protobuf.DescriptorProtos;

import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;

public class ProtoFactory {
public static void runProtoc(String[] args) throws IOException, InterruptedException {

// String[] args = {"-v2.4.1", "--help"};
Protoc.runProtoc(args);
}

public static void loadDescFile() throws IOException {
final FileInputStream fileInputStream = new FileInputStream("directory/descriptors.dsc");

Check warning

Code scanning / CodeQL

Potential input resource leak Warning

This FileInputStream is not always closed on method exit.
final DescriptorProtos.FileDescriptorSet descriptorSet = DescriptorProtos.FileDescriptorSet.parseFrom(fileInputStream);

for (DescriptorProtos.FileDescriptorProto fileDescriptor : descriptorSet.getFileList()) {

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'FileDescriptorProto fileDescriptor' is never read.
// Do as you wish with fileDescriptor
}
}
}

Loading