Skip to content

Added all possible exceptions to MySQLInputSourceDatabaseConnectorTest #18734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −3
Open

Added all possible exceptions to MySQLInputSourceDatabaseConnectorTest #18734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
687a1e0
Added all possible exceptions to tests
EdwinIngJ Nov 6, 2025
68e7b34
Added dependency to pom.xml
EdwinIngJ Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions-core/mysql-metadata-storage/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

</project>
22 changes: 19 additions & 3 deletions .../src/test/java/org/apache/druid/metadata/input/MySQLInputSourceDatabaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.druid.metadata.storage.mysql.MySQLConnectorDriverConfig;
import org.apache.druid.metadata.storage.mysql.MySQLMetadataStorageModule;
import org.apache.druid.server.initialization.JdbcAccessSecurityConfig;
import org.hamcrest.CoreMatchers;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Rule;
Expand Down Expand Up @@ -167,7 +168,12 @@ public String getConnectURI()

JdbcAccessSecurityConfig securityConfig = newSecurityConfigEnforcingAllowList(ImmutableSet.of(""));

expectedException.expectMessage("The property [password] is not in the allowed list");
expectedException.expectMessage(
CoreMatchers.anyOf(
CoreMatchers.containsString("The property [password] is not in the allowed list"),
CoreMatchers.containsString("The property [user] is not in the allowed list")
)
);
expectedException.expect(IllegalArgumentException.class);

new MySQLInputSourceDatabaseConnector(
Expand Down Expand Up @@ -241,7 +247,12 @@ public String getConnectURI()

JdbcAccessSecurityConfig securityConfig = newSecurityConfigEnforcingAllowList(ImmutableSet.of("none", "nonenone"));

expectedException.expectMessage("The property [password] is not in the allowed list");
expectedException.expectMessage(
CoreMatchers.anyOf(
CoreMatchers.containsString("The property [password] is not in the allowed list"),
CoreMatchers.containsString("The property [user] is not in the allowed list")
)
);
expectedException.expect(IllegalArgumentException.class);

new MySQLInputSourceDatabaseConnector(
Expand Down Expand Up @@ -291,7 +302,12 @@ public String getConnectURI()

JdbcAccessSecurityConfig securityConfig = newSecurityConfigEnforcingAllowList(ImmutableSet.of("user", "nonenone"));

expectedException.expectMessage("The property [password] is not in the allowed list");
expectedException.expectMessage(
CoreMatchers.anyOf(
CoreMatchers.containsString("The property [password] is not in the allowed list"),
CoreMatchers.containsString("The property [keyonly] is not in the allowed list")
)
);
expectedException.expect(IllegalArgumentException.class);

new MySQLInputSourceDatabaseConnector(
Expand Down
Loading