protect against an illegal sublist if hydrants is empty #18743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfaraz
reviewed
Nov 14, 2025
| bytesPersisted += sink.getBytesInMemory(); | ||
|
|
||
| final int limit = sink.isWritable() ? hydrants.size() - 1 : hydrants.size(); | ||
| final int limit = sink.isWritable() ? Integer.max(0, hydrants.size() - 1) : hydrants.size(); |
Contributor
There was a problem hiding this comment.
Is it possible to have a small UT for this?
Contributor
Author
There was a problem hiding this comment.
I couldn't figure out how to accomplish it. So for full disclosure the test case I came up with is courtesy of Claude coming up with a way to force the empty list of hydrants scenario. Confirmed that without the fix it is an IAE and with the change, no exception.
kfaraz
approved these changes
Nov 14, 2025
kfaraz
approved these changes
Nov 19, 2025
Comment on lines
+2549
to
+2555
| /** | ||
| * Tests an edge case where a writable sink exists but has no hydrants. | ||
| * <p> | ||
| * The test scenario is somewhat unrealistic, but we are trying to prevent a regression because this issue was seen in | ||
| * the wild and resulted in failed indexing tasks due to an IAE. | ||
| * </p> | ||
| */ |
Contributor
There was a problem hiding this comment.
I think the javadoc here can be omitted.
Also, since it was already reported, I think it is a valid scenario.
| * </p> | ||
| */ | ||
| @Test | ||
| public void testPersistAllWithEmptySink() throws Exception |
Contributor
There was a problem hiding this comment.
Nit: update the method name to reflect the expected behaviour with the suffix IsNoop or DoesNotFail, etc.
Suggested change
| public void testPersistAllWithEmptySink() throws Exception | |
| public void testPersistAllWithEmptySinkIsNoop() throws Exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If hydrants is empty here, it can lead to an IAE creating a sublist of hydrants with invalid indices.
This PR has: